From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 23 Mar 2018 11:44:29 +0000 Subject: [PATCH] drm/gma500: simplify a condition in psbfb_mmap() Message-Id: <20180323114429.GE28518@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Patrik Jakobsson Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org Since we enforce that "vma->vm_pgoff" has to be zero it means we don't need an additional cap on the upper bound. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index cb0a2ae916e0..a6732bffb2e2 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -166,9 +166,7 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma) struct psb_fbdev *fbdev = info->par; struct psb_framebuffer *psbfb = &fbdev->pfb; - if (vma->vm_pgoff != 0) - return -EINVAL; - if (vma->vm_pgoff > (~0UL >> PAGE_SHIFT)) + if (vma->vm_pgoff) return -EINVAL; if (!psbfb->addr_space) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH] drm/gma500: simplify a condition in psbfb_mmap() Date: Fri, 23 Mar 2018 14:44:29 +0300 Message-ID: <20180323114429.GE28518@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by gabe.freedesktop.org (Postfix) with ESMTPS id E68D66E06C for ; Fri, 23 Mar 2018 11:44:40 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Patrik Jakobsson Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org U2luY2Ugd2UgZW5mb3JjZSB0aGF0ICJ2bWEtPnZtX3Bnb2ZmIiBoYXMgdG8gYmUgemVybyBpdCBt ZWFucyB3ZSBkb24ndApuZWVkIGFuIGFkZGl0aW9uYWwgY2FwIG9uIHRoZSB1cHBlciBib3VuZC4K ClNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4K CmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZ21hNTAwL2ZyYW1lYnVmZmVyLmMgYi9kcml2 ZXJzL2dwdS9kcm0vZ21hNTAwL2ZyYW1lYnVmZmVyLmMKaW5kZXggY2IwYTJhZTkxNmUwLi5hNjcz MmJmZmIyZTIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9nbWE1MDAvZnJhbWVidWZmZXIu YworKysgYi9kcml2ZXJzL2dwdS9kcm0vZ21hNTAwL2ZyYW1lYnVmZmVyLmMKQEAgLTE2Niw5ICsx NjYsNyBAQCBzdGF0aWMgaW50IHBzYmZiX21tYXAoc3RydWN0IGZiX2luZm8gKmluZm8sIHN0cnVj dCB2bV9hcmVhX3N0cnVjdCAqdm1hKQogCXN0cnVjdCBwc2JfZmJkZXYgKmZiZGV2ID0gaW5mby0+ cGFyOwogCXN0cnVjdCBwc2JfZnJhbWVidWZmZXIgKnBzYmZiID0gJmZiZGV2LT5wZmI7CiAKLQlp ZiAodm1hLT52bV9wZ29mZiAhPSAwKQotCQlyZXR1cm4gLUVJTlZBTDsKLQlpZiAodm1hLT52bV9w Z29mZiA+ICh+MFVMID4+IFBBR0VfU0hJRlQpKQorCWlmICh2bWEtPnZtX3Bnb2ZmKQogCQlyZXR1 cm4gLUVJTlZBTDsKIAogCWlmICghcHNiZmItPmFkZHJfc3BhY2UpCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=