diff for duplicates of <20180323134433.00001530@huawei.com> diff --git a/a/1.txt b/N1/1.txt index 428dd51..ca2bc51 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ On Wed, 21 Mar 2018 11:28:53 -0300 -Hern=E1n Gonzalez <hernan@vanguardiasur.com.ar> wrote: +Hernán Gonzalez <hernan@vanguardiasur.com.ar> wrote: -> Signed-off-by: Hern=E1n Gonzalez <hernan@vanguardiasur.com.ar> +> Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar> Hmm. This sort of patch is always a trade off between clearing out unused code and the fact that the defines sometimes provide useful information even when not @@ -11,16 +11,15 @@ actually used. > drivers/staging/iio/cdc/ad7746.c | 16 ---------------- > drivers/staging/iio/cdc/ad7746.h | 5 ----- > 2 files changed, 21 deletions(-) ->=20 -> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/a= -d7746.c +> +> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c > index 57623db..cba8cd1 100644 > --- a/drivers/staging/iio/cdc/ad7746.c > +++ b/drivers/staging/iio/cdc/ad7746.c > @@ -25,7 +25,6 @@ > * AD7746 Register Definition > */ -> =20 +> > -#define AD7746_REG_STATUS 0 > #define AD7746_REG_CAP_DATA_HIGH 1 > #define AD7746_REG_VT_DATA_HIGH 4 @@ -28,7 +27,7 @@ d7746.c > @@ -38,17 +37,10 @@ > #define AD7746_REG_CAP_GAINH 15 > #define AD7746_REG_VOLT_GAINH 17 -> =20 +> > -/* Status Register Bit Designations (AD7746_REG_STATUS) */ > -#define AD7746_STATUS_EXCERR BIT(3) > -#define AD7746_STATUS_RDY BIT(2) @@ -38,8 +37,7 @@ d7746.c Hmm. My gut feeling is the driver really should be reading this register... Ah well. Perhaps it can go in the meantime. -> /* Capacitive Channel Setup Register Bit Designations (AD7746_REG_CAP_SE= -TUP) */ +> /* Capacitive Channel Setup Register Bit Designations (AD7746_REG_CAP_SETUP) */ > #define AD7746_CAPSETUP_CAPEN BIT(7) > #define AD7746_CAPSETUP_CIN2 BIT(6) /* AD7746 only */ > #define AD7746_CAPSETUP_CAPDIFF BIT(5) @@ -47,9 +45,8 @@ TUP) */ Don't remove definitions of 'parts' of a register. It is odd to only have some parts described. -> =20 -> /* Voltage/Temperature Setup Register Bit Designations (AD7746_REG_VT_SE= -TUP) */ +> +> /* Voltage/Temperature Setup Register Bit Designations (AD7746_REG_VT_SETUP) */ > #define AD7746_VTSETUP_VTEN (1 << 7) > @@ -56,13 +48,8 @@ > #define AD7746_VTSETUP_VTMD_EXT_TEMP (1 << 5) @@ -60,7 +57,7 @@ TUP) */ > -#define AD7746_VTSETUP_VTCHOP BIT(0) Same comment, keep these as odd to not know if the rest of the register is used etc... -> =20 +> > /* Excitation Setup Register Bit Designations (AD7746_REG_EXC_SETUP) */ > -#define AD7746_EXCSETUP_CLKCTRL BIT(7) > -#define AD7746_EXCSETUP_EXCON BIT(6) @@ -80,16 +77,15 @@ in the driver (and they should be - for example we should power down on remove). Don't remove their definitions. > #define AD7746_CONF_MODE_OFFS_CAL (5 << 0) > #define AD7746_CONF_MODE_GAIN_CAL (6 << 0) -> =20 -> diff --git a/drivers/staging/iio/cdc/ad7746.h b/drivers/staging/iio/cdc/a= -d7746.h +> +> diff --git a/drivers/staging/iio/cdc/ad7746.h b/drivers/staging/iio/cdc/ad7746.h > index ea8572d..2fbcee8 100644 > --- a/drivers/staging/iio/cdc/ad7746.h > +++ b/drivers/staging/iio/cdc/ad7746.h > @@ -13,11 +13,6 @@ > * TODO: struct ad7746_platform_data needs to go into include/linux/iio > */ -> =20 +> > -#define AD7466_EXCLVL_0 0 /* +-VDD/8 */ > -#define AD7466_EXCLVL_1 1 /* +-VDD/4 */ > -#define AD7466_EXCLVL_2 2 /* +-VDD * 3/8 */ diff --git a/a/content_digest b/N1/content_digest index 411670a..be47b51 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -14,9 +14,9 @@ "\00:1\0" "b\0" "On Wed, 21 Mar 2018 11:28:53 -0300\n" - "Hern=E1n Gonzalez <hernan@vanguardiasur.com.ar> wrote:\n" + "Hern\303\241n Gonzalez <hernan@vanguardiasur.com.ar> wrote:\n" "\n" - "> Signed-off-by: Hern=E1n Gonzalez <hernan@vanguardiasur.com.ar>\n" + "> Signed-off-by: Hern\303\241n Gonzalez <hernan@vanguardiasur.com.ar>\n" "Hmm. This sort of patch is always a trade off between\n" "clearing out unused code and the fact that the defines\n" "sometimes provide useful information even when not\n" @@ -26,16 +26,15 @@ "> drivers/staging/iio/cdc/ad7746.c | 16 ----------------\n" "> drivers/staging/iio/cdc/ad7746.h | 5 -----\n" "> 2 files changed, 21 deletions(-)\n" - ">=20\n" - "> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/a=\n" - "d7746.c\n" + "> \n" + "> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c\n" "> index 57623db..cba8cd1 100644\n" "> --- a/drivers/staging/iio/cdc/ad7746.c\n" "> +++ b/drivers/staging/iio/cdc/ad7746.c\n" "> @@ -25,7 +25,6 @@\n" "> * AD7746 Register Definition\n" "> */\n" - "> =20\n" + "> \n" "> -#define AD7746_REG_STATUS\t\t0\n" "> #define AD7746_REG_CAP_DATA_HIGH\t1\n" "> #define AD7746_REG_VT_DATA_HIGH\t\t4\n" @@ -43,7 +42,7 @@ "> @@ -38,17 +37,10 @@\n" "> #define AD7746_REG_CAP_GAINH\t\t15\n" "> #define AD7746_REG_VOLT_GAINH\t\t17\n" - "> =20\n" + "> \n" "> -/* Status Register Bit Designations (AD7746_REG_STATUS) */\n" "> -#define AD7746_STATUS_EXCERR\t\tBIT(3)\n" "> -#define AD7746_STATUS_RDY\t\tBIT(2)\n" @@ -53,8 +52,7 @@ "Hmm. My gut feeling is the driver really should be reading this\n" "register... Ah well. Perhaps it can go in the meantime.\n" "\n" - "> /* Capacitive Channel Setup Register Bit Designations (AD7746_REG_CAP_SE=\n" - "TUP) */\n" + "> /* Capacitive Channel Setup Register Bit Designations (AD7746_REG_CAP_SETUP) */\n" "> #define AD7746_CAPSETUP_CAPEN\t\tBIT(7)\n" "> #define AD7746_CAPSETUP_CIN2\t\tBIT(6) /* AD7746 only */\n" "> #define AD7746_CAPSETUP_CAPDIFF\t\tBIT(5)\n" @@ -62,9 +60,8 @@ "Don't remove definitions of 'parts' of a register.\n" "It is odd to only have some parts described.\n" "\n" - "> =20\n" - "> /* Voltage/Temperature Setup Register Bit Designations (AD7746_REG_VT_SE=\n" - "TUP) */\n" + "> \n" + "> /* Voltage/Temperature Setup Register Bit Designations (AD7746_REG_VT_SETUP) */\n" "> #define AD7746_VTSETUP_VTEN\t\t(1 << 7)\n" "> @@ -56,13 +48,8 @@\n" "> #define AD7746_VTSETUP_VTMD_EXT_TEMP\t(1 << 5)\n" @@ -75,7 +72,7 @@ "> -#define AD7746_VTSETUP_VTCHOP\t\tBIT(0)\n" "Same comment, keep these as odd to not know if the rest of the register\n" "is used etc...\n" - "> =20\n" + "> \n" "> /* Excitation Setup Register Bit Designations (AD7746_REG_EXC_SETUP) */\n" "> -#define AD7746_EXCSETUP_CLKCTRL\t\tBIT(7)\n" "> -#define AD7746_EXCSETUP_EXCON\t\tBIT(6)\n" @@ -95,16 +92,15 @@ "down on remove). Don't remove their definitions.\n" "> #define AD7746_CONF_MODE_OFFS_CAL\t(5 << 0)\n" "> #define AD7746_CONF_MODE_GAIN_CAL\t(6 << 0)\n" - "> =20\n" - "> diff --git a/drivers/staging/iio/cdc/ad7746.h b/drivers/staging/iio/cdc/a=\n" - "d7746.h\n" + "> \n" + "> diff --git a/drivers/staging/iio/cdc/ad7746.h b/drivers/staging/iio/cdc/ad7746.h\n" "> index ea8572d..2fbcee8 100644\n" "> --- a/drivers/staging/iio/cdc/ad7746.h\n" "> +++ b/drivers/staging/iio/cdc/ad7746.h\n" "> @@ -13,11 +13,6 @@\n" "> * TODO: struct ad7746_platform_data needs to go into include/linux/iio\n" "> */\n" - "> =20\n" + "> \n" "> -#define AD7466_EXCLVL_0\t\t0 /* +-VDD/8 */\n" "> -#define AD7466_EXCLVL_1\t\t1 /* +-VDD/4 */\n" "> -#define AD7466_EXCLVL_2\t\t2 /* +-VDD * 3/8 */\n" @@ -118,4 +114,4 @@ "> \tunsigned char exclvl;\t/*Excitation Voltage Level */\n" "> \tbool exca_en;\t\t/* enables EXCA pin as the excitation output */" -f47487fff728e12d7f97c461cd98fdeaf38c1d71cdc4cd4a2982eab6de49b546 +3b5ea5fd92141c7a66299b2d76c46f45a3807de336620462364bc4f416d35b32
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.