diff for duplicates of <20180323140427.000018f3@huawei.com> diff --git a/a/1.txt b/N1/1.txt index 5ff5805..4c16494 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,63 +1,50 @@ On Wed, 21 Mar 2018 11:28:48 -0300 -Hern=E1n Gonzalez <hernan@vanguardiasur.com.ar> wrote: +Hernán Gonzalez <hernan@vanguardiasur.com.ar> wrote: -> This patch series aims to move the cdc ad7746 driver out of staging. I ha= -ve some +> This patch series aims to move the cdc ad7746 driver out of staging. I have some > design questions though so I would introduce them here, along with a short > description of each patch. ->=20 +> > *PATCH 0001 - Adjust arguments to match open parenthesis. > There were a couple CHECKS that still remained, so I got rid of them. Don't bother describing straight forward patches in the cover letter. Adds noise to the interesting message. ->=20 +> > *PATCH 0002 - Fix multiple line dereference -> In this case, I opted for avoiding the multiple line derefence and having= - a 80+ -> characters line instead as I consider that it improves readability. I may= - be +> In this case, I opted for avoiding the multiple line derefence and having a 80+ +> characters line instead as I consider that it improves readability. I may be > wrong though, so this patch could just be discarded. ->=20 +> > *PATCH 0003 - Reorder includes alphabetically ->=20 +> > *PATCH 0004 - Reorder variable declarations in an inverser-pyramid way ->=20 +> > *PATCH 0005 - Remove unused defines -> There were a few too many #defines that were not used at all, so I just r= -emoved -> them. I guess if someone plans on extending the drivers functionality the= -y can -> be added again, but they were just wasting space as they were. Again, I c= -ould be +> There were a few too many #defines that were not used at all, so I just removed +> them. I guess if someone plans on extending the drivers functionality they can +> be added again, but they were just wasting space as they were. Again, I could be > wrong with this decision so this patch could just be discarded. ->=20 +> > *PATCH 0006 - Add dt-bindings -> This patch adds dt bindings by populating the old pdata struct. It suppor= -ts both -> platform_data and dt-bindings but uses only one depending on CONFIG_OF. I= - chose -> this way to avoid modifying too much the code, and introduce no errors (o= -r as -> few as I could), keeping the same functionality and maintaining support o= -f the +> This patch adds dt bindings by populating the old pdata struct. It supports both +> platform_data and dt-bindings but uses only one depending on CONFIG_OF. I chose +> this way to avoid modifying too much the code, and introduce no errors (or as +> few as I could), keeping the same functionality and maintaining support of the > platform_data. ->=20 +> > *PATCH 0007 - Add remove() -> I added a remove function so I could test that the driver probed properly= - when +> I added a remove function so I could test that the driver probed properly when > compiled as a module with the new dt-bindings. ->=20 +> > *PATCH 0008 - Add comments to clarify some of the calculations -> I had to go through most of the datasheet to understand some of the math = -in the +> I had to go through most of the datasheet to understand some of the math in the > code, so I added comments where I saw fit. (Comments on the comments are > welcome). ->=20 +> > *PATCH 0009 - Add devicetree bindings documentation -> Add documentation on the devicetree bindings, explaining the properties o= -f it +> Add documentation on the devicetree bindings, explaining the properties of it > and describing a short example. ->=20 +> > *PATCH 0010 - Rename sysfs attrs to comply with the ABI > Comments are welcome on this one. > I shortened the names of the sysfs attrs to comply with the ABI: @@ -67,39 +54,34 @@ Hmm. so this one is interesting (note I didn't read the cover letter and most people don't so better to have put this discussion in that patches own description. ->=20 +> > The device supports 2 ways of calibrating the gain (from the datasheet): > 'The gain can be changed by executing a capacitance gain > calibration mode, for which an external full-scale capacitance > needs to be connected to the capacitance input, or by writing a > user value to the capacitive gain register.' So the second case is valid for the calibscale ABI, the second not. ->=20 +> > The same for the offset calibration: > 'One method of adjusting the offset is to connect a zero-scale > capacitance to the input and execute the capacitance offset > calibration mode. The calibration sets the midpoint of the -> =B14.096 pF range (that is, Output Code 0x800000) to that +> ±4.096 pF range (that is, Output Code 0x800000) to that > zero-scale input. > Another method would be to calculate and write the offset cali- > bration register value, the LSB is value 31.25 aF (4.096 pF/2^17 ).' ->=20 -> The driver only supports the first way in both cases, as it only writes t= -he -> register that starts the calibration mode and doesn't allow the user to w= -rite +> +> The driver only supports the first way in both cases, as it only writes the +> register that starts the calibration mode and doesn't allow the user to write > anything on other registers. ->=20 -> What I understand from the ABI is not so different when explaining calibb= -ias and +> +> What I understand from the ABI is not so different when explaining calibbias and > calibscale: > 'Description: -> Hardware applied calibration {offset,scale factor} (assumed to fix produc= -tion +> Hardware applied calibration {offset,scale factor} (assumed to fix production > inaccuracies).' ->=20 -> Maybe I'm missing something and the renaming is not good. I would be real= -ly +> +> Maybe I'm missing something and the renaming is not good. I would be really > grateful if someone could shed some light on this for me. You are correct - it isn't good. We can't 'bend' the ABI like this as userspace would have no idea what to do with it. @@ -109,17 +91,17 @@ make sure to provide documentation of the new ABI /Documentation/ABI/testing/sysfs-bus-iio-ad7746 (for now - we can move to the shared docs if it makes sense later). ->=20 +> > *PATCH 0011 - Move cdc ad7746 driver out of staging to mainline iio > Move the files, modify the proper Kconfigs and the documentation. ->=20 +> > That'd be all. Any feedback is welcome. I hope this gets out of staging :) ->=20 +> > Cheers, ->=20 -> Hern=E1n ->=20 -> Hern=E1n Gonzalez (11): +> +> Hernán +> +> Hernán Gonzalez (11): > staging: iio: ad7746: Adjust arguments to match open parenthesis > staging: iio: ad7746: Fix multiple line dereference > staging: iio: ad7746: Reorder includes alphabetically @@ -131,17 +113,16 @@ to the shared docs if it makes sense later). > staging: iio: ad7746: Add devicetree bindings documentation > staging: iio: ad7746: Rename sysfs attrs to comply with the ABI > Move cdc ad7746 driver out of staging to mainline iio ->=20 +> > .../devicetree/bindings/iio/cdc/ad7746.txt | 32 ++++ > drivers/iio/Kconfig | 1 + > drivers/iio/cdc/Kconfig | 16 ++ -> drivers/{staging =3D> }/iio/cdc/ad7746.c | 168 +++++++++++++= -++------ +> drivers/{staging => }/iio/cdc/ad7746.c | 168 +++++++++++++++------ > drivers/staging/iio/cdc/Kconfig | 10 -- -> .../staging =3D> include/linux}/iio/cdc/ad7746.h | 9 -- +> .../staging => include/linux}/iio/cdc/ad7746.h | 9 -- > 6 files changed, 168 insertions(+), 68 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/cdc/ad7746.txt > create mode 100644 drivers/iio/cdc/Kconfig -> rename drivers/{staging =3D> }/iio/cdc/ad7746.c (84%) -> rename {drivers/staging =3D> include/linux}/iio/cdc/ad7746.h (70%) ->=20 +> rename drivers/{staging => }/iio/cdc/ad7746.c (84%) +> rename {drivers/staging => include/linux}/iio/cdc/ad7746.h (70%) +> diff --git a/a/content_digest b/N1/content_digest index df0780c..5b301c7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -13,65 +13,52 @@ "\00:1\0" "b\0" "On Wed, 21 Mar 2018 11:28:48 -0300\n" - "Hern=E1n Gonzalez <hernan@vanguardiasur.com.ar> wrote:\n" + "Hern\303\241n Gonzalez <hernan@vanguardiasur.com.ar> wrote:\n" "\n" - "> This patch series aims to move the cdc ad7746 driver out of staging. I ha=\n" - "ve some\n" + "> This patch series aims to move the cdc ad7746 driver out of staging. I have some\n" "> design questions though so I would introduce them here, along with a short\n" "> description of each patch.\n" - ">=20\n" + "> \n" "> *PATCH 0001 - Adjust arguments to match open parenthesis.\n" "> There were a couple CHECKS that still remained, so I got rid of them.\n" "Don't bother describing straight forward patches in the cover letter.\n" "Adds noise to the interesting message.\n" - ">=20\n" + "> \n" "> *PATCH 0002 - Fix multiple line dereference\n" - "> In this case, I opted for avoiding the multiple line derefence and having=\n" - " a 80+\n" - "> characters line instead as I consider that it improves readability. I may=\n" - " be\n" + "> In this case, I opted for avoiding the multiple line derefence and having a 80+\n" + "> characters line instead as I consider that it improves readability. I may be\n" "> wrong though, so this patch could just be discarded.\n" - ">=20\n" + "> \n" "> *PATCH 0003 - Reorder includes alphabetically\n" - ">=20\n" + "> \n" "> *PATCH 0004 - Reorder variable declarations in an inverser-pyramid way\n" - ">=20\n" + "> \n" "> *PATCH 0005 - Remove unused defines\n" - "> There were a few too many #defines that were not used at all, so I just r=\n" - "emoved\n" - "> them. I guess if someone plans on extending the drivers functionality the=\n" - "y can\n" - "> be added again, but they were just wasting space as they were. Again, I c=\n" - "ould be\n" + "> There were a few too many #defines that were not used at all, so I just removed\n" + "> them. I guess if someone plans on extending the drivers functionality they can\n" + "> be added again, but they were just wasting space as they were. Again, I could be\n" "> wrong with this decision so this patch could just be discarded.\n" - ">=20\n" + "> \n" "> *PATCH 0006 - Add dt-bindings\n" - "> This patch adds dt bindings by populating the old pdata struct. It suppor=\n" - "ts both\n" - "> platform_data and dt-bindings but uses only one depending on CONFIG_OF. I=\n" - " chose\n" - "> this way to avoid modifying too much the code, and introduce no errors (o=\n" - "r as\n" - "> few as I could), keeping the same functionality and maintaining support o=\n" - "f the\n" + "> This patch adds dt bindings by populating the old pdata struct. It supports both\n" + "> platform_data and dt-bindings but uses only one depending on CONFIG_OF. I chose\n" + "> this way to avoid modifying too much the code, and introduce no errors (or as\n" + "> few as I could), keeping the same functionality and maintaining support of the\n" "> platform_data.\n" - ">=20\n" + "> \n" "> *PATCH 0007 - Add remove()\n" - "> I added a remove function so I could test that the driver probed properly=\n" - " when\n" + "> I added a remove function so I could test that the driver probed properly when\n" "> compiled as a module with the new dt-bindings.\n" - ">=20\n" + "> \n" "> *PATCH 0008 - Add comments to clarify some of the calculations\n" - "> I had to go through most of the datasheet to understand some of the math =\n" - "in the\n" + "> I had to go through most of the datasheet to understand some of the math in the\n" "> code, so I added comments where I saw fit. (Comments on the comments are\n" "> welcome).\n" - ">=20\n" + "> \n" "> *PATCH 0009 - Add devicetree bindings documentation\n" - "> Add documentation on the devicetree bindings, explaining the properties o=\n" - "f it\n" + "> Add documentation on the devicetree bindings, explaining the properties of it\n" "> and describing a short example.\n" - ">=20\n" + "> \n" "> *PATCH 0010 - Rename sysfs attrs to comply with the ABI\n" "> Comments are welcome on this one.\n" "> I shortened the names of the sysfs attrs to comply with the ABI:\n" @@ -81,39 +68,34 @@ "and most people don't so better to have put this discussion in that patches\n" "own description.\n" "\n" - ">=20\n" + "> \n" "> The device supports 2 ways of calibrating the gain (from the datasheet):\n" "> 'The gain can be changed by executing a capacitance gain\n" "> calibration mode, for which an external full-scale capacitance\n" "> needs to be connected to the capacitance input, or by writing a\n" "> user value to the capacitive gain register.'\n" "So the second case is valid for the calibscale ABI, the second not.\n" - ">=20\n" + "> \n" "> The same for the offset calibration:\n" "> 'One method of adjusting the offset is to connect a zero-scale\n" "> capacitance to the input and execute the capacitance offset\n" "> calibration mode. The calibration sets the midpoint of the\n" - "> =B14.096 pF range (that is, Output Code 0x800000) to that\n" + "> \302\2614.096 pF range (that is, Output Code 0x800000) to that\n" "> zero-scale input.\n" "> Another method would be to calculate and write the offset cali-\n" "> bration register value, the LSB is value 31.25 aF (4.096 pF/2^17 ).'\n" - ">=20\n" - "> The driver only supports the first way in both cases, as it only writes t=\n" - "he\n" - "> register that starts the calibration mode and doesn't allow the user to w=\n" - "rite\n" + "> \n" + "> The driver only supports the first way in both cases, as it only writes the\n" + "> register that starts the calibration mode and doesn't allow the user to write\n" "> anything on other registers.\n" - ">=20\n" - "> What I understand from the ABI is not so different when explaining calibb=\n" - "ias and\n" + "> \n" + "> What I understand from the ABI is not so different when explaining calibbias and\n" "> calibscale:\n" "> 'Description:\n" - "> Hardware applied calibration {offset,scale factor} (assumed to fix produc=\n" - "tion\n" + "> Hardware applied calibration {offset,scale factor} (assumed to fix production\n" "> inaccuracies).'\n" - ">=20\n" - "> Maybe I'm missing something and the renaming is not good. I would be real=\n" - "ly\n" + "> \n" + "> Maybe I'm missing something and the renaming is not good. I would be really\n" "> grateful if someone could shed some light on this for me.\n" "You are correct - it isn't good. We can't 'bend' the ABI like this as\n" "userspace would have no idea what to do with it.\n" @@ -123,17 +105,17 @@ "/Documentation/ABI/testing/sysfs-bus-iio-ad7746 (for now - we can move\n" "to the shared docs if it makes sense later).\n" "\n" - ">=20\n" + "> \n" "> *PATCH 0011 - Move cdc ad7746 driver out of staging to mainline iio\n" "> Move the files, modify the proper Kconfigs and the documentation.\n" - ">=20\n" + "> \n" "> That'd be all. Any feedback is welcome. I hope this gets out of staging :)\n" - ">=20\n" + "> \n" "> Cheers,\n" - ">=20\n" - "> Hern=E1n\n" - ">=20\n" - "> Hern=E1n Gonzalez (11):\n" + "> \n" + "> Hern\303\241n\n" + "> \n" + "> Hern\303\241n Gonzalez (11):\n" "> staging: iio: ad7746: Adjust arguments to match open parenthesis\n" "> staging: iio: ad7746: Fix multiple line dereference\n" "> staging: iio: ad7746: Reorder includes alphabetically\n" @@ -145,19 +127,18 @@ "> staging: iio: ad7746: Add devicetree bindings documentation\n" "> staging: iio: ad7746: Rename sysfs attrs to comply with the ABI\n" "> Move cdc ad7746 driver out of staging to mainline iio\n" - ">=20\n" + "> \n" "> .../devicetree/bindings/iio/cdc/ad7746.txt | 32 ++++\n" "> drivers/iio/Kconfig | 1 +\n" "> drivers/iio/cdc/Kconfig | 16 ++\n" - "> drivers/{staging =3D> }/iio/cdc/ad7746.c | 168 +++++++++++++=\n" - "++------\n" + "> drivers/{staging => }/iio/cdc/ad7746.c | 168 +++++++++++++++------\n" "> drivers/staging/iio/cdc/Kconfig | 10 --\n" - "> .../staging =3D> include/linux}/iio/cdc/ad7746.h | 9 --\n" + "> .../staging => include/linux}/iio/cdc/ad7746.h | 9 --\n" "> 6 files changed, 168 insertions(+), 68 deletions(-)\n" "> create mode 100644 Documentation/devicetree/bindings/iio/cdc/ad7746.txt\n" "> create mode 100644 drivers/iio/cdc/Kconfig\n" - "> rename drivers/{staging =3D> }/iio/cdc/ad7746.c (84%)\n" - "> rename {drivers/staging =3D> include/linux}/iio/cdc/ad7746.h (70%)\n" - >=20 + "> rename drivers/{staging => }/iio/cdc/ad7746.c (84%)\n" + "> rename {drivers/staging => include/linux}/iio/cdc/ad7746.h (70%)\n" + > -a2caf142672f808b3fff2b1089bfac6004c1e7ccc7b9e6a049d91030df6dd1f3 +0454421b9b8a7091630b4b71ac97c69acf28482ae4ca8567ddd7716411901cff
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.