From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3] drm/i915: Don't spew errors when resetting HDMI scrambling/bit clock ratio fails Date: Fri, 23 Mar 2018 17:24:20 +0200 Message-ID: <20180323152420.GB5453@intel.com> References: <20180322132227.23810-1-ville.syrjala@linux.intel.com> <20180322154707.22103-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A90F66E61A for ; Fri, 23 Mar 2018 15:24:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Sharma, Shashank" Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMjIsIDIwMTggYXQgMDk6Mzc6NDNQTSArMDUzMCwgU2hhcm1hLCBTaGFzaGFu ayB3cm90ZToKPiAKPiBPbiAzLzIyLzIwMTggOToxNyBQTSwgVmlsbGUgU3lyamFsYSB3cm90ZToK PiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gPgo+ID4gV2hlbiB3ZSdyZSBkaXNhYmxpbmcgdGhlIEhETUkgbGluayB3ZSB0cnkgdG8gcmVz ZXQgdGhlIHNjcmFtYmxpbmcgYW5kCj4gPiBUTURTIGJpdCBjbG9jayByYXRpbyBiYWNrIHRvIHRo ZSBkZWZhdWx0IHZhbHVlcy4gVGhpcyB3aWxsIGZhaWwgaWYgdGhlCj4gPiBzaW5rIGhhcyBhbHJl YWR5IGJlZW4gZGlzY29ubmVjdGVkLiBUaHVzIHdlIHNob3VsZCBub3QgcHJpbnQgYW4gZXJyb3IK PiA+IG1lc3NhZ2Ugd2hlbiByZXNldHRpbmcgdGhlIHNjcmFtYmxpbmcvVE1EUyBiaXQgY2xvY2sg cmF0aW8gZmFpbCBkdXJpbmcKPiA+IGRpc2FibGUuIER1cmluZyBlbmFibGUgd2UgZG8gd2FudCB0 aGUgZXJyb3IsIGFuZCBkdXJpbmcgZGlzYWJsZSB3ZSBtYXkKPiA+IHN0aWxsIHdhbnQgdG8ga25v dyB3aGF0IGhhcHBlbmRlZCBmb3IgZGVidWcgcHVycG9zZXMgc28gbGV0J3MgdXNlCj4gPiBEUk1f REVCVUdfS01TKCkgdGhlcmUuCj4gPgo+ID4gdjI6IFJlbWVtYmVyIHRoZW0gY29uc3RzCj4gPiB2 MzogR28gYmFjayB0byBqdXN0IG9uZSBmdW5jdGlvbiBhbmQgcHJpbnQgdGhlIGVycm9ycy9kZWJ1 Z3MKPiA+ICAgICAgZnJvbSBjYWxsZXJzIChTaGFzaGFuaykKPiA+Cj4gPiBDYzogU2hhc2hhbmsg U2hhcm1hIDxzaGFzaGFuay5zaGFybWFAaW50ZWwuY29tPgo+ID4gQnVnemlsbGE6IGh0dHBzOi8v YnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTY0NAo+ID4gQnVnemlsbGE6 IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTY1NQo+ID4g U2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiA+IC0tLQo+ID4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyAgfCAx OSArKysrKysrKysrKystLS0tLS0tCj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oICB8ICAyICstCj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hkbWkuYyB8IDQw ICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gICAzIGZpbGVzIGNo YW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDMyIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RkaS5jCj4gPiBpbmRleCA4YzJkNzc4NTYwZjAuLmM0NDk2MTk0MjdkYSAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gQEAgLTI0MjQsMTIgKzI0MjQsMTQg QEAgc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX2RkaV9oZG1pKHN0cnVjdCBpbnRlbF9lbmNvZGVy ICplbmNvZGVyLAo+ID4gICB7Cj4gPiAgIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPSB0b19pOTE1KGVuY29kZXItPmJhc2UuZGV2KTsKPiA+ICAgCXN0cnVjdCBpbnRlbF9kaWdp dGFsX3BvcnQgKmRpZ19wb3J0ID0gZW5jX3RvX2RpZ19wb3J0KCZlbmNvZGVyLT5iYXNlKTsKPiA+ ICsJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciA9IGNvbm5fc3RhdGUtPmNvbm5lY3Rv cjsKPiA+ICAgCWVudW0gcG9ydCBwb3J0ID0gZW5jb2Rlci0+cG9ydDsKPiA+ICAgCj4gPiAtCWlu dGVsX2hkbWlfaGFuZGxlX3Npbmtfc2NyYW1ibGluZyhlbmNvZGVyLAo+ID4gLQkJCQkJICBjb25u X3N0YXRlLT5jb25uZWN0b3IsCj4gPiAtCQkJCQkgIGNydGNfc3RhdGUtPmhkbWlfaGlnaF90bWRz X2Nsb2NrX3JhdGlvLAo+ID4gLQkJCQkJICBjcnRjX3N0YXRlLT5oZG1pX3NjcmFtYmxpbmcpOwo+ ID4gKwlpZiAoIWludGVsX2hkbWlfaGFuZGxlX3Npbmtfc2NyYW1ibGluZyhlbmNvZGVyLCBjb25u ZWN0b3IsCj4gPiArCQkJCQkgICAgICAgY3J0Y19zdGF0ZS0+aGRtaV9oaWdoX3RtZHNfY2xvY2tf cmF0aW8sCj4gPiArCQkJCQkgICAgICAgY3J0Y19zdGF0ZS0+aGRtaV9zY3JhbWJsaW5nKSkKPiA+ ICsJCURSTV9FUlJPUigiW0NPTk5FQ1RPUjolZDolc10gRmFpbGVkIHRvIGNvbmZpZ3VyZSBzaW5r IHNjcmFtYmxpbmcvVE1EUyBiaXQgY2xvY2sgcmF0aW9cbiIsCj4gPiArCQkJICBjb25uZWN0b3It PmJhc2UuaWQsIGNvbm5lY3Rvci0+bmFtZSk7Cj4gPiAgIAo+ID4gICAJLyogRGlzcGxheSBXQSAj MTE0Mzogc2tsLGtibCxjZmwgKi8KPiA+ICAgCWlmIChJU19HRU45X0JDKGRldl9wcml2KSkgewo+ ID4gQEAgLTI1MjAsMTMgKzI1MjIsMTYgQEAgc3RhdGljIHZvaWQgaW50ZWxfZGlzYWJsZV9kZGlf aGRtaShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiA+ICAgCQkJCSAgIGNvbnN0IHN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSwKPiA+ICAgCQkJCSAgIGNvbnN0 IHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpvbGRfY29ubl9zdGF0ZSkKPiA+ICAgewo+ID4g KwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yID0gb2xkX2Nvbm5fc3RhdGUtPmNvbm5l Y3RvcjsKPiA+ICsKPiA+ICAgCWlmIChvbGRfY3J0Y19zdGF0ZS0+aGFzX2F1ZGlvKQo+ID4gICAJ CWludGVsX2F1ZGlvX2NvZGVjX2Rpc2FibGUoZW5jb2RlciwKPiA+ICAgCQkJCQkgIG9sZF9jcnRj X3N0YXRlLCBvbGRfY29ubl9zdGF0ZSk7Cj4gPiAgIAo+ID4gLQlpbnRlbF9oZG1pX2hhbmRsZV9z aW5rX3NjcmFtYmxpbmcoZW5jb2RlciwKPiA+IC0JCQkJCSAgb2xkX2Nvbm5fc3RhdGUtPmNvbm5l Y3RvciwKPiA+IC0JCQkJCSAgZmFsc2UsIGZhbHNlKTsKPiA+ICsJaWYgKCFpbnRlbF9oZG1pX2hh bmRsZV9zaW5rX3NjcmFtYmxpbmcoZW5jb2RlciwgY29ubmVjdG9yLAo+ID4gKwkJCQkJICAgICAg IGZhbHNlLCBmYWxzZSkpCj4gPiArCQlEUk1fREVCVUdfS01TKCJbQ09OTkVDVE9SOiVkOiVzXSBG YWlsZWQgdG8gcmVzZXQgc2luayBzY3JhbWJsaW5nL1RNRFMgYml0IGNsb2NrIHJhdGlvXG4iLAo+ ID4gKwkJCSAgICAgIGNvbm5lY3Rvci0+YmFzZS5pZCwgY29ubmVjdG9yLT5uYW1lKTsKPiA+ICAg fQo+ID4gICAKPiA+ICAgc3RhdGljIHZvaWQgaW50ZWxfZGlzYWJsZV9kZGkoc3RydWN0IGludGVs X2VuY29kZXIgKmVuY29kZXIsCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gaW5kZXgg YTIxNWFhNzhiMGJlLi42ZTVjMGY3N2IwMzYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmgKPiA+IEBAIC0xNzgzLDcgKzE3ODMsNyBAQCBzdHJ1Y3QgaW50ZWxfaGRtaSAqZW5jX3Rv X2ludGVsX2hkbWkoc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyKTsKPiA+ICAgYm9vbCBpbnRl bF9oZG1pX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4g ICAJCQkgICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+ID4gICAJ CQkgICAgICAgc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGUpOwo+ID4gLXZv aWQgaW50ZWxfaGRtaV9oYW5kbGVfc2lua19zY3JhbWJsaW5nKHN0cnVjdCBpbnRlbF9lbmNvZGVy ICppbnRlbF9lbmNvZGVyLAo+ID4gK2Jvb2wgaW50ZWxfaGRtaV9oYW5kbGVfc2lua19zY3JhbWJs aW5nKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gICAJCQkJICAgICAgIHN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gPiAgIAkJCQkgICAgICAgYm9vbCBoaWdoX3Rt ZHNfY2xvY2tfcmF0aW8sCj4gPiAgIAkJCQkgICAgICAgYm9vbCBzY3JhbWJsaW5nKTsKPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMKPiA+IGluZGV4IDFiYWVmNGFjN2VjYi4uZWU5MjlmMzFm N2RiIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMKPiA+IEBAIC0yMDgyLDQx ICsyMDgyLDMzIEBAIGludGVsX2hkbWlfYWRkX3Byb3BlcnRpZXMoc3RydWN0IGludGVsX2hkbWkg KmludGVsX2hkbWksIHN0cnVjdCBkcm1fY29ubmVjdG9yICpjCj4gPiAgICAqIGl0IGVuYWJsZXMg c2NyYW1ibGluZy4gVGhpcyBzaG91bGQgYmUgY2FsbGVkIGJlZm9yZSBlbmFibGluZyB0aGUgSERN SQo+ID4gICAgKiAyLjAgcG9ydCwgYXMgdGhlIHNpbmsgY2FuIGNob29zZSB0byBkaXNhYmxlIHRo ZSBzY3JhbWJsaW5nIGlmIGl0IGRvZXNuJ3QKPiA+ICAgICogZGV0ZWN0IGEgc2NyYW1ibGVkIGNs b2NrIHdpdGhpbiAxMDAgbXMuCj4gPiArICoKPiA+ICsgKiBSZXR1cm5zOgo+ID4gKyAqIFRydWUg b24gc3VjY2VzcywgZmFsc2Ugb24gZmFpbHVyZS4KPiA+ICAgICovCj4gPiAtdm9pZCBpbnRlbF9o ZG1pX2hhbmRsZV9zaW5rX3NjcmFtYmxpbmcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIs Cj4gPiArYm9vbCBpbnRlbF9oZG1pX2hhbmRsZV9zaW5rX3NjcmFtYmxpbmcoc3RydWN0IGludGVs X2VuY29kZXIgKmVuY29kZXIsCj4gPiAgIAkJCQkgICAgICAgc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm5lY3RvciwKPiA+ICAgCQkJCSAgICAgICBib29sIGhpZ2hfdG1kc19jbG9ja19yYXRpbywK PiA+ICAgCQkJCSAgICAgICBib29sIHNjcmFtYmxpbmcpCj4gPiAgIHsKPiA+ICsJc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShlbmNvZGVyLT5iYXNlLmRldik7Cj4g PiAgIAlzdHJ1Y3QgaW50ZWxfaGRtaSAqaW50ZWxfaGRtaSA9IGVuY190b19pbnRlbF9oZG1pKCZl bmNvZGVyLT5iYXNlKTsKPiA+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g Y29ubmVjdG9yLT5kZXYtPmRldl9wcml2YXRlOwo+ID4gICAJc3RydWN0IGRybV9zY3JhbWJsaW5n ICpzaW5rX3NjcmFtYmxpbmcgPQo+ID4gLQkJCQkmY29ubmVjdG9yLT5kaXNwbGF5X2luZm8uaGRt aS5zY2RjLnNjcmFtYmxpbmc7Cj4gPiAtCXN0cnVjdCBpMmNfYWRhcHRlciAqYWRwdHIgPSBpbnRl bF9nbWJ1c19nZXRfYWRhcHRlcihkZXZfcHJpdiwKPiA+IC0JCQkJCQkJICAgaW50ZWxfaGRtaS0+ ZGRjX2J1cyk7Cj4gPiAtCWJvb2wgcmV0Owo+ID4gKwkJJmNvbm5lY3Rvci0+ZGlzcGxheV9pbmZv LmhkbWkuc2NkYy5zY3JhbWJsaW5nOwo+ID4gKwlzdHJ1Y3QgaTJjX2FkYXB0ZXIgKmFkYXB0ZXIg PQo+ID4gKwkJaW50ZWxfZ21idXNfZ2V0X2FkYXB0ZXIoZGV2X3ByaXYsIGludGVsX2hkbWktPmRk Y19idXMpOwo+ID4gICAKPiA+ICAgCWlmICghc2lua19zY3JhbWJsaW5nLT5zdXBwb3J0ZWQpCj4g PiAtCQlyZXR1cm47Cj4gPiAtCj4gPiAtCURSTV9ERUJVR19LTVMoIlNldHRpbmcgc2luayBzY3Jh bWJsaW5nIGZvciBlbmM6JXMgY29ubmVjdG9yOiVzXG4iLAo+ID4gLQkJICAgICAgZW5jb2Rlci0+ YmFzZS5uYW1lLCBjb25uZWN0b3ItPm5hbWUpOwo+ID4gKwkJcmV0dXJuIHRydWU7Cj4gPiAgIAo+ ID4gLQkvKiBTZXQgVE1EUyBiaXQgY2xvY2sgcmF0aW8gdG8gMS80MCBvciAxLzEwICovCj4gPiAt CXJldCA9IGRybV9zY2RjX3NldF9oaWdoX3RtZHNfY2xvY2tfcmF0aW8oYWRwdHIsIGhpZ2hfdG1k c19jbG9ja19yYXRpbyk7Cj4gPiAtCWlmICghcmV0KSB7Cj4gPiAtCQlEUk1fRVJST1IoIlNldCBU TURTIHJhdGlvIGZhaWxlZFxuIik7Cj4gPiAtCQlyZXR1cm47Cj4gPiAtCX0KPiA+IC0KPiA+IC0J LyogRW5hYmxlL2Rpc2FibGUgc2luayBzY3JhbWJsaW5nICovCj4gPiAtCXJldCA9IGRybV9zY2Rj X3NldF9zY3JhbWJsaW5nKGFkcHRyLCBzY3JhbWJsaW5nKTsKPiA+IC0JaWYgKCFyZXQpIHsKPiA+ IC0JCURSTV9FUlJPUigiU2V0IHNpbmsgc2NyYW1ibGluZyBmYWlsZWRcbiIpOwo+ID4gLQkJcmV0 dXJuOwo+ID4gLQl9Cj4gPiArCURSTV9ERUJVR19LTVMoIltDT05ORUNUT1I6JWQ6JXNdIHNjcmFt Ymxpbmc9JXMsIFRNRFMgYml0IGNsb2NrIHJhdGlvPTEvJWRcbiIsCj4gPiArCQkgICAgICBjb25u ZWN0b3ItPmJhc2UuaWQsIGNvbm5lY3Rvci0+bmFtZSwKPiA+ICsJCSAgICAgIHllc25vKHNjcmFt YmxpbmcpLCBoaWdoX3RtZHNfY2xvY2tfcmF0aW8gPyA0MCA6IDEwKTsKPiA+ICAgCj4gPiAtCURS TV9ERUJVR19LTVMoInNpbmsgc2NyYW1ibGluZyBoYW5kbGVkXG4iKTsKPiA+ICsJLyogU2V0IFRN RFMgYml0IGNsb2NrIHJhdGlvIHRvIDEvNDAgb3IgMS8xMCwgYW5kIGVuYWJsZS9kaXNhYmxlIHNj cmFtYmxpbmcgKi8KPiA+ICsJcmV0dXJuIGRybV9zY2RjX3NldF9oaWdoX3RtZHNfY2xvY2tfcmF0 aW8oYWRhcHRlciwKPiA+ICsJCQkJCQkgIGhpZ2hfdG1kc19jbG9ja19yYXRpbykgJiYKPiA+ICsJ CWRybV9zY2RjX3NldF9zY3JhbWJsaW5nKGFkYXB0ZXIsIHNjcmFtYmxpbmcpOwo+ID4gICB9Cj4g PiAgIAo+ID4gICBzdGF0aWMgdTggY2h2X3BvcnRfdG9fZGRjX3BpbihzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcG9ydCBwb3J0KQo+IAo+IExvb2tzIGdvb2QgdG8gbWUu Cj4gCj4gUmV2aWV3ZWQtYnk6IFNoYXNoYW5rIFNoYXJtYSA8c2hhc2hhbmsuc2hhcm1hQGludGVs LmNvbT4KClRoYW5rcy4gUHVzaGVkIHRvIGRpbnEuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK