From: Andrew Lunn <andrew@lunn.ch>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, f.fainelli@gmail.com,
robh+dt@kernel.org, frowand.list@gmail.com
Subject: Re: [PATCH] of_net: Implement of_get_nvmem_mac_address helper
Date: Fri, 23 Mar 2018 20:42:59 +0100 [thread overview]
Message-ID: <20180323194259.GP24361@lunn.ch> (raw)
In-Reply-To: <b68d4540-b15d-ec31-05a8-e1a4632bb5ee@topic.nl>
> Indeed. I'll add my settings as an example. Where should I put this
> documentation, in the commit comment or somewhere in
> Documents/devicetree/bindings?
Documention/devicetree/bindings/net/ethernet.txt
> It's what I intended to do, but there were two problems with that:
> - of_get_mac_address() returns a pointer to constant data in memory, but the
> nvmem functions return an allocated memory object that must be freed after
> use. This changes the way the call is to be made.
> - The nvmem functions need the "struct device" pointer as well, while
> of_get_mac_address() only gets passed the DT node.
Does of_nvmem_cell_get() help?
Andrew
next prev parent reply other threads:[~2018-03-23 19:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 14:24 [PATCH] of_net: Implement of_get_nvmem_mac_address helper Mike Looijmans
2018-03-23 15:11 ` Andrew Lunn
2018-03-23 19:20 ` Mike Looijmans
2018-03-23 19:33 ` Florian Fainelli
2018-03-24 16:17 ` Mike Looijmans
2018-03-24 18:53 ` Andrew Lunn
2018-03-25 8:17 ` Mike Looijmans
2018-03-25 21:04 ` Andrew Lunn
2018-03-26 6:54 ` Mike Looijmans
2018-03-26 6:54 ` Mike Looijmans
2018-03-23 19:42 ` Andrew Lunn [this message]
2018-03-24 16:03 ` Mike Looijmans
2018-03-26 6:41 ` [PATCH v2] " Mike Looijmans
2018-03-26 15:50 ` Andrew Lunn
2018-03-26 18:25 ` Mike Looijmans
2018-03-26 18:41 ` Andrew Lunn
2018-03-26 16:58 ` David Miller
2018-03-26 17:05 ` Florian Fainelli
2018-03-26 18:21 ` Mike Looijmans
2018-03-27 9:52 ` [PATCH v3 0/2] " Mike Looijmans
2018-03-27 9:52 ` [PATCH v3 1/2] " Mike Looijmans
2018-03-27 22:50 ` Florian Fainelli
2018-03-29 5:31 ` Mike Looijmans
2018-03-29 5:31 ` Mike Looijmans
2018-03-27 9:52 ` [PATCH v3 2/2] net: macb: Try to retrieve MAC addess from nvmem provider Mike Looijmans
2018-03-28 8:00 ` Nicolas Ferre
2018-03-28 8:00 ` Nicolas Ferre
2018-03-27 22:43 ` [PATCH v3 0/2] of_net: Implement of_get_nvmem_mac_address helper Andrew Lunn
2018-03-29 5:29 ` [PATCH v4 " Mike Looijmans
2018-03-29 5:29 ` [PATCH v4 1/2] " Mike Looijmans
2018-03-29 5:29 ` [PATCH v4 2/2] net: macb: Try to retrieve MAC addess from nvmem provider Mike Looijmans
2018-03-30 14:40 ` [PATCH v4 0/2] of_net: Implement of_get_nvmem_mac_address helper David Miller
2018-03-31 17:20 ` Mike Looijmans
2018-03-31 17:27 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323194259.GP24361@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.