All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, berrange@redhat.com, lidongchen@tencent.com,
	pl@kamp.de, peterx@redhat.com
Subject: [Qemu-devel] [PULL 2/5] migration: Fix rate limiting issue on RDMA migration
Date: Fri, 23 Mar 2018 20:23:41 +0000	[thread overview]
Message-ID: <20180323202344.70640-3-dgilbert@redhat.com> (raw)
In-Reply-To: <20180323202344.70640-1-dgilbert@redhat.com>

From: Lidong Chen <jemmy858585@gmail.com>

RDMA migration implement save_page function for QEMUFile, but
ram_control_save_page do not increase bytes_xfer. So when doing
RDMA migration, it will use whole bandwidth.

Signed-off-by: Lidong Chen <lidongchen@tencent.com>
Message-Id: <1520692378-1835-1-git-send-email-lidongchen@tencent.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 migration/qemu-file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index e85f501f86..bb63c779cc 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -253,7 +253,7 @@ size_t ram_control_save_page(QEMUFile *f, ram_addr_t block_offset,
     if (f->hooks && f->hooks->save_page) {
         int ret = f->hooks->save_page(f, f->opaque, block_offset,
                                       offset, size, bytes_sent);
-
+        f->bytes_xfer += size;
         if (ret != RAM_SAVE_CONTROL_DELAYED) {
             if (bytes_sent && *bytes_sent > 0) {
                 qemu_update_position(f, *bytes_sent);
-- 
2.14.3

  parent reply	other threads:[~2018-03-23 20:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-23 20:23 [Qemu-devel] [PULL 0/5] migration queue Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` [Qemu-devel] [PULL 1/5] migration: convert socket server to QIONetListener Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` Dr. David Alan Gilbert (git) [this message]
2018-03-23 20:23 ` [Qemu-devel] [PULL 3/5] migration/block: limit the number of parallel I/O requests Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` [Qemu-devel] [PULL 4/5] migration/block: compare only read blocks against the rate limiter Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` [Qemu-devel] [PULL 5/5] migration: Fix block migration flag case Dr. David Alan Gilbert (git)
2018-03-24 21:53 ` [Qemu-devel] [PULL 0/5] migration queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180323202344.70640-3-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=berrange@redhat.com \
    --cc=lidongchen@tencent.com \
    --cc=peterx@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.