From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/5] toolchain-configs.csv: re-organize for test-pkg
Date: Fri, 23 Mar 2018 22:07:27 +0100 [thread overview]
Message-ID: <20180323220727.5a137de4@windsurf> (raw)
In-Reply-To: <20171029173536.GG2899@scaer>
Hello,
Thanks for the review, finally getting back to this old patch series!
On Sun, 29 Oct 2017 18:35:36 +0100, Yann E. MORIN wrote:
> I would have done something else:
>
> N:path:arch
>
> where:
> - N is an integer that is the importance of the toolchain, in the
> range [0..9], with 0 the most important and 9 the least important.
>
> - path and arch as they are today.
>
> So we'd tag the toolchains between 0 and 9, and default to test those <3
> for example.
>
> Which allows us to keep the ordering of the toolchain, which is nice.
>
> But I'm also OK with your solution, just suggesting an alternative.
I don't find adding another field really necessary. After all, all we
need is to distinguish the "important" ones from the "other" ones.
> # Toolchains used by default:
Fixed.
> > +# All other toolchains
>
> # All other toolchains, not used by default:
Fixed.
> Do we want to reorder the remaining list by relevance, too, so that a
> -n12 would pick the 12 most relevant toolchains?
>
> Or are we just happy that the 7 first are ordered, and we don't care
> about the rest?
I think it will be difficult to define a "relevance order", nobody will
agree on what is the correct order for all those toolchains, and it is
not super important either. I'm not even sure my "-n" argument to
test-pkg makes a lot of sense. Really the "default" or "all" case are
what I really wanted to add.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-03-23 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 17:14 [Buildroot] [PATCH 0/5] test-pkg: by default only test a subset of toolchains Thomas Petazzoni
2017-10-29 17:14 ` [Buildroot] [PATCH 1/5] utils/genrandconfig: filter empty lines and comments in CSV file Thomas Petazzoni
2017-10-29 17:26 ` Yann E. MORIN
2017-11-27 22:24 ` Thomas Petazzoni
2017-10-29 17:14 ` [Buildroot] [PATCH 2/5] test-pkg: " Thomas Petazzoni
2017-10-29 17:27 ` Yann E. MORIN
2017-11-27 22:30 ` Thomas Petazzoni
2017-10-29 17:14 ` [Buildroot] [PATCH 3/5] toolchain-configs.csv: re-organize for test-pkg Thomas Petazzoni
2017-10-29 17:35 ` Yann E. MORIN
2018-03-23 21:07 ` Thomas Petazzoni [this message]
2017-10-29 17:14 ` [Buildroot] [PATCH 4/5] test-pkg: test a subset of toolchains by default, add -a and -n options Thomas Petazzoni
2017-10-29 17:43 ` Yann E. MORIN
2017-10-29 17:14 ` [Buildroot] [PATCH 5/5] docs/manual: update the documentation about test-pkg Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323220727.5a137de4@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.