From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 Date: Sat, 24 Mar 2018 07:25:17 -0700 Message-ID: <20180324142517.GA94954@atomide.com> References: <20180309023750.108942-1-tony@atomide.com> <20180322135553.GA27648@amd> <20180322164633.GF5799@atomide.com> <20180322192843.GA17189@amd> <20180323105455.GB21644@amd> <20180323113521.45va72bhzis6ym6m@earth.universe> <20180323201343.GC23658@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dan Williams Cc: Pavel Machek , Sebastian Reichel , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , Marcel Partap , Michael Scott , Rob Herring List-Id: linux-omap@vger.kernel.org * Dan Williams [180324 14:00]: > On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote: > > Does ofonod work for you? I could not get that one to work... > > Because it's looking for a Gobi modem but the MDM6600 isn't one and > doesn't expose that layout (and doesn't really need to anyway). I > don't think ofono has a generic QMI driver, so you'd either need to for > ce it to use the telitqmi or quectelqmi drivers, or write your own > generic QMI one. We also get five USB uarts if we add the device id with something like the patch below. I don't quite get why we get five UARTS? Also not sure if we should be using drivers/usb/serial/qcaux.c instead of qcserial.c? And from what I recall trying it out, adding the USB UARTs somehow confused ModemManager I think, that needs to be retested though :) And the USB UARTs added do not offer the same set of AT commands as the n_gsm serial mux. Regards, Tony 8< ------------------ diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial/qcserial.c @@ -181,6 +181,9 @@ static const struct usb_device_id id_table[] = { /* Huawei devices */ {DEVICE_HWI(0x03f0, 0x581d)}, /* HP lt4112 LTE/HSPA+ Gobi 4G Modem (Huawei me906e) */ + /* Motorola devices */ + {DEVICE_HWI(0x22b8, 0x2a70)}, /* Droid 4 mdm6600 */ + { } /* Terminating entry */ }; MODULE_DEVICE_TABLE(usb, id_table); -- 2.16.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 From: Tony Lindgren Message-Id: <20180324142517.GA94954@atomide.com> Date: Sat, 24 Mar 2018 07:25:17 -0700 To: Dan Williams Cc: Pavel Machek , Sebastian Reichel , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , Marcel Partap , Michael Scott , Rob Herring List-ID: KiBEYW4gV2lsbGlhbXMgPGRjYndAcmVkaGF0LmNvbT4gWzE4MDMyNCAxNDowMF06Cj4gT24gRnJp LCAyMDE4LTAzLTIzIGF0IDIxOjEzICswMTAwLCBQYXZlbCBNYWNoZWsgd3JvdGU6Cj4gPiBEb2Vz IG9mb25vZCB3b3JrIGZvciB5b3U/IEkgY291bGQgbm90IGdldCB0aGF0IG9uZSB0byB3b3JrLi4u Cj4gCj4gQmVjYXVzZSBpdCdzIGxvb2tpbmcgZm9yIGEgR29iaSBtb2RlbSBidXQgdGhlIE1ETTY2 MDAgaXNuJ3Qgb25lIGFuZAo+IGRvZXNuJ3QgZXhwb3NlIHRoYXQgbGF5b3V0IChhbmQgZG9lc24n dCByZWFsbHkgbmVlZCB0byBhbnl3YXkpLiAgSQo+IGRvbid0IHRoaW5rIG9mb25vIGhhcyBhIGdl bmVyaWMgUU1JIGRyaXZlciwgc28geW91J2QgZWl0aGVyIG5lZWQgdG8gZm9yCj4gY2UgaXQgdG8g dXNlIHRoZSB0ZWxpdHFtaSBvciBxdWVjdGVscW1pIGRyaXZlcnMsIG9yIHdyaXRlIHlvdXIgb3du Cj4gZ2VuZXJpYyBRTUkgb25lLgoKV2UgYWxzbyBnZXQgZml2ZSBVU0IgdWFydHMgaWYgd2UgYWRk IHRoZSBkZXZpY2UgaWQgd2l0aCBzb21ldGhpbmcKbGlrZSB0aGUgcGF0Y2ggYmVsb3cuIEkgZG9u J3QgcXVpdGUgZ2V0IHdoeSB3ZSBnZXQgZml2ZSBVQVJUUz8KCkFsc28gbm90IHN1cmUgaWYgd2Ug c2hvdWxkIGJlIHVzaW5nIGRyaXZlcnMvdXNiL3NlcmlhbC9xY2F1eC5jCmluc3RlYWQgb2YgcWNz ZXJpYWwuYz8KCkFuZCBmcm9tIHdoYXQgSSByZWNhbGwgdHJ5aW5nIGl0IG91dCwgYWRkaW5nIHRo ZSBVU0IgVUFSVHMKc29tZWhvdyBjb25mdXNlZCBNb2RlbU1hbmFnZXIgSSB0aGluaywgdGhhdCBu ZWVkcyB0byBiZSByZXRlc3RlZAp0aG91Z2ggOikKCkFuZCB0aGUgVVNCIFVBUlRzIGFkZGVkIGRv IG5vdCBvZmZlciB0aGUgc2FtZSBzZXQgb2YgQVQgY29tbWFuZHMKYXMgdGhlIG5fZ3NtIHNlcmlh bCBtdXguCgpSZWdhcmRzLAoKVG9ueQoKODwgLS0tLS0tLS0tLS0tLS0tLS0tCgpkaWZmIC0tZ2l0 IGEvZHJpdmVycy91c2Ivc2VyaWFsL3Fjc2VyaWFsLmMgYi9kcml2ZXJzL3VzYi9zZXJpYWwvcWNz ZXJpYWwuYwotLS0gYS9kcml2ZXJzL3VzYi9zZXJpYWwvcWNzZXJpYWwuYworKysgYi9kcml2ZXJz L3VzYi9zZXJpYWwvcWNzZXJpYWwuYwpAQCAtMTgxLDYgKzE4MSw5IEBAIHN0YXRpYyBjb25zdCBz dHJ1Y3QgdXNiX2RldmljZV9pZCBpZF90YWJsZVtdID0gewogCS8qIEh1YXdlaSBkZXZpY2VzICov CiAJe0RFVklDRV9IV0koMHgwM2YwLCAweDU4MWQpfSwJLyogSFAgbHQ0MTEyIExURS9IU1BBKyBH b2JpIDRHIE1vZGVtIChIdWF3ZWkgbWU5MDZlKSAqLwogCisJLyogTW90b3JvbGEgZGV2aWNlcyAq LworCXtERVZJQ0VfSFdJKDB4MjJiOCwgMHgyYTcwKX0sCS8qIERyb2lkIDQgbWRtNjYwMCAqLwor CiAJeyB9CQkJCS8qIFRlcm1pbmF0aW5nIGVudHJ5ICovCiB9OwogTU9EVUxFX0RFVklDRV9UQUJM RSh1c2IsIGlkX3RhYmxlKTsK