All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 3/3] setools: update to add sedta and seinfoflow
Date: Sun, 25 Mar 2018 22:44:07 +0200	[thread overview]
Message-ID: <20180325224407.75fe7c26@windsurf> (raw)
In-Reply-To: <1521578383-56128-3-git-send-email-jared.bents@rockwellcollins.com>

Hello,

On Tue, 20 Mar 2018 15:39:43 -0500, Jared Bents wrote:

> diff --git a/package/setools/Config.in b/package/setools/Config.in
> index ae0c45f..32a9315 100644
> --- a/package/setools/Config.in
> +++ b/package/setools/Config.in
> @@ -8,6 +8,7 @@ config BR2_PACKAGE_SETOOLS
>  	depends on BR2_USE_MMU
>  	select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON
>  	select BR2_PACKAGE_PYTHON_ENUM34 if !BR2_PACKAGE_PYTHON3
> +	select BR2_PACKAGE_PYTHON_NETWORKX

I've added a # runtime comment here to explain that this is only a
runtime dependency, and applied to master.

However, I'm wondering if it wouldn't have made sense to add a
sub-option for this. We generally try to avoid having too many
dependencies in Buildroot packages, and this commit adds a new
dependency that isn't strictly necessary, as long as you don't need
those two tools. I'm not saying we /must/ add such a sub-option, I'm
just asking.

I've applied nonetheless, because this can be improved later on if
needed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-03-25 20:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 20:39 [Buildroot] [PATCH v3 1/3] python-decorator: update to add host package Jared Bents
2018-03-20 20:39 ` [Buildroot] [PATCH v3 2/3] python-networkx: new package Jared Bents
2018-03-21 10:01   ` Yegor Yefremov
2018-03-25 20:42   ` Thomas Petazzoni
2018-03-20 20:39 ` [Buildroot] [PATCH v3 3/3] setools: update to add sedta and seinfoflow Jared Bents
2018-03-21 10:04   ` Yegor Yefremov
2018-03-21 13:06     ` Jared Bents
2018-03-21 13:46       ` Yegor Yefremov
2018-03-25 20:44   ` Thomas Petazzoni [this message]
2018-04-02 20:07     ` Matthew Weber
2018-03-21 10:02 ` [Buildroot] [PATCH v3 1/3] python-decorator: update to add host package Yegor Yefremov
2018-03-25 20:42 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180325224407.75fe7c26@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.