From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wine: Depend on shared libraries
Date: Sun, 25 Mar 2018 23:21:46 +0200 [thread overview]
Message-ID: <20180325232146.468ab64b@windsurf> (raw)
In-Reply-To: <20180315221629.499d56df@windsurf>
Hello Andr?,
On Thu, 15 Mar 2018 22:16:29 +0100, Thomas Petazzoni wrote:
> On Thu, 15 Mar 2018 20:45:54 +0100, Andr? Hentschel wrote:
> > Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
> > ---
> > package/wine/Config.in | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/package/wine/Config.in b/package/wine/Config.in
> > index 627a9a7..52d7d2e 100644
> > --- a/package/wine/Config.in
> > +++ b/package/wine/Config.in
> > @@ -1,5 +1,6 @@
> > config BR2_PACKAGE_WINE
> > bool "wine"
> > + depends on !BR2_STATIC_LIBS
>
> It would be good to explain in the commit log why you're adding this,
> and perhaps add a comment on top of this line to explain why we have
> this dependency.
Ping ? :-)
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-03-25 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 19:45 [Buildroot] [PATCH] wine: Depend on shared libraries André Hentschel
2018-03-15 20:24 ` Baruch Siach
2018-03-15 21:16 ` Thomas Petazzoni
2018-03-25 21:21 ` Thomas Petazzoni [this message]
2018-03-31 20:43 ` Thomas Petazzoni
2018-04-03 16:57 ` André Hentschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180325232146.468ab64b@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.