From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 1/3] i2c: update i2c_trace_msg static key to modern api Date: Mon, 26 Mar 2018 10:34:04 +0200 Message-ID: <20180326083404.GF4043@hirez.programming.kicks-ass.net> References: <20180325191056.24598-1-dave@stgolabs.net> <20180325191056.24598-2-dave@stgolabs.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180325191056.24598-2-dave@stgolabs.net> Sender: linux-kernel-owner@vger.kernel.org To: Davidlohr Bueso Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Wolfram Sang , linux-i2c@vger.kernel.org, Davidlohr Bueso List-Id: linux-i2c@vger.kernel.org On Sun, Mar 25, 2018 at 12:10:54PM -0700, Davidlohr Bueso wrote: > @@ -1848,11 +1848,11 @@ int __i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) > if (adap->quirks && i2c_check_for_quirks(adap, msgs, num)) > return -EOPNOTSUPP; > > - /* i2c_trace_msg gets enabled when tracepoint i2c_transfer gets > + /* i2c_trace_msg_key gets enabled when tracepoint i2c_transfer gets > * enabled. This is an efficient way of keeping the for-loop from > * being executed when not needed. > */ > - if (static_key_false(&i2c_trace_msg)) { > + if (static_branch_unlikely(&i2c_trace_msg_key)) { broken comment style.