From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI Date: Mon, 26 Mar 2018 14:50:19 +0200 Message-ID: <20180326125019.GA29451@kroah.com> References: <0a26f379c29d65b6e0fa416a4b73aea010b9f718.1521799705.git.Adam.Thomson.Opensource@diasemi.com> <20180326095703.GA26466@kroah.com> <2E89032DDAA8B9408CB92943514A0337014C1E2EFD@SW-EX-MBX01.diasemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2E89032DDAA8B9408CB92943514A0337014C1E2EFD@SW-EX-MBX01.diasemi.com> Sender: linux-kernel-owner@vger.kernel.org To: Adam Thomson Cc: Heikki Krogerus , Guenter Roeck , Sebastian Reichel , Hans de Goede , Jun Li , "linux-usb@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Support Opensource List-Id: linux-pm@vger.kernel.org On Mon, Mar 26, 2018 at 12:40:06PM +0000, Adam Thomson wrote: > On 26 March 2018 10:57, Greg Kroah-Hartman wrote: > > > On Fri, Mar 23, 2018 at 10:12:21AM +0000, Adam Thomson wrote: > > > This commit adds generic ABI information regarding power_supply > > > properties. This is an initial attempt to try and align the usage > > > of these properties between drivers. As part of this commit, > > > common Battery and USB related properties have been listed. > > > > > > Signed-off-by: Adam Thomson > > > --- > > > Documentation/ABI/testing/sysfs-class-power | 443 > > ++++++++++++++++++++++++++++ > > > MAINTAINERS | 1 + > > > 2 files changed, 444 insertions(+) > > > > How was this not documented before? > > As an FYI, there is some overall documentation under: > > Documentation/power/power_supply_class.txt > > However, after discussions with Heikki, it was determined something more > detailed would be useful to help clarify usage. Oh I agree, it belongs in Documentation/ABI/ like you did here, thank you so much for that. I was just amazed it wasn't already there... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v7,2/6] Documentation: power: Initial effort to document power_supply ABI From: Greg Kroah-Hartman Message-Id: <20180326125019.GA29451@kroah.com> Date: Mon, 26 Mar 2018 14:50:19 +0200 To: Adam Thomson Cc: Heikki Krogerus , Guenter Roeck , Sebastian Reichel , Hans de Goede , Jun Li , "linux-usb@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Support Opensource List-ID: T24gTW9uLCBNYXIgMjYsIDIwMTggYXQgMTI6NDA6MDZQTSArMDAwMCwgQWRhbSBUaG9tc29uIHdy b3RlOgo+IE9uIDI2IE1hcmNoIDIwMTggMTA6NTcsIEdyZWcgS3JvYWgtSGFydG1hbiB3cm90ZToK PiAKPiA+IE9uIEZyaSwgTWFyIDIzLCAyMDE4IGF0IDEwOjEyOjIxQU0gKzAwMDAsIEFkYW0gVGhv bXNvbiB3cm90ZToKPiA+ID4gVGhpcyBjb21taXQgYWRkcyBnZW5lcmljIEFCSSBpbmZvcm1hdGlv biByZWdhcmRpbmcgcG93ZXJfc3VwcGx5Cj4gPiA+IHByb3BlcnRpZXMuIFRoaXMgaXMgYW4gaW5p dGlhbCBhdHRlbXB0IHRvIHRyeSBhbmQgYWxpZ24gdGhlIHVzYWdlCj4gPiA+IG9mIHRoZXNlIHBy b3BlcnRpZXMgYmV0d2VlbiBkcml2ZXJzLiBBcyBwYXJ0IG9mIHRoaXMgY29tbWl0LAo+ID4gPiBj b21tb24gQmF0dGVyeSBhbmQgVVNCIHJlbGF0ZWQgcHJvcGVydGllcyBoYXZlIGJlZW4gbGlzdGVk Lgo+ID4gPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBBZGFtIFRob21zb24gPEFkYW0uVGhvbXNvbi5P cGVuc291cmNlQGRpYXNlbWkuY29tPgo+ID4gPiAtLS0KPiA+ID4gIERvY3VtZW50YXRpb24vQUJJ L3Rlc3Rpbmcvc3lzZnMtY2xhc3MtcG93ZXIgfCA0NDMKPiA+ICsrKysrKysrKysrKysrKysrKysr KysrKysrKysKPiA+ID4gIE1BSU5UQUlORVJTICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAgIDEgKwo+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA0NDQgaW5zZXJ0aW9ucygrKQo+ID4K PiA+IEhvdyB3YXMgdGhpcyBub3QgZG9jdW1lbnRlZCBiZWZvcmU/Cj4gCj4gQXMgYW4gRllJLCB0 aGVyZSBpcyBzb21lIG92ZXJhbGwgZG9jdW1lbnRhdGlvbiB1bmRlcjoKPiAKPiAgRG9jdW1lbnRh dGlvbi9wb3dlci9wb3dlcl9zdXBwbHlfY2xhc3MudHh0Cj4gCj4gSG93ZXZlciwgYWZ0ZXIgZGlz Y3Vzc2lvbnMgd2l0aCBIZWlra2ksIGl0IHdhcyBkZXRlcm1pbmVkIHNvbWV0aGluZyBtb3JlCj4g ZGV0YWlsZWQgd291bGQgYmUgdXNlZnVsIHRvIGhlbHAgY2xhcmlmeSB1c2FnZS4KCk9oIEkgYWdy ZWUsIGl0IGJlbG9uZ3MgaW4gRG9jdW1lbnRhdGlvbi9BQkkvIGxpa2UgeW91IGRpZCBoZXJlLCB0 aGFuawp5b3Ugc28gbXVjaCBmb3IgdGhhdC4gIEkgd2FzIGp1c3QgYW1hemVkIGl0IHdhc24ndCBh bHJlYWR5IHRoZXJlLi4uCgp0aGFua3MsCgpncmVnIGstaAotLS0KVG8gdW5zdWJzY3JpYmUgZnJv bSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhl IGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpv cmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1s Cg==