From: Omar Sandoval <osandov@osandov.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@fb.com>,
kernel-team@fb.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] loop: use interruptible lock in ioctls
Date: Mon, 26 Mar 2018 21:35:47 -0700 [thread overview]
Message-ID: <20180327043547.GA14473@vader> (raw)
In-Reply-To: <20180327000421.GC10054@bombadil.infradead.org>
On Mon, Mar 26, 2018 at 05:04:21PM -0700, Matthew Wilcox wrote:
> On Mon, Mar 26, 2018 at 04:16:26PM -0700, Omar Sandoval wrote:
> > Even after the previous patch to drop lo_ctl_mutex while calling
> > vfs_getattr(), there are other cases where we can end up sleeping for a
> > long time while holding lo_ctl_mutex. Let's avoid the uninterruptible
> > sleep from the ioctls.
>
> Umm ... you want these ioctls to return -EINTR just because you resized
> an xterm? I think you really meant mutex_lock_killable().
>
Thanks, yeah, will fix.
next prev parent reply other threads:[~2018-03-27 4:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 23:16 [PATCH 0/2] loop: don't hang on lo_ctl_mutex in ioctls Omar Sandoval
2018-03-26 23:16 ` [PATCH 1/2] loop: don't call into filesystem while holding lo_ctl_mutex Omar Sandoval
2018-03-26 23:16 ` [PATCH 2/2] loop: use interruptible lock in ioctls Omar Sandoval
2018-03-27 0:04 ` Matthew Wilcox
2018-03-27 4:35 ` Omar Sandoval [this message]
2018-03-28 13:18 ` David Sterba
2018-03-28 16:57 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327043547.GA14473@vader \
--to=osandov@osandov.com \
--cc=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.