From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:52235 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbeC0Glq (ORCPT ); Tue, 27 Mar 2018 02:41:46 -0400 Received: by mail-wm0-f66.google.com with SMTP id l9so19528321wmh.2 for ; Mon, 26 Mar 2018 23:41:46 -0700 (PDT) Date: Tue, 27 Mar 2018 08:41:42 +0200 From: Daniel Vetter To: Laurent Pinchart Cc: Daniel Vetter , Ulrich Hecht , linux-renesas-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH igt 2/8] tests/kms_panel_fitting: check for i915 before checking version Message-ID: <20180327064142.GG14155@phenom.ffwll.local> References: <1521125144-28614-1-git-send-email-ulrich.hecht+renesas@gmail.com> <4326028.gVfV6JXNhJ@avalon> <20180321083433.GB14155@phenom.ffwll.local> <5833508.5Jkp4rVBdS@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5833508.5Jkp4rVBdS@avalon> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Wed, Mar 21, 2018 at 10:52:19AM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Wednesday, 21 March 2018 10:34:33 EET Daniel Vetter wrote: > > On Tue, Mar 20, 2018 at 01:24:09PM +0200, Laurent Pinchart wrote: > > > Hi Ulrich, > > > > > > Thank you for the patch. > > > > > > On Thursday, 15 March 2018 16:45:38 EET Ulrich Hecht wrote: > > > > Fixes false negatives on non-i915 platforms. > > > > > > > > Signed-off-by: Ulrich Hecht > > > > --- > > > > > > > > tests/kms_panel_fitting.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c > > > > index b3cee22..6d0be50 100644 > > > > --- a/tests/kms_panel_fitting.c > > > > +++ b/tests/kms_panel_fitting.c > > > > @@ -243,6 +243,7 @@ static void test_atomic_fastset(igt_display_t > > > > *display) > > > > > > > > igt_set_module_param_int("fastboot", 1); > > > > > > > > igt_require(display->is_atomic); > > > > > > > > + igt_require(is_i915_device(display->drm_fd)); > > > > > > > > igt_require(intel_gen(intel_get_drm_devid(display->drm_fd)) >= 5); > > > > > > I'm fine with this patch as a quick fix, but what in this test is Intel- > > > specific ? Can't we replace the Intel generation check with a different > > > feature check ? > > > > There's some checks in there that we can do certain panel fitter mode > > changes without a modeset (throught ALLOW_MODESET for atomic commits). > > That's 100% encoding intel hw constraints: Our hw can disable the panel > > fitter without a modest (so going from upscaled -> native resolution), but > > not any of the other changes (native -> upscaled or 2 different upscaled > > versions). > > OK, thank you for the information. > > Would it make sense to rename the Intel-specific test files to start with i915 > (or any other Intel prefix) to make this clear ? We prefer to not rename test names too much, fairly disruptive to our CI. We're working on some new infrastructure which should make this easier at least. But yeah if you bring a qualition, then we can make this happen. Need to coordinate with igt maintainers on #intel-gfx (since we also need to pull in CI folks, which hang out there too). -Daniel > > > > > for_each_pipe_with_valid_output(display, pipe, output) { > > -- > Regards, > > Laurent Pinchart > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH igt 2/8] tests/kms_panel_fitting: check for i915 before checking version Date: Tue, 27 Mar 2018 08:41:42 +0200 Message-ID: <20180327064142.GG14155@phenom.ffwll.local> References: <1521125144-28614-1-git-send-email-ulrich.hecht+renesas@gmail.com> <4326028.gVfV6JXNhJ@avalon> <20180321083433.GB14155@phenom.ffwll.local> <5833508.5Jkp4rVBdS@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B99A894E0 for ; Tue, 27 Mar 2018 06:41:47 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id t7so19503233wmh.5 for ; Mon, 26 Mar 2018 23:41:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5833508.5Jkp4rVBdS@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Laurent Pinchart Cc: Ulrich Hecht , linux-renesas-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMjEsIDIwMTggYXQgMTA6NTI6MTlBTSArMDIwMCwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiBIaSBEYW5pZWwsCj4gCj4gT24gV2VkbmVzZGF5LCAyMSBNYXJjaCAyMDE4IDEw OjM0OjMzIEVFVCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gT24gVHVlLCBNYXIgMjAsIDIwMTgg YXQgMDE6MjQ6MDlQTSArMDIwMCwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+ID4gSGkgVWxy aWNoLAo+ID4gPiAKPiA+ID4gVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCj4gPiA+IAo+ID4gPiBP biBUaHVyc2RheSwgMTUgTWFyY2ggMjAxOCAxNjo0NTozOCBFRVQgVWxyaWNoIEhlY2h0IHdyb3Rl Ogo+ID4gPiA+IEZpeGVzIGZhbHNlIG5lZ2F0aXZlcyBvbiBub24taTkxNSBwbGF0Zm9ybXMuCj4g PiA+ID4gCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogVWxyaWNoIEhlY2h0IDx1bHJpY2guaGVjaHQr cmVuZXNhc0BnbWFpbC5jb20+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gCj4gPiA+ID4gIHRlc3RzL2tt c19wYW5lbF9maXR0aW5nLmMgfCAxICsKPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL3Rlc3RzL2ttc19wYW5lbF9maXR0 aW5nLmMgYi90ZXN0cy9rbXNfcGFuZWxfZml0dGluZy5jCj4gPiA+ID4gaW5kZXggYjNjZWUyMi4u NmQwYmU1MCAxMDA2NDQKPiA+ID4gPiAtLS0gYS90ZXN0cy9rbXNfcGFuZWxfZml0dGluZy5jCj4g PiA+ID4gKysrIGIvdGVzdHMva21zX3BhbmVsX2ZpdHRpbmcuYwo+ID4gPiA+IEBAIC0yNDMsNiAr MjQzLDcgQEAgc3RhdGljIHZvaWQgdGVzdF9hdG9taWNfZmFzdHNldChpZ3RfZGlzcGxheV90Cj4g PiA+ID4gKmRpc3BsYXkpCj4gPiA+ID4gCj4gPiA+ID4gIAkJaWd0X3NldF9tb2R1bGVfcGFyYW1f aW50KCJmYXN0Ym9vdCIsIDEpOwo+ID4gPiA+ICAJCj4gPiA+ID4gIAlpZ3RfcmVxdWlyZShkaXNw bGF5LT5pc19hdG9taWMpOwo+ID4gPiA+IAo+ID4gPiA+ICsJaWd0X3JlcXVpcmUoaXNfaTkxNV9k ZXZpY2UoZGlzcGxheS0+ZHJtX2ZkKSk7Cj4gPiA+ID4gCj4gPiA+ID4gIAlpZ3RfcmVxdWlyZShp bnRlbF9nZW4oaW50ZWxfZ2V0X2RybV9kZXZpZChkaXNwbGF5LT5kcm1fZmQpKSA+PSA1KTsKPiA+ ID4gCj4gPiA+IEknbSBmaW5lIHdpdGggdGhpcyBwYXRjaCBhcyBhIHF1aWNrIGZpeCwgYnV0IHdo YXQgaW4gdGhpcyB0ZXN0IGlzIEludGVsLQo+ID4gPiBzcGVjaWZpYyA/IENhbid0IHdlIHJlcGxh Y2UgdGhlIEludGVsIGdlbmVyYXRpb24gY2hlY2sgd2l0aCBhIGRpZmZlcmVudAo+ID4gPiBmZWF0 dXJlIGNoZWNrID8KPiA+IAo+ID4gVGhlcmUncyBzb21lIGNoZWNrcyBpbiB0aGVyZSB0aGF0IHdl IGNhbiBkbyBjZXJ0YWluIHBhbmVsIGZpdHRlciBtb2RlCj4gPiBjaGFuZ2VzIHdpdGhvdXQgYSBt b2Rlc2V0ICh0aHJvdWdodCBBTExPV19NT0RFU0VUIGZvciBhdG9taWMgY29tbWl0cykuCj4gPiBU aGF0J3MgMTAwJSBlbmNvZGluZyBpbnRlbCBodyBjb25zdHJhaW50czogT3VyIGh3IGNhbiBkaXNh YmxlIHRoZSBwYW5lbAo+ID4gZml0dGVyIHdpdGhvdXQgYSBtb2Rlc3QgKHNvIGdvaW5nIGZyb20g dXBzY2FsZWQgLT4gbmF0aXZlIHJlc29sdXRpb24pLCBidXQKPiA+IG5vdCBhbnkgb2YgdGhlIG90 aGVyIGNoYW5nZXMgKG5hdGl2ZSAtPiB1cHNjYWxlZCBvciAyIGRpZmZlcmVudCB1cHNjYWxlZAo+ ID4gdmVyc2lvbnMpLgo+IAo+IE9LLCB0aGFuayB5b3UgZm9yIHRoZSBpbmZvcm1hdGlvbi4KPiAK PiBXb3VsZCBpdCBtYWtlIHNlbnNlIHRvIHJlbmFtZSB0aGUgSW50ZWwtc3BlY2lmaWMgdGVzdCBm aWxlcyB0byBzdGFydCB3aXRoIGk5MTUgCj4gKG9yIGFueSBvdGhlciBJbnRlbCBwcmVmaXgpIHRv IG1ha2UgdGhpcyBjbGVhciA/CgpXZSBwcmVmZXIgdG8gbm90IHJlbmFtZSB0ZXN0IG5hbWVzIHRv byBtdWNoLCBmYWlybHkgZGlzcnVwdGl2ZSB0byBvdXIgQ0kuCldlJ3JlIHdvcmtpbmcgb24gc29t ZSBuZXcgaW5mcmFzdHJ1Y3R1cmUgd2hpY2ggc2hvdWxkIG1ha2UgdGhpcyBlYXNpZXIgYXQKbGVh c3QuCgpCdXQgeWVhaCBpZiB5b3UgYnJpbmcgYSBxdWFsaXRpb24sIHRoZW4gd2UgY2FuIG1ha2Ug dGhpcyBoYXBwZW4uIE5lZWQgdG8KY29vcmRpbmF0ZSB3aXRoIGlndCBtYWludGFpbmVycyBvbiAj aW50ZWwtZ2Z4IChzaW5jZSB3ZSBhbHNvIG5lZWQgdG8gcHVsbAppbiBDSSBmb2xrcywgd2hpY2gg aGFuZyBvdXQgdGhlcmUgdG9vKS4KLURhbmllbAoKPiAKPiA+ID4gPiAgCWZvcl9lYWNoX3BpcGVf d2l0aF92YWxpZF9vdXRwdXQoZGlzcGxheSwgcGlwZSwgb3V0cHV0KSB7Cj4gCj4gLS0gCj4gUmVn YXJkcywKPiAKPiBMYXVyZW50IFBpbmNoYXJ0Cj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2Fy ZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==