From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net ([217.70.183.199]:54747 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbeC0Hdk (ORCPT ); Tue, 27 Mar 2018 03:33:40 -0400 Date: Tue, 27 Mar 2018 09:33:32 +0200 From: jacopo mondi To: Andrzej Hajda Cc: Vladimir Zapolskiy , Jacopo Mondi , Rob Herring , Laurent Pinchart , architt@codeaurora.org, airlied@linux.ie, horms@verge.net.au, magnus.damm@gmail.com, geert@linux-m68k.org, niklas.soderlund@ragnatech.se, sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Message-ID: <20180327073332.GI27746@w540> References: <1521213399-31947-1-git-send-email-jacopo+renesas@jmondi.org> <1521213399-31947-2-git-send-email-jacopo+renesas@jmondi.org> <4060923.7DxT9ae38L@avalon> <20180326222249.tvjiutyd4amlibpa@rob-hp-laptop> <1dd27170-153c-90f6-e13f-949ba7d0d4a9@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1dd27170-153c-90f6-e13f-949ba7d0d4a9@samsung.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Andrzej, On Tue, Mar 27, 2018 at 09:12:46AM +0200, Andrzej Hajda wrote: > On 27.03.2018 08:15, Vladimir Zapolskiy wrote: > > Hi Jacopo, > > > > On 03/27/2018 01:22 AM, Rob Herring wrote: > >> On Tue, Mar 20, 2018 at 02:43:33PM +0200, Laurent Pinchart wrote: > >>> Hi Jacopo, > >>> > >>> (CC'ing Rob) > >>> > >>> Thank you for the patch. > >>> > >>> On Friday, 16 March 2018 17:16:37 EET Jacopo Mondi wrote: > >>>> Document Thine THC63LVD1024 LVDS decoder device tree bindings. > >>>> > >>>> Signed-off-by: Jacopo Mondi > >>>> Reviewed-by: Andrzej Hajda > >>>> Reviewed-by: Niklas Söderlund > >>>> --- > >>>> .../bindings/display/bridge/thine,thc63lvd1024.txt | 66 +++++++++++++++++++ > >>>> 1 file changed, 66 insertions(+) > >>>> create mode 100644 > >>>> Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > >>>> > >>>> diff --git > >>>> a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > >>>> b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > >>>> new file mode 100644 > >>>> index 0000000..8225c6a > >>>> --- /dev/null > >>>> +++ > >>>> b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > >>>> @@ -0,0 +1,66 @@ > >>>> +Thine Electronics THC63LVD1024 LVDS decoder > >>>> +------------------------------------------- > >>>> + > >>>> +The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS > >>>> streams > >>>> +to parallel data outputs. The chip supports single/dual input/output modes, > >>>> +handling up to two two input LVDS stream and up to two digital CMOS/TTL > >>>> outputs. > >>>> + > >>>> +Single or dual operation modes, output data mapping and DDR output modes > >>>> are > >>>> +configured through input signals and the chip does not expose any control > >>>> bus. > >>>> + > >>>> +Required properties: > >>>> +- compatible: Shall be "thine,thc63lvd1024" > >>>> + > >>>> +Optional properties: > >>>> +- vcc-supply: Power supply for TTL output and digital circuitry > >>>> +- cvcc-supply: Power supply for TTL CLOCKOUT signal > >>>> +- lvcc-supply: Power supply for LVDS inputs > >>>> +- pvcc-supply: Power supply for PLL circuitry > >>> As explained in a comment to one of the previous versions of this series, I'm > >>> tempted to make vcc-supply mandatory and drop the three other power supplies > >>> for now, as I believe there's very little chance they will be connected to > >>> separately controllable regulators (all supplies use the same voltage). In the > >>> very unlikely event that this occurs in design we need to support in the > >>> future, the cvcc, lvcc and pvcc supplies can be added later as optional > >>> without breaking backward compatibility. > >> I'm okay with that. > >> > >>> Apart from that, > >>> > >>> Reviewed-by: Laurent Pinchart > >>> > >>>> +- pdwn-gpios: Power down GPIO signal. Active low > >> powerdown-gpios is the semi-standard name. > >> > > right, I've also noticed it. If possible please avoid shortenings in > > property names. > > It is not shortening, it just follow pin name from decoder's datasheet. > > > > >>>> +- oe-gpios: Output enable GPIO signal. Active high > >>>> + > > And this one is also a not ever met property name, please consider to > > rename it to 'enable-gpios', for instance display panels define it. > > > Again, it follows datasheet naming scheme. Has something changed in DT > conventions? Seconded. My understanding is that the property name should reflect what reported in the the chip manual. For THC63LVD1024 the enable and power down pins are named 'OE' and 'PDWN' respectively. Thanks j > > Regards > Andrzej > > > > >>>> +The THC63LVD1024 video port connections are modeled according > >>>> +to OF graph bindings specified by > >>>> Documentation/devicetree/bindings/graph.txt > > [snip] > > > >>>> + > >>>> + port@2{ > >>>> + reg = <2>; > >>>> + > >>>> + lvds_dec_out_2: endpoint { > >>>> + remote-endpoint = <&adv7511_in>; > >>>> + }; > >>>> + > > Drop a surplus empty line above. > > > >>>> + }; > >>>> + > > Drop a surplus empty line above. > > > >>>> + }; > >>>> + }; > > -- > > With best wishes, > > Vladimir > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacopo mondi Subject: Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Date: Tue, 27 Mar 2018 09:33:32 +0200 Message-ID: <20180327073332.GI27746@w540> References: <1521213399-31947-1-git-send-email-jacopo+renesas@jmondi.org> <1521213399-31947-2-git-send-email-jacopo+renesas@jmondi.org> <4060923.7DxT9ae38L@avalon> <20180326222249.tvjiutyd4amlibpa@rob-hp-laptop> <1dd27170-153c-90f6-e13f-949ba7d0d4a9@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1dd27170-153c-90f6-e13f-949ba7d0d4a9@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda Cc: mark.rutland@arm.com, sergei.shtylyov@cogentembedded.com, devicetree@vger.kernel.org, airlied@linux.ie, magnus.damm@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, horms@verge.net.au, Jacopo Mondi , Laurent Pinchart , niklas.soderlund@ragnatech.se, geert@linux-m68k.org, Vladimir Zapolskiy List-Id: devicetree@vger.kernel.org SGkgQW5kcnplaiwKCk9uIFR1ZSwgTWFyIDI3LCAyMDE4IGF0IDA5OjEyOjQ2QU0gKzAyMDAsIEFu ZHJ6ZWogSGFqZGEgd3JvdGU6Cj4gT24gMjcuMDMuMjAxOCAwODoxNSwgVmxhZGltaXIgWmFwb2xz a2l5IHdyb3RlOgo+ID4gSGkgSmFjb3BvLAo+ID4KPiA+IE9uIDAzLzI3LzIwMTggMDE6MjIgQU0s IFJvYiBIZXJyaW5nIHdyb3RlOgo+ID4+IE9uIFR1ZSwgTWFyIDIwLCAyMDE4IGF0IDAyOjQzOjMz UE0gKzAyMDAsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPj4+IEhpIEphY29wbywKPiA+Pj4K PiA+Pj4gKENDJ2luZyBSb2IpCj4gPj4+Cj4gPj4+IFRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgo+ ID4+Pgo+ID4+PiBPbiBGcmlkYXksIDE2IE1hcmNoIDIwMTggMTc6MTY6MzcgRUVUIEphY29wbyBN b25kaSB3cm90ZToKPiA+Pj4+IERvY3VtZW50IFRoaW5lIFRIQzYzTFZEMTAyNCBMVkRTIGRlY29k ZXIgZGV2aWNlIHRyZWUgYmluZGluZ3MuCj4gPj4+Pgo+ID4+Pj4gU2lnbmVkLW9mZi1ieTogSmFj b3BvIE1vbmRpIDxqYWNvcG8rcmVuZXNhc0BqbW9uZGkub3JnPgo+ID4+Pj4gUmV2aWV3ZWQtYnk6 IEFuZHJ6ZWogSGFqZGEgPGEuaGFqZGFAc2Ftc3VuZy5jb20+Cj4gPj4+PiBSZXZpZXdlZC1ieTog TmlrbGFzIFPDtmRlcmx1bmQgPG5pa2xhcy5zb2Rlcmx1bmQrcmVuZXNhc0ByYWduYXRlY2guc2U+ Cj4gPj4+PiAtLS0KPiA+Pj4+ICAuLi4vYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvdGhpbmUsdGhj NjNsdmQxMDI0LnR4dCB8IDY2ICsrKysrKysrKysrKysrKysrKysKPiA+Pj4+ICAxIGZpbGUgY2hh bmdlZCwgNjYgaW5zZXJ0aW9ucygrKQo+ID4+Pj4gIGNyZWF0ZSBtb2RlIDEwMDY0NAo+ID4+Pj4g RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3RoaW5lLHRo YzYzbHZkMTAyNC50eHQKPiA+Pj4+Cj4gPj4+PiBkaWZmIC0tZ2l0Cj4gPj4+PiBhL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGluZSx0aGM2M2x2ZDEw MjQudHh0Cj4gPj4+PiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5 L2JyaWRnZS90aGluZSx0aGM2M2x2ZDEwMjQudHh0Cj4gPj4+PiBuZXcgZmlsZSBtb2RlIDEwMDY0 NAo+ID4+Pj4gaW5kZXggMDAwMDAwMC4uODIyNWM2YQo+ID4+Pj4gLS0tIC9kZXYvbnVsbAo+ID4+ Pj4gKysrCj4gPj4+PiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5 L2JyaWRnZS90aGluZSx0aGM2M2x2ZDEwMjQudHh0Cj4gPj4+PiBAQCAtMCwwICsxLDY2IEBACj4g Pj4+PiArVGhpbmUgRWxlY3Ryb25pY3MgVEhDNjNMVkQxMDI0IExWRFMgZGVjb2Rlcgo+ID4+Pj4g Ky0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+Pj4+ICsKPiA+ Pj4+ICtUaGUgVEhDNjNMVkQxMDI0IGlzIGEgZHVhbCBsaW5rIExWRFMgcmVjZWl2ZXIgZGVzaWdu ZWQgdG8gY29udmVydCBMVkRTCj4gPj4+PiBzdHJlYW1zCj4gPj4+PiArdG8gcGFyYWxsZWwgZGF0 YSBvdXRwdXRzLiBUaGUgY2hpcCBzdXBwb3J0cyBzaW5nbGUvZHVhbCBpbnB1dC9vdXRwdXQgbW9k ZXMsCj4gPj4+PiAraGFuZGxpbmcgdXAgdG8gdHdvIHR3byBpbnB1dCBMVkRTIHN0cmVhbSBhbmQg dXAgdG8gdHdvIGRpZ2l0YWwgQ01PUy9UVEwKPiA+Pj4+IG91dHB1dHMuCj4gPj4+PiArCj4gPj4+ PiArU2luZ2xlIG9yIGR1YWwgb3BlcmF0aW9uIG1vZGVzLCBvdXRwdXQgZGF0YSBtYXBwaW5nIGFu ZCBERFIgb3V0cHV0IG1vZGVzCj4gPj4+PiBhcmUKPiA+Pj4+ICtjb25maWd1cmVkIHRocm91Z2gg aW5wdXQgc2lnbmFscyBhbmQgdGhlIGNoaXAgZG9lcyBub3QgZXhwb3NlIGFueSBjb250cm9sCj4g Pj4+PiBidXMuCj4gPj4+PiArCj4gPj4+PiArUmVxdWlyZWQgcHJvcGVydGllczoKPiA+Pj4+ICst IGNvbXBhdGlibGU6IFNoYWxsIGJlICJ0aGluZSx0aGM2M2x2ZDEwMjQiCj4gPj4+PiArCj4gPj4+ PiArT3B0aW9uYWwgcHJvcGVydGllczoKPiA+Pj4+ICstIHZjYy1zdXBwbHk6IFBvd2VyIHN1cHBs eSBmb3IgVFRMIG91dHB1dCBhbmQgZGlnaXRhbCBjaXJjdWl0cnkKPiA+Pj4+ICstIGN2Y2Mtc3Vw cGx5OiBQb3dlciBzdXBwbHkgZm9yIFRUTCBDTE9DS09VVCBzaWduYWwKPiA+Pj4+ICstIGx2Y2Mt c3VwcGx5OiBQb3dlciBzdXBwbHkgZm9yIExWRFMgaW5wdXRzCj4gPj4+PiArLSBwdmNjLXN1cHBs eTogUG93ZXIgc3VwcGx5IGZvciBQTEwgY2lyY3VpdHJ5Cj4gPj4+IEFzIGV4cGxhaW5lZCBpbiBh IGNvbW1lbnQgdG8gb25lIG9mIHRoZSBwcmV2aW91cyB2ZXJzaW9ucyBvZiB0aGlzIHNlcmllcywg SSdtCj4gPj4+IHRlbXB0ZWQgdG8gbWFrZSB2Y2Mtc3VwcGx5IG1hbmRhdG9yeSBhbmQgZHJvcCB0 aGUgdGhyZWUgb3RoZXIgcG93ZXIgc3VwcGxpZXMKPiA+Pj4gZm9yIG5vdywgYXMgSSBiZWxpZXZl IHRoZXJlJ3MgdmVyeSBsaXR0bGUgY2hhbmNlIHRoZXkgd2lsbCBiZSBjb25uZWN0ZWQgdG8KPiA+ Pj4gc2VwYXJhdGVseSBjb250cm9sbGFibGUgcmVndWxhdG9ycyAoYWxsIHN1cHBsaWVzIHVzZSB0 aGUgc2FtZSB2b2x0YWdlKS4gSW4gdGhlCj4gPj4+IHZlcnkgdW5saWtlbHkgZXZlbnQgdGhhdCB0 aGlzIG9jY3VycyBpbiBkZXNpZ24gd2UgbmVlZCB0byBzdXBwb3J0IGluIHRoZQo+ID4+PiBmdXR1 cmUsIHRoZSBjdmNjLCBsdmNjIGFuZCBwdmNjIHN1cHBsaWVzIGNhbiBiZSBhZGRlZCBsYXRlciBh cyBvcHRpb25hbAo+ID4+PiB3aXRob3V0IGJyZWFraW5nIGJhY2t3YXJkIGNvbXBhdGliaWxpdHku Cj4gPj4gSSdtIG9rYXkgd2l0aCB0aGF0Lgo+ID4+Cj4gPj4+IEFwYXJ0IGZyb20gdGhhdCwKPiA+ Pj4KPiA+Pj4gUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRA aWRlYXNvbmJvYXJkLmNvbT4KPiA+Pj4KPiA+Pj4+ICstIHBkd24tZ3Bpb3M6IFBvd2VyIGRvd24g R1BJTyBzaWduYWwuIEFjdGl2ZSBsb3cKPiA+PiBwb3dlcmRvd24tZ3Bpb3MgaXMgdGhlIHNlbWkt c3RhbmRhcmQgbmFtZS4KPiA+Pgo+ID4gcmlnaHQsIEkndmUgYWxzbyBub3RpY2VkIGl0LiBJZiBw b3NzaWJsZSBwbGVhc2UgYXZvaWQgc2hvcnRlbmluZ3MgaW4KPiA+IHByb3BlcnR5IG5hbWVzLgo+ Cj4gSXQgaXMgbm90IHNob3J0ZW5pbmcsIGl0IGp1c3QgZm9sbG93IHBpbiBuYW1lIGZyb20gZGVj b2RlcidzIGRhdGFzaGVldC4KPgo+ID4KPiA+Pj4+ICstIG9lLWdwaW9zOiBPdXRwdXQgZW5hYmxl IEdQSU8gc2lnbmFsLiBBY3RpdmUgaGlnaAo+ID4+Pj4gKwo+ID4gQW5kIHRoaXMgb25lIGlzIGFs c28gYSBub3QgZXZlciBtZXQgcHJvcGVydHkgbmFtZSwgcGxlYXNlIGNvbnNpZGVyIHRvCj4gPiBy ZW5hbWUgaXQgdG8gJ2VuYWJsZS1ncGlvcycsIGZvciBpbnN0YW5jZSBkaXNwbGF5IHBhbmVscyBk ZWZpbmUgaXQuCj4KPgo+IEFnYWluLCBpdCBmb2xsb3dzIGRhdGFzaGVldCBuYW1pbmcgc2NoZW1l LiBIYXMgc29tZXRoaW5nIGNoYW5nZWQgaW4gRFQKPiBjb252ZW50aW9ucz8KClNlY29uZGVkLiBN eSB1bmRlcnN0YW5kaW5nIGlzIHRoYXQgdGhlIHByb3BlcnR5IG5hbWUgc2hvdWxkIHJlZmxlY3QK d2hhdCByZXBvcnRlZCBpbiB0aGUgdGhlIGNoaXAgbWFudWFsLiBGb3IgVEhDNjNMVkQxMDI0IHRo ZSBlbmFibGUgYW5kCnBvd2VyIGRvd24gcGlucyBhcmUgbmFtZWQgJ09FJyBhbmQgJ1BEV04nIHJl c3BlY3RpdmVseS4KClRoYW5rcwogICBqCgo+Cj4gUmVnYXJkcwo+IEFuZHJ6ZWoKPgo+ID4KPiA+ Pj4+ICtUaGUgVEhDNjNMVkQxMDI0IHZpZGVvIHBvcnQgY29ubmVjdGlvbnMgYXJlIG1vZGVsZWQg YWNjb3JkaW5nCj4gPj4+PiArdG8gT0YgZ3JhcGggYmluZGluZ3Mgc3BlY2lmaWVkIGJ5Cj4gPj4+ PiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZ3JhcGgudHh0Cj4gPiBbc25pcF0K PiA+Cj4gPj4+PiArCj4gPj4+PiArCQkJcG9ydEAyewo+ID4+Pj4gKwkJCQlyZWcgPSA8Mj47Cj4g Pj4+PiArCj4gPj4+PiArCQkJCWx2ZHNfZGVjX291dF8yOiBlbmRwb2ludCB7Cj4gPj4+PiArCQkJ CQlyZW1vdGUtZW5kcG9pbnQgPSA8JmFkdjc1MTFfaW4+Owo+ID4+Pj4gKwkJCQl9Owo+ID4+Pj4g Kwo+ID4gRHJvcCBhIHN1cnBsdXMgZW1wdHkgbGluZSBhYm92ZS4KPiA+Cj4gPj4+PiArCQkJfTsK PiA+Pj4+ICsKPiA+IERyb3AgYSBzdXJwbHVzIGVtcHR5IGxpbmUgYWJvdmUuCj4gPgo+ID4+Pj4g KwkJfTsKPiA+Pj4+ICsJfTsKPiA+IC0tCj4gPiBXaXRoIGJlc3Qgd2lzaGVzLAo+ID4gVmxhZGlt aXIKPiA+Cj4gPgo+ID4KPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK