Re: [Qemu-devel] [PATCH 0/5] dma/i82374: avoid double creation of i82374 device

[Eduardo Otubo <otubo@redhat.com>]

On 26/03/2018 - 12:34:36, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> This series intend to fix: https://bugs.launchpad.net/qemu/+bug/1721224
> 
> Patch #1 is the fix for 2.12, following patches are just refactors for 2.13.
> 
> The 8257 only has 4 DMA channels. To have 8 channels, the IBM PC/AT
> implementation uses 2x 8257, the second cascaded onto the first.
> The i8257_dma_init() name is misleading since this function creates two
> 8257 to register a total of 8 channels on the ISA bus.
> 
> The refactor is to enforce that 2 controllers are used (cascaded) - no
> logical change.
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (5):
>   hw/dma/i82374: Avoid double creation of the 82374 controller
>   hw/dma/i8257: Define I8257_CHANNEL_COUNT
>   hw/dma/i8257: Split i8257_dma_init() by master/slave
>   hw/dma/i8257: Rename i8257_dma_init() -> i8257_dma_init_cascaded()
>   hw/dma/i8257: Rename i8257_dma_init(false) -> i8257_dma_init_pc_at()
> 
>  include/hw/dma/i8257.h  | 23 +++++++++++++++++++++--
>  hw/dma/i82374.c         |  9 ++++++++-
>  hw/dma/i8257.c          | 38 ++++++++++++++++++++++++++++----------
>  hw/i386/pc.c            |  2 +-
>  hw/mips/mips_fulong2e.c |  2 +-
>  hw/mips/mips_jazz.c     |  2 +-
>  hw/mips/mips_malta.c    |  2 +-
>  7 files changed, 61 insertions(+), 17 deletions(-)
> 
> -- 
> 2.16.3
> 
> 
Reviewed-by: Eduardo Otubo <otubo@redhat.com>

-- 
Eduardo Otubo