From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 8/8] drm/arm/malidp: Added the late system pm functions Date: Tue, 27 Mar 2018 10:29:03 +0200 Message-ID: <20180327082903.GS14155@phenom.ffwll.local> References: <1522083800-30100-1-git-send-email-ayan.halder@arm.com> <1522083800-30100-9-git-send-email-ayan.halder@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A4C26E59E for ; Tue, 27 Mar 2018 08:29:07 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id r131so13209614wmb.2 for ; Tue, 27 Mar 2018 01:29:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1522083800-30100-9-git-send-email-ayan.halder@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ayan Kumar Halder Cc: airlied@linux.ie, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, malidp@foss.arm.com, nd@arm.com List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBNYXIgMjYsIDIwMTggYXQgMDY6MDM6MjBQTSArMDEwMCwgQXlhbiBLdW1hciBIYWxk ZXIgd3JvdGU6Cj4gbWFsaWRwX3BtX3N1c3BlbmRfbGF0ZSBjaGVja3MgaWYgdGhlIHJ1bnRpbWUg c3RhdHVzIGlzIG5vdCBzdXNwZW5kZWQKPiBhbmQgaWYgc28sIGludm9rZXMgbWFsaWRwX3J1bnRp bWVfcG1fc3VzcGVuZCB3aGljaCBkaXNhYmxlcyB0aGUKPiBkaXNwbGF5IGVuZ2luZS9jb3JlIGlu dGVycnVwdHMgYW5kIHRoZSBjbG9ja3MuIEl0IHNldHMgdGhlIHJ1bnRpbWUgc3RhdHVzCj4gYXMg c3VzcGVuZGVkLiBTdWJzZXF1ZW50bHksIG1hbGlkcF9wbV9yZXN1bWVfZWFybHkgd2lsbCBpbnZv a2UKPiBtYWxpZHBfcnVudGltZV9wbV9yZXN1bWUgd2hpY2ggZW5hYmxlcyB0aGUgY2xvY2tzIGFu ZCB0aGUgaW50ZXJydXB0cwo+IChwcmV2aW91c2x5IGRpc2FibGVkKSBhbmQgc2V0cyB0aGUgcnVu dGltZSBzdGF0dXMgYXMgYWN0aXZlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEF5YW4gS3VtYXIgSGFs ZGVyIDxheWFuLmhhbGRlckBhcm0uY29tPgo+IENoYW5nZS1JZDogSTVmOGMzZDI4ZjA3NjMxNGEx YzlkYTJhNDY3NjBhOWMzNzAzOWNjZGEKCldoeSBleGFjdGx5IGRvIHlvdSBuZWVkIGxhdGUvZWFy bHkgaG9va3M/IElmIHlvdSBoYXZlIGRlcGVuZGVuY2llcyB3aXRoCm90aGVyIGRldmljZXMsIHBs cyBjb25zaWRlciBhZGRpbmcgZGV2aWNlX2xpbmtzIGluc3RlYWQuIFRoaXMgaGVyZQpzaG91bGRu J3QgYmUgbmVjZXNzYXJ5LgotRGFuaWVsCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hcm0vbWFs aWRwX2Rydi5jIHwgMTcgKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDE3IGlu c2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBf ZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYwo+IGluZGV4IGJkNDRhNmQu LmY2MTI0ZDggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfZHJ2LmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYwo+IEBAIC03NjYsOCArNzY2 LDI1IEBAIHN0YXRpYyBpbnQgX19tYXliZV91bnVzZWQgbWFsaWRwX3BtX3Jlc3VtZShzdHJ1Y3Qg ZGV2aWNlICpkZXYpCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiArc3RhdGljIGludCBfX21heWJl X3VudXNlZCBtYWxpZHBfcG1fc3VzcGVuZF9sYXRlKHN0cnVjdCBkZXZpY2UgKmRldikKPiArewo+ ICsJaWYgKCFwbV9ydW50aW1lX3N0YXR1c19zdXNwZW5kZWQoZGV2KSkgewo+ICsJCW1hbGlkcF9y dW50aW1lX3BtX3N1c3BlbmQoZGV2KTsKPiArCQlwbV9ydW50aW1lX3NldF9zdXNwZW5kZWQoZGV2 KTsKPiArCX0KPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IF9fbWF5YmVfdW51 c2VkIG1hbGlkcF9wbV9yZXN1bWVfZWFybHkoc3RydWN0IGRldmljZSAqZGV2KQo+ICt7Cj4gKwlt YWxpZHBfcnVudGltZV9wbV9yZXN1bWUoZGV2KTsKPiArCXBtX3J1bnRpbWVfc2V0X2FjdGl2ZShk ZXYpOwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZGV2X3Bt X29wcyBtYWxpZHBfcG1fb3BzID0gewo+ICAJU0VUX1NZU1RFTV9TTEVFUF9QTV9PUFMobWFsaWRw X3BtX3N1c3BlbmQsIG1hbGlkcF9wbV9yZXN1bWUpIFwKPiArCVNFVF9MQVRFX1NZU1RFTV9TTEVF UF9QTV9PUFMobWFsaWRwX3BtX3N1c3BlbmRfbGF0ZSwgbWFsaWRwX3BtX3Jlc3VtZV9lYXJseSkg XAo+ICAJU0VUX1JVTlRJTUVfUE1fT1BTKG1hbGlkcF9ydW50aW1lX3BtX3N1c3BlbmQsIG1hbGlk cF9ydW50aW1lX3BtX3Jlc3VtZSwgTlVMTCkKPiAgfTsKPiAgCj4gLS0gCj4gMi43LjQKPiAKPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8v YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751859AbeC0I3J (ORCPT ); Tue, 27 Mar 2018 04:29:09 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35723 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbeC0I3H (ORCPT ); Tue, 27 Mar 2018 04:29:07 -0400 X-Google-Smtp-Source: AG47ELvJ/whqo0GQo+2hbh32CufyTAEnSdNf9QddGSG0PALXQ0vYfvVfMAu3VcQS53EJpa7cy/3tWQ== Date: Tue, 27 Mar 2018 10:29:03 +0200 From: Daniel Vetter To: Ayan Kumar Halder Cc: liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nd@arm.com Subject: Re: [PATCH 8/8] drm/arm/malidp: Added the late system pm functions Message-ID: <20180327082903.GS14155@phenom.ffwll.local> Mail-Followup-To: Ayan Kumar Halder , liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nd@arm.com References: <1522083800-30100-1-git-send-email-ayan.halder@arm.com> <1522083800-30100-9-git-send-email-ayan.halder@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522083800-30100-9-git-send-email-ayan.halder@arm.com> X-Operating-System: Linux phenom 4.15.0-1-amd64 User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 26, 2018 at 06:03:20PM +0100, Ayan Kumar Halder wrote: > malidp_pm_suspend_late checks if the runtime status is not suspended > and if so, invokes malidp_runtime_pm_suspend which disables the > display engine/core interrupts and the clocks. It sets the runtime status > as suspended. Subsequently, malidp_pm_resume_early will invoke > malidp_runtime_pm_resume which enables the clocks and the interrupts > (previously disabled) and sets the runtime status as active. > > Signed-off-by: Ayan Kumar Halder > Change-Id: I5f8c3d28f076314a1c9da2a46760a9c37039ccda Why exactly do you need late/early hooks? If you have dependencies with other devices, pls consider adding device_links instead. This here shouldn't be necessary. -Daniel > --- > drivers/gpu/drm/arm/malidp_drv.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > index bd44a6d..f6124d8 100644 > --- a/drivers/gpu/drm/arm/malidp_drv.c > +++ b/drivers/gpu/drm/arm/malidp_drv.c > @@ -766,8 +766,25 @@ static int __maybe_unused malidp_pm_resume(struct device *dev) > return 0; > } > > +static int __maybe_unused malidp_pm_suspend_late(struct device *dev) > +{ > + if (!pm_runtime_status_suspended(dev)) { > + malidp_runtime_pm_suspend(dev); > + pm_runtime_set_suspended(dev); > + } > + return 0; > +} > + > +static int __maybe_unused malidp_pm_resume_early(struct device *dev) > +{ > + malidp_runtime_pm_resume(dev); > + pm_runtime_set_active(dev); > + return 0; > +} > + > static const struct dev_pm_ops malidp_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(malidp_pm_suspend, malidp_pm_resume) \ > + SET_LATE_SYSTEM_SLEEP_PM_OPS(malidp_pm_suspend_late, malidp_pm_resume_early) \ > SET_RUNTIME_PM_OPS(malidp_runtime_pm_suspend, malidp_runtime_pm_resume, NULL) > }; > > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch