From: Stephen Hemminger <stephen@networkplumber.org>
To: Roman Mashak <mrv@mojatatu.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH v3 iproute2 1/1] tc: fix conversion types when printing actions unsigned values
Date: Tue, 27 Mar 2018 14:56:59 -0700 [thread overview]
Message-ID: <20180327145659.26fbce4a@xeon-e3> (raw)
In-Reply-To: <85tvt1i4q6.fsf@mojatatu.com>
On Tue, 27 Mar 2018 17:33:05 -0400
Roman Mashak <mrv@mojatatu.com> wrote:
> Stephen Hemminger <stephen@networkplumber.org> writes:
>
> > On Mon, 19 Mar 2018 17:05:41 -0400
> > Roman Mashak <mrv@mojatatu.com> wrote:
> >
> >> diff --git a/tc/m_gact.c b/tc/m_gact.c
> >> index 16c4413f4217..52022415db48 100644
> >> --- a/tc/m_gact.c
> >> +++ b/tc/m_gact.c
> >> @@ -194,7 +194,7 @@ print_gact(struct action_util *au, FILE *f, struct rtattr *arg)
> >> print_string(PRINT_ANY, "random_type", "\n\t random type %s",
> >> prob_n2a(pp->ptype));
> >> print_action_control(f, " ", pp->paction, " ");
> >> - print_int(PRINT_ANY, "val", "val %d", pp->pval);
> >> + print_int(PRINT_ANY, "val", "val %u", pp->pval);
> >> close_json_object();
> >
> > This needs to be print_uint in order to work correctly with json output.
> >
> > Also, please consider doing json on all the match types in a later patch
> > for net-next.
>
> Did you mean iproute2-next?
yes. iproute2-next for the JSON changes
prev parent reply other threads:[~2018-03-27 21:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 21:05 [PATCH v3 iproute2 1/1] tc: fix conversion types when printing actions unsigned values Roman Mashak
2018-03-27 16:02 ` Stephen Hemminger
2018-03-27 21:33 ` Roman Mashak
2018-03-27 21:56 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327145659.26fbce4a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.