From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Kim Phillips <kim.phillips@arm.com>
Cc: Andi Kleen <ak@linux.intel.com>,
Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Jin Yao <yao.jin@linux.intel.com>,
Milian Wolff <milian.wolff@kdab.com>
Subject: Re: [PATCH] perf tools: Add a dso_size option to perf report --sort
Date: Tue, 27 Mar 2018 12:45:07 -0300 [thread overview]
Message-ID: <20180327154507.GB3043@kernel.org> (raw)
In-Reply-To: <20180327090507.622cba7cac16a7e812170067@arm.com>
Em Tue, Mar 27, 2018 at 09:05:07AM -0500, Kim Phillips escreveu:
> On Tue, 27 Mar 2018 04:27:02 -0700
> Andi Kleen <ak@linux.intel.com> wrote:
>
> > On Tue, Mar 27, 2018 at 06:09:56AM -0500, Kim Phillips wrote:
> > > Add DSO size to perf report/top sort output list.
> > >
> > > This includes adding a map__size fn to map.h, which is
> > > approximately equal to the DSO data file_size:
> >
> > What's the point of knowing the size?
> I think it's just an extra convenience over symbol_size (added in
> commit 7768f8dada66d6 "perf tools: Allow sorting by symbol size") for
> tools developers' aggregation statistics.
Yeah, for completeness, may be useful for someone, probably for Maxim?
:-)
> > Most of the DSO may not be faulted in. If anything the working
> > set would be more interesting. This would need more changes
> > though.
>
> Indeed. Maxim?
Right, that would be another interesting metric to have,
- Arnaldo
next prev parent reply other threads:[~2018-03-27 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 11:09 [PATCH] perf tools: Add a dso_size option to perf report --sort Kim Phillips
2018-03-27 11:27 ` Andi Kleen
2018-03-27 14:05 ` Kim Phillips
2018-03-27 14:05 ` Kim Phillips
2018-03-27 15:45 ` Arnaldo Carvalho de Melo [this message]
2018-04-04 5:28 ` [tip:perf/urgent] perf tools: Add a "dso_size" sort order tip-bot for Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327154507.GB3043@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maxim.kuvyrkov@linaro.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.