From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [V3 1/2] dropbear: bump to version 2018.76
Date: Wed, 28 Mar 2018 10:01:49 +0200 [thread overview]
Message-ID: <20180328100149.1d0a05b8@windsurf> (raw)
In-Reply-To: <CAB0FRsstPgEOQCPJgCWn91y-PB3umhgpX9vn0qof5J-knPPkXQ@mail.gmail.com>
Hello,
On Wed, 28 Mar 2018 09:57:57 +0200, Fran?ois Perrad wrote:
> > Could you have a look ?
>
> The presence of crypt() is detected by the configure script.
So, if it's detected by the configure script, there should be no
problem, no ?
> in dropbear-2017-75/options.h, the logic was :
> /* This requires crypt() */
> #ifdef HAVE_CRYPT
> #define ENABLE_SVR_PASSWORD_AUTH
> #endif
>
> in dropbear-2018-76/sysoptions.h, the logic is now :
> #if DROPBEAR_SVR_PASSWORD_AUTH && !HAVE_CRYPT
> #error "DROPBEAR_SVR_PASSWORD_AUTH requires `crypt()'."
> #endif
>
> So, without something like BR2_TOOLCHAIN_HAS_CRYPT,
> we must always disable the option DROPBEAR_SVR_PASSWORD_AUTH in
> localoptions.h.
I don't understand. On one hand, you say that the presence of crypt()
is detected by the configure script, and on the other hand, you say
that we must tell Dropbear explicitly whether crypt() is available or
not.
Could you clarify ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-03-28 8:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:03 [Buildroot] [V3 1/2] dropbear: bump to version 2018.76 Francois Perrad
2018-03-21 16:03 ` [Buildroot] [V3 2/2] dropbear: unbundle libtomath & libtomcrypt Francois Perrad
2018-03-21 17:04 ` Baruch Siach
2018-03-21 20:13 ` Thomas Petazzoni
2018-03-21 20:16 ` Baruch Siach
2018-03-21 20:22 ` Thomas Petazzoni
2018-03-22 5:36 ` Baruch Siach
2018-03-23 4:15 ` François Perrad
2018-03-23 6:16 ` Baruch Siach
2018-03-26 20:18 ` [Buildroot] [V3 1/2] dropbear: bump to version 2018.76 Thomas Petazzoni
2018-03-28 7:57 ` François Perrad
2018-03-28 8:01 ` Thomas Petazzoni [this message]
2018-03-28 8:42 ` François Perrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328100149.1d0a05b8@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.