From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/3] EDAC/amd64: Print ECC enabled/disabled for nodes with enabled MCs From: Borislav Petkov Message-Id: <20180328154349.GD20533@pd.tnic> Date: Wed, 28 Mar 2018 17:43:49 +0200 To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gV2VkLCBNYXIgMjgsIDIwMTggYXQgMDI6Mzg6MTFQTSArMDAwMCwgR2hhbm5hbSwgWWF6ZW4g d3JvdGU6Cj4gSW4gZWl0aGVyIG9mIHRob3NlIGNhc2VzIHdlIHdvbid0IGdldCB0byBkZWJ1Z19k aXNwbGF5X2RpbW1fc2l6ZXMqCj4gYmVjYXVzZSB3ZSB3b24ndCBpbml0aWFsaXplIHRoZSBpbnN0 YW5jZS4KClNvIHlvdSBtb3ZlIHRoYXQgY29kZSB3aGljaCBhY2Nlc3NlcyBjc3Jvd3MgdXAgc28g dGhhdCBpdCBoYXMgdGhlCnJlcXVpcmVkIGluZm9ybWF0aW9uIHRvIHF1ZXJ5IERJTU0gc3RhdGUv cHJlc2VuY2UuCgo+ICAgICAgICAgICAgICAgICAvKiBBc3N1bWUgVU1DIE1DQSBiYW5rcyBhcmUg ZW5hYmxlZC4gKi8KPiAgICAgICAgICAgICAgICAgbmJfbWNlX2VuID0gdHJ1ZTsKCkFsc28sIEkg ZG9uJ3QgbGlrZSB0aGF0IGFzc3VtcHRpb24uCgo+IFRoaXMgd291bGQgd29yayBmb3IgRmFtMTdo LiBGb3Igb2xkZXIgc3lzdGVtcyBJIHRoaW5rIHdlIGNhbiBsb29rIGF0Cj4gRDE4RjJ4OTRfZGN0 WzE6MF1bRGlzRHJhbUludGVyZmFjZV0KPiAKPiBPciBtYXliZSB3ZSBoYXZlIGEgc2VwYXJhdGUg ZnVuY3Rpb24gdG8gY2hlY2sgZm9yIGVuYWJsZWQgbWVtb3J5IGNvbnRyb2xsZXJzCj4gYmVmb3Jl IHdlIGNoZWNrIGZvciBFQ0M/CgpUaGUgYmVzdCB3b3VsZCBiZSB0byBoYXZlIGEgZnVuY3Rpb24g d2hpY2ggY2hlY2tzIHdoZXRoZXIgRElNTXMgYXJlCnByZXNlbnQgb24gdGhlIG5vZGUgYW5kIGFj dCBhY2NvcmRpbmdseS4gWW91IGNhbiBwdWxsIHVwIHNvbWUgb2YgdGhlCndvcmsgb2YgY2FjaGlu ZyByZWdpc3RlcnMgd2hpY2ggYXJlIHVzZWQgaW4gZGVidWdfZGlzcGxheV9kaW1tX3NpemVzKgph bmQgdXNlIHRoYXQgaW5mbyB0byBnZXQgdGhlIHJlcXVpcmVkIERJTU0gc3RhdGUgdXBmcm9udC4K ClRoeC4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754136AbeC1Por (ORCPT ); Wed, 28 Mar 2018 11:44:47 -0400 Received: from mail.skyhub.de ([5.9.137.197]:55492 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753970AbeC1Poq (ORCPT ); Wed, 28 Mar 2018 11:44:46 -0400 Date: Wed, 28 Mar 2018 17:43:49 +0200 From: Borislav Petkov To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] EDAC/amd64: Print ECC enabled/disabled for nodes with enabled MCs Message-ID: <20180328154349.GD20533@pd.tnic> References: <20180321191335.7832-1-Yazen.Ghannam@amd.com> <20180328130028.GB20533@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 28, 2018 at 02:38:11PM +0000, Ghannam, Yazen wrote: > In either of those cases we won't get to debug_display_dimm_sizes* > because we won't initialize the instance. So you move that code which accesses csrows up so that it has the required information to query DIMM state/presence. > /* Assume UMC MCA banks are enabled. */ > nb_mce_en = true; Also, I don't like that assumption. > This would work for Fam17h. For older systems I think we can look at > D18F2x94_dct[1:0][DisDramInterface] > > Or maybe we have a separate function to check for enabled memory controllers > before we check for ECC? The best would be to have a function which checks whether DIMMs are present on the node and act accordingly. You can pull up some of the work of caching registers which are used in debug_display_dimm_sizes* and use that info to get the required DIMM state upfront. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.