From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Jiri Olsa <jolsa@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 1/8] perf build: Fix check-headers.sh opts assignment
Date: Wed, 28 Mar 2018 15:49:12 -0300 [thread overview]
Message-ID: <20180328184919.32287-2-acme@kernel.org> (raw)
In-Reply-To: <20180328184919.32287-1-acme@kernel.org>
From: Jiri Olsa <jolsa@kernel.org>
Currently the "opts" variable is not zero-ed and we keep on adding to
it, ending up with:
$ check-headers.sh 2>&1
+ opts=' "-B"'
+ opts=' "-B" "-B"'
+ opts=' "-B" "-B" "-B"'
+ opts=' "-B" "-B" "-B" "-B"'
+ opts=' "-B" "-B" "-B" "-B" "-B"'
+ opts=' "-B" "-B" "-B" "-B" "-B" "-B"'
Fix this by initializing it in the check() function, right before
starting the loop.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180321140515.2252-1-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
| 1 +
1 file changed, 1 insertion(+)
--git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
index bf206ffe5c45..9aff89bc7535 100755
--- a/tools/perf/check-headers.sh
+++ b/tools/perf/check-headers.sh
@@ -59,6 +59,7 @@ check () {
file=$1
shift
+ opts=
while [ -n "$*" ]; do
opts="$opts \"$1\""
shift
--
2.14.3
next prev parent reply other threads:[~2018-03-28 18:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 18:49 [GIT PULL 0/8] perf/core improvements and fixes Arnaldo Carvalho de Melo
2018-03-28 18:49 ` Arnaldo Carvalho de Melo [this message]
2018-03-28 18:49 ` [PATCH 2/8] perf mmap: Fix accessing unmapped mmap in perf_mmap__read_done() Arnaldo Carvalho de Melo
2018-03-28 18:49 ` [PATCH 3/8] perf mmap: Be consistent when checking for an unmaped ring buffer Arnaldo Carvalho de Melo
2018-03-28 18:49 ` [PATCH 4/8] perf vendor events s390: Add JSON files for IBM z10EC z10BC Arnaldo Carvalho de Melo
2018-03-28 18:49 ` [PATCH 5/8] perf vendor events s390: Add JSON files for IBM z196 Arnaldo Carvalho de Melo
2018-03-28 18:49 ` [PATCH 6/8] perf vendor events s390: Add JSON files for IBM zEC12 zBC12 Arnaldo Carvalho de Melo
2018-03-28 18:49 ` [PATCH 7/8] perf vendor events s390: Add JSON files for IBM z13 Arnaldo Carvalho de Melo
2018-03-28 18:49 ` [PATCH 8/8] perf vendor events s390: Add JSON files for IBM z14 Arnaldo Carvalho de Melo
2018-03-29 7:23 ` [GIT PULL 0/8] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328184919.32287-2-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.