From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: Make VTU miss violations less spammy Date: Wed, 28 Mar 2018 21:34:11 +0200 Message-ID: <20180328193411.GC20749@lunn.ch> References: <1522187980-23072-1-git-send-email-andrew@lunn.ch> <1522187980-23072-3-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , netdev To: Florian Fainelli Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:45653 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752858AbeC1TeO (ORCPT ); Wed, 28 Mar 2018 15:34:14 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Mar 28, 2018 at 11:11:07AM -0700, Florian Fainelli wrote: > On 03/27/2018 02:59 PM, Andrew Lunn wrote: > > VTU miss violations can happen under normal conditions. Don't spam the > > kernel log. The statistics counter will indicate it is happening, if > > anybody is interested. > > > > Signed-off-by: Andrew Lunn > > Reported-by: Florian Fainelli > > > --- > > drivers/net/dsa/mv88e6xxx/global1_vtu.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/dsa/mv88e6xxx/global1_vtu.c b/drivers/net/dsa/mv88e6xxx/global1_vtu.c > > index 2cbaf946e7ed..e0f1b4f6e29f 100644 > > --- a/drivers/net/dsa/mv88e6xxx/global1_vtu.c > > +++ b/drivers/net/dsa/mv88e6xxx/global1_vtu.c > > @@ -547,11 +547,9 @@ static irqreturn_t mv88e6xxx_g1_vtu_prob_irq_thread_fn(int irq, void *dev_id) > > chip->ports[spid].vtu_member_violation++; > > } > > > > - if (val & MV88E6XXX_G1_VTU_OP_MISS_VIOLATION) { > > - dev_err_ratelimited(chip->dev, "VTU miss violation for vid %d, source port %d\n", > > - entry.vid, spid); > > Why not keep it as a dev_dbg() message? O.K, will do. Andrew