From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Andrew Morton <akpm@linuxfoundation.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: [patch 0/8] rslib: Cleanup and VLA removal
Date: Wed, 28 Mar 2018 22:51:38 +0200 [thread overview]
Message-ID: <20180328205138.301218351@linutronix.de> (raw)
Kees tried to get rid of the Variable Length Arrays in the Reed-Solomon
library by replacing them with fixed length arrays on stack. Though they
are rather large and Andrew did not fall in love with that solution.
This series addresses that in a different way by splitting the rs control
structure up, so that each invocation of rs_init() returns a new instance
in which the decoder buffers are allocated. The polynom tables which build
the base for the RS codecs are still shareable between the instances to
avoid large allocations and initializations of the same data over and over.
The usage sites have been audited and fixed up where necessary to
accomodate the decoder change which forbids parallel decoder invocation for
a particular rs control instance to prevent buffer corruption.
While at it the patch set tidies up the code and converts the related files
over to use SPDX license identifiers.
Thanks,
tglx
8<---------------
drivers/md/dm-verity-fec.c | 7 +
drivers/mtd/nand/cafe_nand.c | 7 -
drivers/mtd/nand/diskonchip.c | 72 ++++++--------
include/linux/rslib.h | 46 ++++-----
lib/reed_solomon/decode_rs.c | 34 +++---
lib/reed_solomon/encode_rs.c | 15 --
lib/reed_solomon/reed_solomon.c | 203 +++++++++++++++++++++++-----------------
7 files changed, 209 insertions(+), 175 deletions(-)
next reply other threads:[~2018-03-28 20:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 20:51 Thomas Gleixner [this message]
2018-03-28 20:51 ` [patch 1/8] rslib: Cleanup whitespace damage Thomas Gleixner
2018-03-28 20:51 ` [patch 2/8] rslib: Cleanup top level comments Thomas Gleixner
2018-03-28 20:51 ` [patch 3/8] rslib: Add SPDX identifiers Thomas Gleixner
2018-03-28 21:59 ` Segher Boessenkool
2018-03-28 20:51 ` [patch 4/8] rslib: Remove GPL boilerplate Thomas Gleixner
2018-03-28 20:51 ` [patch 5/8] rslib: Split rs control struct Thomas Gleixner
2018-04-04 19:40 ` Boris Brezillon
2018-04-18 17:03 ` Kees Cook
2018-04-19 8:16 ` Thomas Gleixner
2018-03-28 20:51 ` [patch 6/8] mtd: diskonchip: Allocate rs control per instance Thomas Gleixner
2018-04-04 19:52 ` Boris Brezillon
2018-03-28 20:51 ` [patch 7/8] dm verity fec: Check result of init_rs() Thomas Gleixner
2018-03-28 20:51 ` [patch 8/8] rslib: Allocate decoder buffers to avoid VLAs Thomas Gleixner
2018-03-28 21:14 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328205138.301218351@linutronix.de \
--to=tglx@linutronix.de \
--cc=agk@redhat.com \
--cc=akpm@linuxfoundation.org \
--cc=anton@enomsg.org \
--cc=boris.brezillon@free-electrons.com \
--cc=ccross@android.com \
--cc=dwmw2@infradead.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=segher@kernel.crashing.org \
--cc=snitzer@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.