From: Rodrigo Rivas Costa <rodrigorivascosta@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Pierre-Loup A. Griffais" <pgriffais@valvesoftware.com>,
"Clément VUCHENER" <clement.vuchener@gmail.com>,
"Jiri Kosina" <jikos@kernel.org>,
"Cameron Gutman" <aicommander@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH v7 0/2] hid-steam driver with user mode client dection
Date: Wed, 28 Mar 2018 23:44:38 +0200 [thread overview]
Message-ID: <20180328214438.GA5740@casa> (raw)
In-Reply-To: <20180328181448.GA1674@casa>
On Wed, Mar 28, 2018 at 08:14:48PM +0200, Rodrigo Rivas Costa wrote:
> On Mon, Mar 26, 2018 at 10:12:19AM +0200, Benjamin Tissoires wrote:
> > Also, I think there will be races if a user changes the value of the
> > parameter while running the system. You might want to add an
> > additional patch that would trigger the mode change on module
> > parameter change.
>
> True, but the races should be easy to remove, with a simple local
> variable. About the trigger, I've never seen a trigger on module
> parameter change. Can you give me a hint or example of how to do that?
Never mind, I've found it: module_param_cb().
Moreover, I'll have to keep a global list of steam_devices, just in case
the parameter is changed...
Regards.
Rodrigo
prev parent reply other threads:[~2018-03-28 21:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 16:07 [PATCH v7 0/2] hid-steam driver with user mode client dection Rodrigo Rivas Costa
2018-03-25 16:07 ` [PATCH v7 1/2] HID: add driver for Valve Steam Controller Rodrigo Rivas Costa
2018-03-26 9:20 ` Benjamin Tissoires
2018-03-28 21:00 ` Rodrigo Rivas Costa
2018-03-25 16:07 ` [PATCH v7 2/2] HID: steam: add battery device Rodrigo Rivas Costa
2018-03-26 8:12 ` [PATCH v7 0/2] hid-steam driver with user mode client dection Benjamin Tissoires
2018-03-28 18:14 ` Rodrigo Rivas Costa
2018-03-28 21:44 ` Rodrigo Rivas Costa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328214438.GA5740@casa \
--to=rodrigorivascosta@gmail.com \
--cc=aicommander@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=clement.vuchener@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pgriffais@valvesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.