From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, Russell King <rmk+kernel@armlinux.org.uk>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
"David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Yan Markman <ymarkman@marvell.com>,
Stefan Chulski <stefanc@marvell.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Miquel Raynal <miquel.raynal@free-electrons.com>,
Marcin Wojtas <mw@semihalf.com>
Subject: Re: [PATCH net-next 2/2] sfp/phylink: move module EEPROM ethtool access into netdev core ethtool
Date: Thu, 29 Mar 2018 00:02:44 +0200 [thread overview]
Message-ID: <20180328220244.GA23595@lunn.ch> (raw)
In-Reply-To: <20180328190339.31433-3-f.fainelli@gmail.com>
On Wed, Mar 28, 2018 at 12:03:39PM -0700, Florian Fainelli wrote:
> From: Russell King <rmk+kernel@armlinux.org.uk>
>
> Provide a pointer to the SFP bus in struct net_device, so that the
> ethtool module EEPROM methods can access the SFP directly, rather
> than needing every user to provide a hook for it.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> drivers/net/ethernet/marvell/mvneta.c | 18 ------------------
> drivers/net/phy/phylink.c | 28 ----------------------------
> drivers/net/phy/sfp-bus.c | 6 ++----
> include/linux/netdevice.h | 3 +++
> include/linux/phylink.h | 3 ---
> net/core/ethtool.c | 7 +++++++
> 6 files changed, 12 insertions(+), 53 deletions(-)
The diffstats look good, DSA and all other uses of phylink will make a
similar saving in code. The new member in the netdev structure is well
away from members which are commented as being cache line sensitive.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2018-03-28 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 19:03 [PATCH net-next 0/2] phylink: API changes Florian Fainelli
2018-03-28 19:03 ` [PATCH net-next 1/2] net: phy: phylink: Provide PHY interface to mac_link_{up,down} Florian Fainelli
2018-03-28 19:09 ` Russell King - ARM Linux
2018-03-28 19:03 ` [PATCH net-next 2/2] sfp/phylink: move module EEPROM ethtool access into netdev core ethtool Florian Fainelli
2018-03-28 19:11 ` Russell King - ARM Linux
2018-03-28 19:12 ` Florian Fainelli
2018-03-28 22:02 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328220244.GA23595@lunn.ch \
--to=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.