From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:60378 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbeC2GcF (ORCPT ); Thu, 29 Mar 2018 02:32:05 -0400 Date: Thu, 29 Mar 2018 08:32:01 +0200 From: Greg Kroah-Hartman To: Guenter Roeck Cc: Marc Zyngier , stable@vger.kernel.org, Hans de Goede Subject: Re: Regression in v4.4.124 due to 'genirq: Use irqd_get_trigger_type to compare ..' Message-ID: <20180329063201.GA1816@kroah.com> References: <20180328215918.GA27069@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180328215918.GA27069@roeck-us.net> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Mar 28, 2018 at 02:59:18PM -0700, Guenter Roeck wrote: > Hi Greg, > > commit 9d0273bb1c4b64 ("genirq: Use irqd_get_trigger_type to compare the trigger > type for shared IRQs") causes a regression in v4.4.124. The problem has been fixed > upstream with commit 4f8413a3a799 ("genirq: Track whether the trigger type has > been set"). Please apply that patch to v4.4.y at your earliest convenience. > > The patch does not apply cleanly; you'll get a conflict include/linux/irq.h. > The fix is simple - just take the version introduced by the patch. It adds > a couple of extra defines, but those don't hurt and just keep the code aligned > with upstream. Thanks, this was also needed for 4.9.y and 3.18.y. greg k-h