From: Ido Schimmel <idosch@idosch.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
roopa@cumulusnetworks.com, shm@cumulusnetworks.com,
jiri@mellanox.com, idosch@mellanox.com,
jakub.kicinski@netronome.com, andy.roulin@gmail.com
Subject: Re: [PATCH net-next 3/6] net/ipv4: Move call_fib_entry_notifiers up for new routes
Date: Thu, 29 Mar 2018 11:22:58 +0300 [thread overview]
Message-ID: <20180329082258.GD22733@splinter> (raw)
In-Reply-To: <20180328012200.15175-4-dsa@cumulusnetworks.com>
On Tue, Mar 27, 2018 at 06:21:57PM -0700, David Ahern wrote:
> Move call to call_fib_entry_notifiers for new IPv4 routes to right
> before the call to fib_insert_alias. At this point the only remaining
> failure path is memory allocations in fib_insert_node. Handle that
> very unlikely failure with a call to call_fib_entry_notifiers to
> tell drivers about it.
>
> At this point notifier handlers can decide the fate of the new route
> with a clean path to delete the potential new entry if the notifier
> returns non-0.
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
next prev parent reply other threads:[~2018-03-29 8:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 1:21 [PATCH net-next 0/6] net: Allow FIB notifiers to fail add and replace David Ahern
2018-03-28 1:21 ` [PATCH net-next 1/6] net: Fix fib notifer to return errno David Ahern
2018-03-29 8:19 ` Ido Schimmel
2018-03-28 1:21 ` [PATCH net-next 2/6] net: Move call_fib_rule_notifiers up in fib_nl_newrule David Ahern
2018-03-29 8:20 ` Ido Schimmel
2018-03-29 8:22 ` Ido Schimmel
2018-03-28 1:21 ` [PATCH net-next 3/6] net/ipv4: Move call_fib_entry_notifiers up for new routes David Ahern
2018-03-29 8:22 ` Ido Schimmel [this message]
2018-03-28 1:21 ` [PATCH net-next 4/6] net/ipv4: Allow notifier to fail route replace David Ahern
2018-03-29 8:23 ` Ido Schimmel
2018-03-28 1:21 ` [PATCH net-next 5/6] net/ipv6: Move call_fib6_entry_notifiers up for route adds David Ahern
2018-03-29 8:23 ` Ido Schimmel
2018-03-28 1:22 ` [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink David Ahern
2018-03-28 1:34 ` Jakub Kicinski
2018-03-29 18:11 ` David Miller
2018-03-29 20:01 ` David Ahern
2018-04-05 17:27 ` Jiri Pirko
2018-04-05 20:10 ` David Ahern
2018-04-05 21:06 ` David Ahern
2018-04-06 5:52 ` Jiri Pirko
2018-04-06 21:22 ` David Ahern
2018-04-09 8:18 ` Jiri Pirko
2018-04-06 5:35 ` Jiri Pirko
2018-03-29 8:29 ` [PATCH net-next 0/6] net: Allow FIB notifiers to fail add and replace Ido Schimmel
2018-03-29 20:00 ` David Ahern
2018-03-29 18:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329082258.GD22733@splinter \
--to=idosch@idosch.org \
--cc=andy.roulin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=shm@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.