From: Jiri Olsa <jolsa@redhat.com>
To: "Jin, Yao" <yao.jin@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v3 0/5] Support perf -vv
Date: Thu, 29 Mar 2018 10:33:58 +0200 [thread overview]
Message-ID: <20180329083358.GA28857@krava> (raw)
In-Reply-To: <ef9f7e74-d94a-895d-fb26-35f2820fd95f@linux.intel.com>
On Thu, Mar 29, 2018 at 03:49:18PM +0800, Jin, Yao wrote:
SNIP
> > That would make it easier to grep around in the source looking for where code
> > related a particular features is located.
> >
>
> Good idea, thanks! I will support it in v4.
>
> > BTW. #2: to the compulsive perfectionist in me "HAVE_DWARF_GETLOCATIONS" is now
> > sticking out like a sore thumb: it's the only library flag left that doesn't have
> > the _SUPPORT suffix. Rename it to HAVE_DWARF_GETLOCATIONS_SUPPORT perhaps?
> >
> > Thanks,
> >
> > Ingo
> >
>
> OK, I will rename it to HAVE_DWARF_GETLOCATIONS_SUPPORT in v4.
thanks for doing this, I'll ack the new version then
jirka
next prev parent reply other threads:[~2018-03-29 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 14:56 [PATCH v3 0/5] Support perf -vv Jin Yao
2018-03-29 7:20 ` Ingo Molnar
2018-03-29 7:49 ` Jin, Yao
2018-03-29 8:33 ` Jiri Olsa [this message]
2018-03-29 14:56 ` [PATCH v3 1/5] tools include: Add config.h header file Jin Yao
2018-03-29 14:56 ` [PATCH v3 3/5] perf version: Print the compiled-in status of libraries Jin Yao
2018-03-29 14:56 ` [PATCH v3 4/5] perf: Support perf -vv Jin Yao
2018-03-29 14:56 ` [PATCH v3 5/5] perf Documentation: Create perf-version.txt Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329083358.GA28857@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.