From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Michael Thayer <michael.thayer@oracle.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/3] virt: vbox: Use __get_free_pages instead of kmalloc for DMA32 memory
Date: Thu, 29 Mar 2018 13:57:19 +0200 [thread overview]
Message-ID: <20180329115719.GC6734@kroah.com> (raw)
In-Reply-To: <20180329112116.26488-2-hdegoede@redhat.com>
On Thu, Mar 29, 2018 at 01:21:15PM +0200, Hans de Goede wrote:
> @@ -87,7 +88,7 @@ void vbg_req_free(void *req, size_t len)
> if (!req)
> return;
>
> - kfree(req);
> + free_pages((unsigned long)req, get_order(PAGE_ALIGN(len)));
> }
Really? This feels wrong to me, why is this driver so special that it
has to use free_pages and the like?
greg k-h
next prev parent reply other threads:[~2018-03-29 11:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 11:21 [PATCH 1/3] virt: vbox: Add vbg_req_free() helper function Hans de Goede
2018-03-29 11:21 ` [PATCH 2/3] virt: vbox: Use __get_free_pages instead of kmalloc for DMA32 memory Hans de Goede
2018-03-29 11:57 ` Greg Kroah-Hartman [this message]
2018-03-29 11:58 ` Greg Kroah-Hartman
2018-03-29 13:42 ` Hans de Goede
2018-03-29 16:39 ` Greg Kroah-Hartman
2018-04-03 13:20 ` Hans de Goede
2018-03-29 11:21 ` [PATCH 3/3] virt: vbox: Log an error whenwe fail to get the host version Hans de Goede
2018-03-29 11:55 ` [PATCH 1/3] virt: vbox: Add vbg_req_free() helper function Greg Kroah-Hartman
2018-03-29 13:12 ` Hans de Goede
2018-03-29 11:56 ` Greg Kroah-Hartman
2018-03-29 13:16 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329115719.GC6734@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thayer@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.