From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: Sorry, Patch wrong (was: patch "USB: serial: ftdi_sio: add Id for Physik Instrumente E-870" added to usb-testing) From: Johan Hovold Message-Id: <20180329123937.GB16578@localhost> Date: Thu, 29 Mar 2018 14:39:37 +0200 To: "Teichmann, Martin" Cc: Greg KH , Johan Hovold , stable@vger.kernel.org, linux-usb List-ID: T24gVGh1LCBNYXIgMjksIDIwMTggYXQgMDE6NDk6MDJQTSArMDIwMCwgVGVpY2htYW5uLCBNYXJ0 aW4gd3JvdGU6Cj4gRGVhciBHcmVnLCBkZWFyIEpvaGFuLCBkZWFyIGxpc3QsCj4gCj4gSSdtIHZl cnkgc29ycnkgSSB3YXMgYSBiaXQgcXVpY2sgaW4gc2VuZGluZyB5b3UgYSBwYXRjaCBmb3IgdGhl IFBJCj4gRS04NzAgZGV2aWNlLCBiZWNhdXNlIGl0J3MgYWN0dWFsbHkgd3JvbmcuIEV2ZXJ5dGhp bmcgc2VlbWVkIHRvIHdvcmsKPiBmaW5lLCB1bnRpbCBJIHJlYWxpemVkIHRoYXQgb25jZSBpbiBh IHdoaWxlIHR3byBjaGFyYWN0ZXJzIHdlcmUKPiBtaXNzaW5nLiBDaGVja2luZyBkbWVzZyBJIHJl YWxpemVkIGVycm9yIG1lc3NhZ2VzIGhhZCBwaWxlZCB1cC4gSXQKPiB0dXJucyBvdXQsIHRoZSBk ZXZpY2UgaXMgbm90IGNvbXBhdGlibGUgd2l0aCB0aGUgZnRkaV9zaW8gZHJpdmVyIGluCj4gdGhl IGVuZC4gSSBob3BlIHRoaXMgY2FuIGJlIHVuZG9uZS4uLgoKTm8gd29ycmllcywgSSBqdXN0IHNl bnQgYSByZXZlcnQgcGF0Y2ggdG8gR3JlZy4KCj4gVGhlIGRldmljZSwgaG93ZXZlciB3b3JrcyB3 aXRoIGEgdXNiLXNlcmlhbC1zaW1wbGUgZHJpdmVyLgo+IFVuZm9ydHVuYXRlbHksIGl0IGlzIG5v dCBhcyBlYXN5IGFzIGZvciB0aGUgRS04NzAgdG8gc3VwcGx5IGEgcGF0Y2gsCj4gYXMgdXNiLXNl cmlhbC1zaW1wbGUgZG9lcyBub3QganVzdCBjb250YWluIGEgbGlzdCBvZiBWSUQgYW5kIFBJRHMs IGJ1dAo+IGFjdHVhbGx5IGNyZWF0ZXMgYSBuZXcgZW50cnkgc29tZXdoZXJlIGluIC9zeXMvYnVz IGZvciBlYWNoIHZlbmRvci4gSQo+IHdvdWxkIGxpa2UgdG8gc2VuZCBpbiBwYXRjaCBmb3IgdGhp cyBsYXRlciwgYnV0IHRoaXMgdGltZSBwcm9wZXJseQo+IHRlc3RlZC4uLgoKVHJ5IGZpcnN0IHRv IGRldGVybWluZSB3aGF0IGNoaXAgdGhpcyByZWFsbHkgaXMgKGUuZy4gYnkgb3BlbmluZyB0aGUK ZGV2aWNlKS4gQ2hhbmNlcyBhcmUgdGhlcmUncyBhbHJlYWR5IGEgZHJpdmVyIGZvciBpdC4gRnVs bCAibHN1c2IgLXYiCm1pZ2h0IGFsc28gZ2l2ZSBzb21lIGNsdWVzLgoKVGhhbmtzLApKb2hhbgot LS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2Ny aWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2Vy Lmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9y Zy9tYWpvcmRvbW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f46.google.com ([209.85.215.46]:44888 "EHLO mail-lf0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752209AbeC2Mjg (ORCPT ); Thu, 29 Mar 2018 08:39:36 -0400 Date: Thu, 29 Mar 2018 14:39:37 +0200 From: Johan Hovold To: "Teichmann, Martin" Cc: Greg KH , Johan Hovold , stable@vger.kernel.org, linux-usb Subject: Re: Sorry, Patch wrong (was: patch "USB: serial: ftdi_sio: add Id for Physik Instrumente E-870" added to usb-testing) Message-ID: <20180329123937.GB16578@localhost> References: <152231545852176@kroah.com> <36563274.10190068.1522324142240.JavaMail.zimbra@xfel.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36563274.10190068.1522324142240.JavaMail.zimbra@xfel.eu> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Mar 29, 2018 at 01:49:02PM +0200, Teichmann, Martin wrote: > Dear Greg, dear Johan, dear list, > > I'm very sorry I was a bit quick in sending you a patch for the PI > E-870 device, because it's actually wrong. Everything seemed to work > fine, until I realized that once in a while two characters were > missing. Checking dmesg I realized error messages had piled up. It > turns out, the device is not compatible with the ftdi_sio driver in > the end. I hope this can be undone... No worries, I just sent a revert patch to Greg. > The device, however works with a usb-serial-simple driver. > Unfortunately, it is not as easy as for the E-870 to supply a patch, > as usb-serial-simple does not just contain a list of VID and PIDs, but > actually creates a new entry somewhere in /sys/bus for each vendor. I > would like to send in patch for this later, but this time properly > tested... Try first to determine what chip this really is (e.g. by opening the device). Chances are there's already a driver for it. Full "lsusb -v" might also give some clues. Thanks, Johan