From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/edid: Dump valid EDIDs too
Date: Thu, 29 Mar 2018 19:14:05 +0300 [thread overview]
Message-ID: <20180329161405.GV5453@intel.com> (raw)
In-Reply-To: <152233927387.10679.1284486898466069916@mail.alporthouse.com>
On Thu, Mar 29, 2018 at 05:01:13PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2018-03-29 16:50:23)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Having the EDID available is often very beneficial for bug analysis,
> > even when the EDID itself is valid and not the direct cause of the
> > bug. So let's dump the EDID to dmesg even when it's valid. This
> > should also give us a better historical record of EDIDs for later
> > analysis.
>
> Isn't this a bit frequent for a largely unchanging blob?
Perhaps. Though ideally we shouldn't go re-reading it all the time.
But I guess that's wisful thinking.
Not sure we have a good place where we could memcmp() the new EDID
against the old one and only print if it changed.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-29 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 15:50 [PATCH] drm/edid: Dump valid EDIDs too Ville Syrjala
2018-03-29 16:01 ` Chris Wilson
2018-03-29 16:14 ` Ville Syrjälä [this message]
2018-03-29 16:47 ` Chris Wilson
2018-03-29 16:40 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-29 21:00 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329161405.GV5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.