From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 02/23] drm/atomic-helper: Make drm_atomic_helper_disable_all() update the plane->fb pointers Date: Thu, 29 Mar 2018 19:32:01 +0300 Message-ID: <20180329163201.GX5453@intel.com> References: <20180322152313.6561-1-ville.syrjala@linux.intel.com> <20180322152313.6561-3-ville.syrjala@linux.intel.com> <20180326202806.GY14155@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180326202806.GY14155@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, martin.peres@free.fr List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBNYXIgMjYsIDIwMTggYXQgMTA6Mjg6MDZQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUaHUsIE1hciAyMiwgMjAxOCBhdCAwNToyMjo1MlBNICswMjAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gZHJtX2F0b21pY19oZWxwZXJfc2h1dGRvd24oKSBuZWVk cyB0byByZWxlYXNlIHRoZSByZWZlcmVuY2UgaGVsZCBieQo+ID4gcGxhbmUtPmZiLCBzbyB3ZSB3 YW50IHRvIHVzZSBkcm1fYXRvbWljX2NsZWFuX29sZF9mYigpIGluCj4gPiBkcm1fYXRvbWljX2hl bHBlcl9kaXNhYmxlX2FsbCgpLiBIb3dldmVyIGR1cmluZyBzdXNwZW5kL3Jlc3VtZSwgZ3B1Cj4g PiByZXNldCBhbmQgbG9hZCBkZXRlY3Rpb24gd2Ugc2hvdWxkIHByb2JhYmx5IGxlYXZlIHRoYXQg c3R1ZmYgYWxvbmUsCj4gPiBhcyBvdGhlcndpc2Ugd2UnZCBoYXZlIHRvIG1ha2Ugc3VyZSB3ZSBw dXQgdGhlbSBiYWNrIGFnYWluIHdoZW4KPiA+IHdlIHJlc3RvcmUgdGhlIGR1cGxpY2F0ZWQgc3Rh dGUgdG8gdGhlIGRldmljZS4gU2VlbXMgc2ltcGxlciB0byBtZQo+ID4gdG8gbm90IHRvdWNoIGFu eSBvZiBpdCBhbnl3YXkuCj4gPiAKPiA+IHYyOiBEb24ndCBpbmZsaWN0IHRoZSBjbGVhbl9vbGRf ZmJzIGJvb2wgdG8gZHJpdmVycyAoRGFuaWVsKQo+ID4gCj4gPiBDYzogbWFydGluLnBlcmVzQGZy ZWUuZnIKPiA+IENjOiBjaHJpc0BjaHJpcy13aWxzb24uY28udWsKPiA+IENjOiBEYXZlIEFpcmxp ZSA8YWlybGllZEBnbWFpbC5jb20+ICh2MSkKPiA+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFh cnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRh bmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IAo+IEkgdGhpbmsgdGhpcyB3b3VsZCBi ZSBjbGVhbmVyIGRpZmYgdG8gcmVhZCBpZiB5b3Ugc3F1YXNoIHRoZSBmaXJzdCAyCj4gcGF0Y2hl cyB0b2dldGhlci4gQWxzbyBhdm9pZHMgdGhlIGJpc2VjdCBmYWlsLiBXaXRoIHRoYXQgKGFuZCBJ IHRydXN0IHlvdQo+IHRvIGNvbWUgdXAgd2l0aCBhIHN1aXRhYmx5IG1lcmdlZCBjb21taXQgbWVz c2FnZSk6Cj4gCj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3 bGwuY2g+CgpTcXVhc2hlZCwgYW5kIGNvbW1pdCBtZXNzYWdlIHJlc2NyaWJiZWxlZC4gQW5kIHdp dGggc3VmZmljaWVudCBjb25maWRlbmNlCmZyb20gYSBsb2NhbCBzbW9rZSB0ZXN0IEkgcHJvY2Vl ZGVkIHRvIHB1c2ggdGhlIGVhc3kgb25lcyAxLTEzIChleGNlcHQgbXNtKSwgCmFuZCAyMi0yMyAo dGhlIGxvYWQgZGV0ZWN0IHN0dWZmIGZvciBpOTE1KS4gSSdsbCBoYXZlIHRvIGZpZ3VyZSBvdXQg dGhlCmNvcnJlY3QgbWVyZ2Ugb3JkZXIgZm9yIHRoZSByZXN0IG5leHQgd2Vlay4KClRoYW5rcyBm b3IgdGhlIHJldmlld3MuCgo+IAo+IEkgcmV2aWV3ZWQgdGhpcyBieSByZS1yZWFkaW5nIHRoZSBh bmFseXNpcyBmcm9tIDQ5ZDcwYWVhZWNhOGY2MmI3MmI3NyBhbmQKPiB0cnVzdGluZyBteSBmb3Jt ZXIgc2VsZiA6LSkKPiAKPiBDaGVlcnMsIERhbmllbAo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9n cHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgfCA2NyArKysrKysrKysrKysrKysrKysrKysrLS0t LS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDI3IGRl bGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ID4gaW5k ZXggYzQ4ZjE4N2QwOGRlLi4zOWE2OTUwOGQ4YzkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9h dG9taWNfaGVscGVyLmMKPiA+IEBAIC0yODgxLDMxICsyODgxLDkgQEAgaW50IF9fZHJtX2F0b21p Y19oZWxwZXJfc2V0X2NvbmZpZyhzdHJ1Y3QgZHJtX21vZGVfc2V0ICpzZXQsCj4gPiAgCXJldHVy biAwOwo+ID4gIH0KPiA+ICAKPiA+IC0vKioKPiA+IC0gKiBkcm1fYXRvbWljX2hlbHBlcl9kaXNh YmxlX2FsbCAtIGRpc2FibGUgYWxsIGN1cnJlbnRseSBhY3RpdmUgb3V0cHV0cwo+ID4gLSAqIEBk ZXY6IERSTSBkZXZpY2UKPiA+IC0gKiBAY3R4OiBsb2NrIGFjcXVpc2l0aW9uIGNvbnRleHQKPiA+ IC0gKgo+ID4gLSAqIExvb3BzIHRocm91Z2ggYWxsIGNvbm5lY3RvcnMsIGZpbmRpbmcgdGhvc2Ug dGhhdCBhcmVuJ3QgdHVybmVkIG9mZiBhbmQgdGhlbgo+ID4gLSAqIHR1cm5zIHRoZW0gb2ZmIGJ5 IHNldHRpbmcgdGhlaXIgRFBNUyBtb2RlIHRvIE9GRiBhbmQgZGVhY3RpdmF0aW5nIHRoZSBDUlRD Cj4gPiAtICogdGhhdCB0aGV5IGFyZSBjb25uZWN0ZWQgdG8uCj4gPiAtICoKPiA+IC0gKiBUaGlz IGlzIHVzZWQgZm9yIGV4YW1wbGUgaW4gc3VzcGVuZC9yZXN1bWUgdG8gZGlzYWJsZSBhbGwgY3Vy cmVudGx5IGFjdGl2ZQo+ID4gLSAqIGZ1bmN0aW9ucyB3aGVuIHN1c3BlbmRpbmcuIElmIHlvdSBq dXN0IHdhbnQgdG8gc2h1dCBkb3duIGV2ZXJ5dGhpbmcgYXQgZS5nLgo+ID4gLSAqIGRyaXZlciB1 bmxvYWQsIGxvb2sgYXQgZHJtX2F0b21pY19oZWxwZXJfc2h1dGRvd24oKS4KPiA+IC0gKgo+ID4g LSAqIE5vdGUgdGhhdCBpZiBjYWxsZXJzIGhhdmVuJ3QgYWxyZWFkeSBhY3F1aXJlZCBhbGwgbW9k ZXNldCBsb2NrcyB0aGlzIG1pZ2h0Cj4gPiAtICogcmV0dXJuIC1FREVBRExLLCB3aGljaCBtdXN0 IGJlIGhhbmRsZWQgYnkgY2FsbGluZyBkcm1fbW9kZXNldF9iYWNrb2ZmKCkuCj4gPiAtICoKPiA+ IC0gKiBSZXR1cm5zOgo+ID4gLSAqIDAgb24gc3VjY2VzcyBvciBhIG5lZ2F0aXZlIGVycm9yIGNv ZGUgb24gZmFpbHVyZS4KPiA+IC0gKgo+ID4gLSAqIFNlZSBhbHNvOgo+ID4gLSAqIGRybV9hdG9t aWNfaGVscGVyX3N1c3BlbmQoKSwgZHJtX2F0b21pY19oZWxwZXJfcmVzdW1lKCkgYW5kCj4gPiAt ICogZHJtX2F0b21pY19oZWxwZXJfc2h1dGRvd24oKS4KPiA+IC0gKi8KPiA+IC1pbnQgZHJtX2F0 b21pY19oZWxwZXJfZGlzYWJsZV9hbGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+IC0JCQkJ ICBzdHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHggKmN0eCkKPiA+ICtzdGF0aWMgaW50IF9f ZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ ICsJCQkJCSAgIHN0cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCAqY3R4LAo+ID4gKwkJCQkJ ICAgYm9vbCBjbGVhbl9vbGRfZmJzKQo+ID4gIHsKPiA+ICAJc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlOwo+ID4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZTsK PiA+IEBAIC0yOTE0LDYgKzI4OTIsNyBAQCBpbnQgZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9h bGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ICAJc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7 Cj4gPiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiA+ICAJc3RydWN0IGRy bV9jcnRjICpjcnRjOwo+ID4gKwl1bnNpZ25lZCBpbnQgcGxhbmVfbWFzayA9IDA7Cj4gPiAgCWlu dCByZXQsIGk7Cj4gPiAgCj4gPiAgCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYp Owo+ID4gQEAgLTI5NTYsMTQgKzI5MzUsNDggQEAgaW50IGRybV9hdG9taWNfaGVscGVyX2Rpc2Fi bGVfYWxsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPiAgCQkJZ290byBmcmVlOwo+ID4gIAo+ ID4gIAkJZHJtX2F0b21pY19zZXRfZmJfZm9yX3BsYW5lKHBsYW5lX3N0YXRlLCBOVUxMKTsKPiA+ ICsKPiA+ICsJCWlmIChjbGVhbl9vbGRfZmJzKSB7Cj4gPiArCQkJcGxhbmUtPm9sZF9mYiA9IHBs YW5lLT5mYjsKPiA+ICsJCQlwbGFuZV9tYXNrIHw9IEJJVChkcm1fcGxhbmVfaW5kZXgocGxhbmUp KTsKPiA+ICsJCX0KPiA+ICAJfQo+ID4gIAo+ID4gIAlyZXQgPSBkcm1fYXRvbWljX2NvbW1pdChz dGF0ZSk7Cj4gPiAgZnJlZToKPiA+ICsJZHJtX2F0b21pY19jbGVhbl9vbGRfZmIoZGV2LCBwbGFu ZV9tYXNrLCByZXQpOwo+ID4gKwo+ID4gIAlkcm1fYXRvbWljX3N0YXRlX3B1dChzdGF0ZSk7Cj4g PiAgCXJldHVybiByZXQ7Cj4gPiAgfQo+ID4gLQo+ID4gKy8qKgo+ID4gKyAqIGRybV9hdG9taWNf aGVscGVyX2Rpc2FibGVfYWxsIC0gZGlzYWJsZSBhbGwgY3VycmVudGx5IGFjdGl2ZSBvdXRwdXRz Cj4gPiArICogQGRldjogRFJNIGRldmljZQo+ID4gKyAqIEBjdHg6IGxvY2sgYWNxdWlzaXRpb24g Y29udGV4dAo+ID4gKyAqCj4gPiArICogTG9vcHMgdGhyb3VnaCBhbGwgY29ubmVjdG9ycywgZmlu ZGluZyB0aG9zZSB0aGF0IGFyZW4ndCB0dXJuZWQgb2ZmIGFuZCB0aGVuCj4gPiArICogdHVybnMg dGhlbSBvZmYgYnkgc2V0dGluZyB0aGVpciBEUE1TIG1vZGUgdG8gT0ZGIGFuZCBkZWFjdGl2YXRp bmcgdGhlIENSVEMKPiA+ICsgKiB0aGF0IHRoZXkgYXJlIGNvbm5lY3RlZCB0by4KPiA+ICsgKgo+ ID4gKyAqIFRoaXMgaXMgdXNlZCBmb3IgZXhhbXBsZSBpbiBzdXNwZW5kL3Jlc3VtZSB0byBkaXNh YmxlIGFsbCBjdXJyZW50bHkgYWN0aXZlCj4gPiArICogZnVuY3Rpb25zIHdoZW4gc3VzcGVuZGlu Zy4gSWYgeW91IGp1c3Qgd2FudCB0byBzaHV0IGRvd24gZXZlcnl0aGluZyBhdCBlLmcuCj4gPiAr ICogZHJpdmVyIHVubG9hZCwgbG9vayBhdCBkcm1fYXRvbWljX2hlbHBlcl9zaHV0ZG93bigpLgo+ ID4gKyAqCj4gPiArICogTm90ZSB0aGF0IGlmIGNhbGxlcnMgaGF2ZW4ndCBhbHJlYWR5IGFjcXVp cmVkIGFsbCBtb2Rlc2V0IGxvY2tzIHRoaXMgbWlnaHQKPiA+ICsgKiByZXR1cm4gLUVERUFETEss IHdoaWNoIG11c3QgYmUgaGFuZGxlZCBieSBjYWxsaW5nIGRybV9tb2Rlc2V0X2JhY2tvZmYoKS4K PiA+ICsgKgo+ID4gKyAqIFJldHVybnM6Cj4gPiArICogMCBvbiBzdWNjZXNzIG9yIGEgbmVnYXRp dmUgZXJyb3IgY29kZSBvbiBmYWlsdXJlLgo+ID4gKyAqCj4gPiArICogU2VlIGFsc286Cj4gPiAr ICogZHJtX2F0b21pY19oZWxwZXJfc3VzcGVuZCgpLCBkcm1fYXRvbWljX2hlbHBlcl9yZXN1bWUo KSBhbmQKPiA+ICsgKiBkcm1fYXRvbWljX2hlbHBlcl9zaHV0ZG93bigpLgo+ID4gKyAqLwo+ID4g K2ludCBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LAo+ID4gKwkJCQkgIHN0cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCAqY3R4KQo+ID4gK3sK PiA+ICsJcmV0dXJuIF9fZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwoZGV2LCBjdHgsIGZh bHNlKTsKPiA+ICt9Cj4gPiAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxl X2FsbCk7Cj4gPiAgCj4gPiAgLyoqCj4gPiBAQCAtMjk4Niw3ICsyOTk5LDcgQEAgdm9pZCBkcm1f YXRvbWljX2hlbHBlcl9zaHV0ZG93bihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gIAl3aGls ZSAoMSkgewo+ID4gIAkJcmV0ID0gZHJtX21vZGVzZXRfbG9ja19hbGxfY3R4KGRldiwgJmN0eCk7 Cj4gPiAgCQlpZiAoIXJldCkKPiA+IC0JCQlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxl X2FsbChkZXYsICZjdHgpOwo+ID4gKwkJCXJldCA9IF9fZHJtX2F0b21pY19oZWxwZXJfZGlzYWJs ZV9hbGwoZGV2LCAmY3R4LCB0cnVlKTsKPiA+ICAKPiA+ICAJCWlmIChyZXQgIT0gLUVERUFETEsp Cj4gPiAgCQkJYnJlYWs7Cj4gPiAtLSAKPiA+IDIuMTYuMQo+ID4gCj4gCj4gLS0gCj4gRGFuaWVs IFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9i bG9nLmZmd2xsLmNoCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK