From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/3] test_net.sh: Support both old and new shell APIs
Date: Thu, 29 Mar 2018 19:00:49 +0200 [thread overview]
Message-ID: <20180329170048.GA9981@x230> (raw)
In-Reply-To: <20180329154537.32711-2-pvorel@suse.cz>
Hi,
> This is temporary solution, after migrating all tests to new SHELL API
> the compatibility layer and old SHELL API support should be removed and
> file renamed to tst_net.sh.
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/lib/test_net.sh | 126 ++++++++++++++++++++++++++++------------------
...
> +if [ -z "$TST_LIB_LOADED" ]; then
> + [ -n "$TST_USE_NEW_API" ] && . tst_test.sh || . test.sh
This makes legacy API default. Actually I'd like to change it in v2 to
make new API default, i.e.
if [ -z "$TST_LIB_LOADED" ]; then
[ -n "$TST_USE_LEGACY_API" ] && test.sh || . tst_test.sh
fi
[ -n "$TST_USE_LEGACY_API" ] && tst_read_opts $*
...
And add TST_USE_LEGACY_API=1 to all scripts.
Kind regards,
Petr
next prev parent reply other threads:[~2018-03-29 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 15:45 [LTP] [RFC PATCH 0/3] Rewritting network tests into new shell API Petr Vorel
2018-03-29 15:45 ` [LTP] [RFC PATCH 1/3] test_net.sh: Support both old and new shell APIs Petr Vorel
2018-03-29 17:00 ` Petr Vorel [this message]
2018-03-29 15:45 ` [LTP] [RFC PATCH 2/3] network/interface: Cleanup if4-addr-change Petr Vorel
2018-03-29 15:45 ` [LTP] [RFC PATCH 3/3] net: Migrate test_net_stress.sh and it's dependencies to new shell API Petr Vorel
2018-03-29 17:30 ` [LTP] [RFC PATCH 0/3] Rewritting network tests into " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329170048.GA9981@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.