From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-pg0-f52.google.com ([74.125.83.52]:39209 "EHLO
        mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750866AbeC2Ryg (ORCPT
        <rfc822;stable@vger.kernel.org>); Thu, 29 Mar 2018 13:54:36 -0400
Received: by mail-pg0-f52.google.com with SMTP id b9so3533276pgf.6
        for <stable@vger.kernel.org>; Thu, 29 Mar 2018 10:54:36 -0700 (PDT)
Date: Thu, 29 Mar 2018 10:54:34 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>, stable@vger.kernel.org,
        Hans de Goede <hdegoede@redhat.com>
Subject: Re: Regression in v4.4.124 due to 'genirq: Use irqd_get_trigger_type
 to compare ..'
Message-ID: <20180329175434.GA8446@roeck-us.net>
References: <20180328215918.GA27069@roeck-us.net>
 <20180329063201.GA1816@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180329063201.GA1816@kroah.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Mar 29, 2018 at 08:32:01AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Mar 28, 2018 at 02:59:18PM -0700, Guenter Roeck wrote:
> > Hi Greg,
> > 
> > commit 9d0273bb1c4b64 ("genirq: Use irqd_get_trigger_type to compare the trigger
> > type for shared IRQs") causes a regression in v4.4.124. The problem has been fixed
> > upstream with commit 4f8413a3a799 ("genirq: Track whether the trigger type has
> > been set"). Please apply that patch to v4.4.y at your earliest convenience.
> > 
> > The patch does not apply cleanly; you'll get a conflict include/linux/irq.h.
> > The fix is simple - just take the version introduced by the patch. It adds
> > a couple of extra defines, but those don't hurt and just keep the code aligned
> > with upstream.
> 
> Thanks, this was also needed for 4.9.y and 3.18.y.
> 

Odd that I didn't see the problem there. But then I still see the following
in 4.4.y after the above was added.

genirq: Flags mismatch irq 24. 00000080 ([PCI] PME) vs. 00000080 ([EDAC] PCI err)

This is with powerpc:mpc8544ds:mpc85xx_defconfig. I do _not_ see this problem
in v4.9+.

Looks like I'll need to spend more time on this.

Guenter