From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: valdis.kletnieks@vt.edu, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: linux-next 20180327 - "SELinux: (dev dm-3, type ext4) getxattr errno 34"
Date: Thu, 29 Mar 2018 21:32:21 -0400 [thread overview]
Message-ID: <20180330013221.GD3790@thunk.org> (raw)
In-Reply-To: <026f2dc7-1c9c-93ff-569c-87a77aad0ece@tycho.nsa.gov>
On Thu, Mar 29, 2018 at 02:35:44PM -0400, Stephen Smalley wrote:
> >
> > broke a longstanding assumption by SELinux that it could call getxattr with a NULL buffer and 0 size to probe whether the filesystem supports the security xattrs at mount time.
> >
> > Options for fixing:
> > - Revert or revise that patch to not return -ERANGE if buffer is NULL (prior behavior),
> > - Change SELinux sb_finish_set_opts() to treat -ERANGE as a non-error result.
>
> Per https://bugzilla.kernel.org/show_bug.cgi?id=199185#c4, other callers besides SELinux are also broken by this change, so a revert or revision of the ext4 commit seems necessary regardless.
Yes, the breakage is my fault; my apologies. The new version of the
patch is already posted in bugzilla (and on linux-ext4). I'll be
pushing out a refreshed ext4.git branch shortly.
- Ted
next prev parent reply other threads:[~2018-03-30 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 17:57 linux-next 20180327 - "SELinux: (dev dm-3, type ext4) getxattr errno 34" valdis.kletnieks
[not found] ` <24018.1522346273-+bZmOdGhbsPr6rcHtW+onFJE71vCis6O@public.gmane.org>
2018-03-29 18:29 ` Stephen Smalley
2018-03-29 18:29 ` Stephen Smalley
2018-03-29 18:35 ` Stephen Smalley
2018-03-30 1:32 ` Theodore Y. Ts'o [this message]
2018-03-30 4:07 ` valdis.kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330013221.GD3790@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.