From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH] setup.c: reset candidate->work_tree after freeing it
Date: Fri, 30 Mar 2018 09:07:44 +0200 [thread overview]
Message-ID: <20180330070744.22466-1-pclouds@gmail.com> (raw)
Dangling pointers are usually bad news. Reset it back to NULL.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.c b/setup.c
index 7287779642..d193bee192 100644
--- a/setup.c
+++ b/setup.c
@@ -482,7 +482,7 @@ static int check_repository_format_gently(const char *gitdir, struct repository_
inside_work_tree = -1;
}
} else {
- free(candidate->work_tree);
+ FREE_AND_NULL(candidate->work_tree);
}
return 0;
--
2.17.0.rc2.408.g9d2a3d914e
next reply other threads:[~2018-03-30 7:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 7:07 Nguyễn Thái Ngọc Duy [this message]
2018-03-30 17:10 ` [PATCH] setup.c: reset candidate->work_tree after freeing it Junio C Hamano
2018-03-30 17:41 ` Duy Nguyen
2018-03-30 18:32 ` Junio C Hamano
2018-03-30 19:10 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330070744.22466-1-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.