From: Sergey Suloev <ssuloev@orpaltech.com>
To: Mark Brown <broonie@kernel.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sergey Suloev <ssuloev@orpaltech.com>
Subject: [PATCH 2/6] spi: sun6i: handle chip select polarity flag
Date: Fri, 30 Mar 2018 10:22:39 +0300 [thread overview]
Message-ID: <20180330072243.19368-3-ssuloev@orpaltech.com> (raw)
In-Reply-To: <20180330072243.19368-1-ssuloev@orpaltech.com>
The chip select polarity flag is declared as supported
but is not handled in the code.
Signed-off-by: Sergey Suloev <ssuloev@orpaltech.com>
---
drivers/spi/spi-sun6i.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
index ff790dc..f992a7d 100644
--- a/drivers/spi/spi-sun6i.c
+++ b/drivers/spi/spi-sun6i.c
@@ -193,6 +193,12 @@ static void sun6i_spi_set_cs(struct spi_device *spi, bool enable)
else
reg &= ~SUN6I_TFR_CTL_CS_LEVEL;
+ /* Handle chip select "reverse" polarity */
+ if (spi->mode & SPI_CS_HIGH)
+ reg &= ~SUN6I_TFR_CTL_SPOL;
+ else
+ reg |= SUN6I_TFR_CTL_SPOL;
+
/* We want to control the chip select manually */
reg |= SUN6I_TFR_CTL_CS_MANUAL;
--
2.16.2
WARNING: multiple messages have this Message-ID (diff)
From: ssuloev@orpaltech.com (Sergey Suloev)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] spi: sun6i: handle chip select polarity flag
Date: Fri, 30 Mar 2018 10:22:39 +0300 [thread overview]
Message-ID: <20180330072243.19368-3-ssuloev@orpaltech.com> (raw)
In-Reply-To: <20180330072243.19368-1-ssuloev@orpaltech.com>
The chip select polarity flag is declared as supported
but is not handled in the code.
Signed-off-by: Sergey Suloev <ssuloev@orpaltech.com>
---
drivers/spi/spi-sun6i.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
index ff790dc..f992a7d 100644
--- a/drivers/spi/spi-sun6i.c
+++ b/drivers/spi/spi-sun6i.c
@@ -193,6 +193,12 @@ static void sun6i_spi_set_cs(struct spi_device *spi, bool enable)
else
reg &= ~SUN6I_TFR_CTL_CS_LEVEL;
+ /* Handle chip select "reverse" polarity */
+ if (spi->mode & SPI_CS_HIGH)
+ reg &= ~SUN6I_TFR_CTL_SPOL;
+ else
+ reg |= SUN6I_TFR_CTL_SPOL;
+
/* We want to control the chip select manually */
reg |= SUN6I_TFR_CTL_CS_MANUAL;
--
2.16.2
next prev parent reply other threads:[~2018-03-30 7:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 7:22 [PATCH 0/6] spi: Add support for DMA transfers in sun6i SPI driver Sergey Suloev
2018-03-30 7:22 ` Sergey Suloev
2018-03-30 7:22 ` [PATCH 1/6] spi: sun6i: coding style/readability improvements Sergey Suloev
2018-03-30 7:22 ` Sergey Suloev
2018-03-30 7:22 ` Sergey Suloev [this message]
2018-03-30 7:22 ` [PATCH 2/6] spi: sun6i: handle chip select polarity flag Sergey Suloev
2018-03-30 7:22 ` [PATCH 3/6] spi: sun6i: restrict transfer length in PIO-mode Sergey Suloev
2018-03-30 7:22 ` Sergey Suloev
2018-03-30 7:22 ` [PATCH 4/6] spi: sun6i: use completion provided by SPI core Sergey Suloev
2018-03-30 7:22 ` Sergey Suloev
2018-03-30 7:22 ` [PATCH 5/6] spi: sun6i: introduce register set/unset helpers Sergey Suloev
2018-03-30 7:22 ` Sergey Suloev
2018-03-30 7:22 ` Sergey Suloev
2018-03-30 7:22 ` [PATCH 6/6] spi: sun6i: add DMA transfers support Sergey Suloev
2018-03-30 7:22 ` Sergey Suloev
2018-03-30 7:33 ` [PATCH 0/6] spi: Add support for DMA transfers in sun6i SPI driver Chen-Yu Tsai
2018-03-30 7:33 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330072243.19368-3-ssuloev@orpaltech.com \
--to=ssuloev@orpaltech.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.