From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Subject: [PATCH v2 2/3] powerpc: hard disable irqs in smp_send_stop loop
Date: Sun, 1 Apr 2018 20:36:14 +1000 [thread overview]
Message-ID: <20180401103615.15454-3-npiggin@gmail.com> (raw)
In-Reply-To: <20180401103615.15454-1-npiggin@gmail.com>
The hard lockup watchdog can fire under local_irq_disable
on platforms with irq soft masking.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
arch/powerpc/kernel/smp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index db88660bf6bd..e16ec7b3b427 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -574,9 +574,10 @@ static void stop_this_cpu(void *dummy)
/* Remove this CPU */
set_cpu_online(smp_processor_id(), false);
- local_irq_disable();
+ hard_irq_disable();
+ spin_begin();
while (1)
- ;
+ spin_cpu_relax();
}
void smp_send_stop(void)
--
2.16.3
next prev parent reply other threads:[~2018-04-01 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 10:36 [PATCH 0/3] stop secondaries for reboot/shutdown Nicholas Piggin
2018-04-01 10:36 ` [PATCH v2 1/3] powerpc: use NMI IPI for smp_send_stop Nicholas Piggin
2018-04-03 0:13 ` Balbir Singh
2018-04-03 2:35 ` Nicholas Piggin
2018-04-04 14:39 ` [v2,1/3] " Michael Ellerman
2018-04-01 10:36 ` Nicholas Piggin [this message]
2018-04-01 10:36 ` [PATCH v2 3/3] powerpc/powernv: Always stop secondaries before reboot/shutdown Nicholas Piggin
2018-04-03 4:36 ` Vasant Hegde
2018-04-02 14:52 ` [PATCH 0/3] stop secondaries for reboot/shutdown ppaidipe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180401103615.15454-3-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=hegdevasant@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.