From: Stephen Hemminger <stephen@networkplumber.org>
To: bugzilla@dpdk.org
Cc: dev@dpdk.org
Subject: Re: [Bug 22] Ixgbe driver sets RDRXCTL with the wrong RSCACKC and FCOE_WRFIX values
Date: Sun, 1 Apr 2018 18:29:07 -0700 [thread overview]
Message-ID: <20180401182907.1d7aaa61@xeon-e3> (raw)
In-Reply-To: <bug-22-3@http.dpdk.org/tracker/>
On Sun, 01 Apr 2018 12:42:38 +0000
bugzilla@dpdk.org wrote:
> https://dpdk.org/tracker/show_bug.cgi?id=22
>
> Bug ID: 22
> Summary: Ixgbe driver sets RDRXCTL with the wrong RSCACKC and
> FCOE_WRFIX values
> Product: DPDK
> Version: unspecified
> Hardware: All
> OS: All
> Status: CONFIRMED
> Severity: normal
> Priority: Normal
> Component: ethdev
> Assignee: dev@dpdk.org
> Reporter: solal.pirelli@gmail.com
> Target Milestone: ---
>
> The Intel 82599 data sheet
> (https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/82599-10-gbe-controller-datasheet.pdf,
> §8.2.3.8.8) states that the RDRXCTL register's RSCACKC (bit 25) and FCOE_WRFIX
> (bit 26) values, while reserved, should be set to 1 by software.
>
> The ixgbe driver does not do that, e.g. in ixgbe_dev_rx_init
> (http://dpdk.org/browse/dpdk/tree/drivers/net/ixgbe/ixgbe_rxtx.c?h=v18.02#n4855).
It is done elsewhere.
static int
ixgbe_set_rsc(struct rte_eth_dev *dev)
{
...
/* Set RDRXCTL.RSCACKC bit */
rdrxctl = IXGBE_READ_REG(hw, IXGBE_RDRXCTL);
rdrxctl |= IXGBE_RDRXCTL_RSCACKC;
IXGBE_WRITE_REG(hw, IXGBE_RDRXCTL, rdrxctl);
prev parent reply other threads:[~2018-04-02 1:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 12:42 [Bug 22] Ixgbe driver sets RDRXCTL with the wrong RSCACKC and FCOE_WRFIX values bugzilla
2018-04-02 1:29 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180401182907.1d7aaa61@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.