All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 04/11] package/mesa3d: enable llvm support
Date: Sun, 1 Apr 2018 22:53:02 +0200	[thread overview]
Message-ID: <20180401225302.3a4284cd@windsurf> (raw)
In-Reply-To: <20180329113346.10367-5-valentin.korenblit@smile.fr>

Hello,

On Thu, 29 Mar 2018 13:33:39 +0200, Valentin Korenblit wrote:

> +config BR2_PACKAGE_MESA3D_LLVM
> +	bool "mesa3d w/ llvm"

We're already under the mesa3d option, so repeating mesa3d in the
prompt is not useless. Just "llvm support" is enough.

Should the option be: bool "llvmpipe" ? Or is LLVM used by mesa3d for
something else ?

> +	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
> +	select BR2_PACKAGE_LLVM
> +
> +comment "mesa3d w/ llvm needs llvm"
> +	depends on !BR2_PACKAGE_LLVM_ARCH_SUPPORTS

This comment doesn't make sense: BR2_PACKAGE_LLVM_ARCH_SUPPORTS is an
architecture limitation, and therefore that the user can do about it.
Just drop this comment.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-04-01 20:53 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 11:33 [Buildroot] [PATCH v4 00/11] llvm for mesa3d Valentin Korenblit
2018-03-29 11:33 ` [Buildroot] [PATCH v4 01/11] package/llvm: new host package Valentin Korenblit
2018-04-01 20:36   ` Thomas Petazzoni
2018-03-29 11:33 ` [Buildroot] [PATCH v4 02/11] package/llvm: enable target variant Valentin Korenblit
2018-04-01 20:46   ` Thomas Petazzoni
2018-04-01 22:50     ` Arnout Vandecappelle
2018-03-29 11:33 ` [Buildroot] [PATCH v4 03/11] package/llvm: enable AMDGPU Valentin Korenblit
2018-03-30  9:02   ` Thomas Petazzoni
2018-03-30 11:33     ` Valentin Korenblit
2018-03-30 18:08     ` Arnout Vandecappelle
2018-03-30 19:06       ` Thomas Petazzoni
2018-03-30 20:33         ` Valentin Korenblit
2018-04-01 20:47           ` Thomas Petazzoni
2018-03-29 11:33 ` [Buildroot] [PATCH v4 04/11] package/mesa3d: enable llvm support Valentin Korenblit
2018-04-01 20:53   ` Thomas Petazzoni [this message]
2018-04-02 10:05     ` Valentin Korenblit
2018-04-02 12:01       ` Thomas Petazzoni
2018-03-29 11:33 ` [Buildroot] [PATCH v4 05/11] package/llvm: enable ARM Valentin Korenblit
2018-04-01 20:53   ` Thomas Petazzoni
2018-03-29 11:33 ` [Buildroot] [PATCH v4 06/11] package/llvm: enable AArch64 Valentin Korenblit
2018-03-29 11:33 ` [Buildroot] [PATCH v4 07/11] package/clang: new host package Valentin Korenblit
2018-03-30 16:56   ` Matthew Weber
2018-03-30 20:24     ` Valentin Korenblit
2018-04-01 20:56   ` Thomas Petazzoni
2018-03-29 11:33 ` [Buildroot] [PATCH v4 08/11] package/clang: enable target variant Valentin Korenblit
2018-03-30  9:07   ` Thomas Petazzoni
2018-03-30 12:16     ` Valentin Korenblit
2018-03-30 12:37       ` Thomas Petazzoni
2018-03-30 17:58   ` Matthew Weber
2018-04-01 21:25   ` Thomas Petazzoni
2018-03-29 11:33 ` [Buildroot] [PATCH v4 09/11] package/libclc: new package Valentin Korenblit
2018-04-01 21:29   ` Thomas Petazzoni
2018-04-03 12:27     ` Valentin Korenblit
2018-04-03 15:17       ` Thomas Petazzoni
2018-04-03 16:26         ` Valentin Korenblit
2018-03-29 11:33 ` [Buildroot] [PATCH v4 10/11] package/mesa3d: enable OpenCL support Valentin Korenblit
2018-04-01 21:32   ` Thomas Petazzoni
2018-04-02  5:23     ` Erik Larsson
2018-04-02  6:51       ` Thomas Petazzoni
2018-04-02 10:36     ` Valentin Korenblit
2018-04-02 12:03       ` Thomas Petazzoni
2018-03-29 11:33 ` [Buildroot] [PATCH v4 11/11] package/clinfo: new package Valentin Korenblit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180401225302.3a4284cd@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.