From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "Mattias Rönnblom" <hofors@lysator.liu.se>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] eventdev: fix incorrect MP/MC tail updates in rte_event_ring
Date: Mon, 2 Apr 2018 08:25:22 +0530 [thread overview]
Message-ID: <20180402025521.GA23108@jerin> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA65E018DD7@IRSMSX101.ger.corp.intel.com>
-----Original Message-----
> Date: Thu, 29 Mar 2018 12:38:01 +0000
> From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
> To: Mattias Rönnblom <hofors@lysator.liu.se>, "dev@dpdk.org" <dev@dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH] eventdev: fix incorrect MP/MC tail updates
> in rte_event_ring
>
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mattias Rönnblom
> > Sent: Wednesday, March 28, 2018 10:17 AM
> > To: dev@dpdk.org
> > Cc: Mattias Rönnblom <hofors@lysator.liu.se>
> > Subject: [dpdk-dev] [PATCH] eventdev: fix incorrect MP/MC tail updates in
> > rte_event_ring
> >
> > rte_event_ring enqueue and dequeue tail updates were hardcoded for a
> > SC/SP configuration.
> >
> > Signed-off-by: Mattias Rönnblom <hofors@lysator.liu.se>
> > ---
>
> Hi Mattias,
>
>
> Thanks for your patch, a few notes;
>
> 1)
> You can CC the maintainer of a section - the event rings falls under
> the eventdev library, and Jerin Jacob is the maintainer.
>
>
> 2)
> In DPDK we note patches that are "Fixes",
> so we can track what commit they fix. Fixes patches are
> also often candidates for backporting.
>
> Details on getting the fixes line here:
> https://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body
>
> For this patch, the following is the fixline:
>
> Fixes: dc39e2f359b5 ("eventdev: add ring structure for events")
> Cc: bruce.richardson@intel.com
>
Hi Mattias,
Could you please the v2 version addressing Harry's comments.
next prev parent reply other threads:[~2018-04-02 2:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 9:16 [PATCH] eventdev: fix incorrect MP/MC tail updates in rte_event_ring Mattias Rönnblom
2018-03-29 12:38 ` Van Haaren, Harry
2018-04-02 2:55 ` Jerin Jacob [this message]
2018-04-03 8:14 ` Mattias Rönnblom
2018-04-03 8:19 ` Mattias Rönnblom
2018-04-04 0:52 ` Jerin Jacob
2018-04-04 8:52 ` Bruce Richardson
2018-04-04 9:46 ` Jerin Jacob
2018-04-04 10:36 ` Van Haaren, Harry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402025521.GA23108@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=hofors@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.