stubdom --disable-pv-grub has not effect

stubdom --disable-pv-grub has not effect

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 311 bytes --]

Since the source of pv-grub is not ready for todays compilers, and we have pvgrub2, I tried to disable it with --enable-stubdom --disable-pv-grub. But the toplevel Makefile does "make install-grub" unconditionally. I'm not familiar with stubdom. Is pvgrub a hard requirement for every stubdom variant?

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: stubdom --disable-pv-grub has not effect

[Wei Liu]

On Sun, Apr 01, 2018 at 08:19:25PM +0200, Olaf Hering wrote:
> Since the source of pv-grub is not ready for todays compilers, and we
> have pvgrub2, I tried to disable it with --enable-stubdom
> --disable-pv-grub. But the toplevel Makefile does "make install-grub"
> unconditionally. I'm not familiar with stubdom. Is pvgrub a hard
> requirement for every stubdom variant?

No. That's a bug in our build system.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: stubdom --disable-pv-grub has not effect

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 300 bytes --]

On Sun, Apr 01, Wei Liu wrote:

> No. That's a bug in our build system.

Thanks. For some reason only gcc48-4.8.3.rpm from SLE_11 is affected,
not gcc43-4.3.4.rpm from SLE_11 nor gcc48-4.8.5.rpm from SLE_12.
This fixes my packages for the time being:
sed -i '/ stubdom install-grub/d' Makefile

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: stubdom --disable-pv-grub has not effect

[Wei Liu]

On Mon, Apr 02, 2018 at 11:40:54AM +0200, Olaf Hering wrote:
> On Sun, Apr 01, Wei Liu wrote:
> 
> > No. That's a bug in our build system.
> 
> Thanks. For some reason only gcc48-4.8.3.rpm from SLE_11 is affected,
> not gcc43-4.3.4.rpm from SLE_11 nor gcc48-4.8.5.rpm from SLE_12.
> This fixes my packages for the time being:
> sed -i '/ stubdom install-grub/d' Makefile

I suppose you hit some sort of compile error because pv-grub has rotten?

The proper fix is, of course, make sure stubdom is really disabled. I
will see if I can get around to it at some point.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: stubdom --disable-pv-grub has not effect

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 408 bytes --]

Am Mon, 2 Apr 2018 10:44:23 +0100
schrieb Wei Liu <wei.liu2@citrix.com>:

> I suppose you hit some sort of compile error because pv-grub has rotten?

A post-build check scans the build log for warnings. Some of them are seen as fatal, and the otherwise successful build is marked as FAIL, no rpm package is provided. Since I have no need for pvgrub, disabling it seems like the obvious choice.

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel