From: Keith Busch <keith.busch@intel.com>
To: Linux PCI <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Oza Pawandeep <poza@codeaurora.org>,
Sinan Kaya <okaya@codeaurora.org>,
Keith Busch <keith.busch@intel.com>
Subject: [PATCHv2 6/7] PCI/AER: API for obtaining AER information
Date: Mon, 2 Apr 2018 10:22:02 -0600 [thread overview]
Message-ID: <20180402162203.3370-7-keith.busch@intel.com> (raw)
In-Reply-To: <20180402162203.3370-1-keith.busch@intel.com>
Since this is making the function externally visible, appending "aer_"
prefix to the function name.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
drivers/pci/pcie/aer/aerdrv.h | 1 +
drivers/pci/pcie/aer/aerdrv_core.c | 8 ++++----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/pcie/aer/aerdrv.h b/drivers/pci/pcie/aer/aerdrv.h
index 5449e5ce139d..7c833a1d897e 100644
--- a/drivers/pci/pcie/aer/aerdrv.h
+++ b/drivers/pci/pcie/aer/aerdrv.h
@@ -107,6 +107,7 @@ static inline pci_ers_result_t merge_result(enum pci_ers_result orig,
}
extern struct bus_type pcie_port_bus_type;
+int aer_get_device_error_info(struct pci_dev *dev, struct aer_err_info *info);
void aer_isr(struct work_struct *work);
void aer_print_error(struct pci_dev *dev, struct aer_err_info *info);
void aer_print_port_info(struct pci_dev *dev, struct aer_err_info *info);
diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c
index a4bfea52e7d4..4fb24003cac3 100644
--- a/drivers/pci/pcie/aer/aerdrv_core.c
+++ b/drivers/pci/pcie/aer/aerdrv_core.c
@@ -638,7 +638,7 @@ static void aer_recover_work_func(struct work_struct *work)
#endif
/**
- * get_device_error_info - read error status from dev and store it to info
+ * aer_get_device_error_info - read error status from dev and store it to info
* @dev: pointer to the device expected to have a error record
* @info: pointer to structure to store the error record
*
@@ -646,7 +646,7 @@ static void aer_recover_work_func(struct work_struct *work)
*
* Note that @info is reused among all error devices. Clear fields properly.
*/
-static int get_device_error_info(struct pci_dev *dev, struct aer_err_info *info)
+int aer_get_device_error_info(struct pci_dev *dev, struct aer_err_info *info)
{
int pos, temp;
@@ -705,11 +705,11 @@ static inline void aer_process_err_devices(struct pcie_device *p_device,
/* Report all before handle them, not to lost records by reset etc. */
for (i = 0; i < e_info->error_dev_num && e_info->dev[i]; i++) {
- if (get_device_error_info(e_info->dev[i], e_info))
+ if (aer_get_device_error_info(e_info->dev[i], e_info))
aer_print_error(e_info->dev[i], e_info);
}
for (i = 0; i < e_info->error_dev_num && e_info->dev[i]; i++) {
- if (get_device_error_info(e_info->dev[i], e_info))
+ if (aer_get_device_error_info(e_info->dev[i], e_info))
handle_error_source(p_device, e_info->dev[i], e_info);
}
}
--
2.14.3
next prev parent reply other threads:[~2018-04-02 16:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 16:21 [PATCHv2 0/7] DPC updates Keith Busch
2018-04-02 16:21 ` [PATCHv2 1/7] PCI/DPC: Enable ERR_COR Keith Busch
2018-04-02 21:23 ` Bjorn Helgaas
2018-04-02 23:09 ` Keith Busch
2018-04-03 14:16 ` Bjorn Helgaas
2018-04-03 14:31 ` Rafael J. Wysocki
2018-04-03 14:37 ` Keith Busch
2018-04-02 16:21 ` [PATCHv2 2/7] PCI/DPC: Fix PCI legacy interrupt acknowledgement Keith Busch
2018-04-03 20:38 ` Bjorn Helgaas
2018-04-03 23:04 ` Bjorn Helgaas
2018-04-04 8:13 ` Thomas Gleixner
2018-04-04 8:38 ` Lukas Wunner
2018-04-26 5:33 ` poza
2018-05-16 15:16 ` Timur Tabi
2018-05-16 21:04 ` Bjorn Helgaas
2018-04-02 16:21 ` [PATCHv2 3/7] PCI/DPC: Leave interrupts enabled while handling event Keith Busch
2018-04-02 16:22 ` [PATCHv2 4/7] PCI/DPC: Defer event handling to work queue Keith Busch
2018-04-02 16:22 ` [PATCHv2 5/7] PCI/DPC: Remove rp_pio_status from dpc struct Keith Busch
2018-04-02 16:22 ` Keith Busch [this message]
2018-04-09 10:03 ` [PATCHv2 6/7] PCI/AER: API for obtaining AER information David Laight
2018-04-09 14:37 ` Keith Busch
2018-04-02 16:22 ` [PATCHv2 7/7] PCI/DPC: Print AER status in DPC event handling Keith Busch
2018-05-17 15:02 ` poza
2018-05-17 15:04 ` poza
2018-06-19 21:31 ` [PATCHv2 0/7] DPC updates Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402162203.3370-7-keith.busch@intel.com \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=poza@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.