From: Daniel Scheller <d.scheller.oss@gmail.com>
To: linux-media@vger.kernel.org, mchehab@kernel.org,
mchehab@s-opensource.com
Subject: [PATCH 07/20] [media] ddbridge: request/free_irq using pci_irq_vector, enable MSI-X
Date: Mon, 2 Apr 2018 20:24:14 +0200 [thread overview]
Message-ID: <20180402182427.20918-8-d.scheller.oss@gmail.com> (raw)
In-Reply-To: <20180402182427.20918-1-d.scheller.oss@gmail.com>
From: Daniel Scheller <d.scheller@gmx.net>
Instead of trying to manage IRQ numbers on itself, utilise the
pci_irq_vector() function to do this, which will take care of correct IRQ
numbering for MSI and non-MSI IRQs. While at it, request and enable MSI-X
interrupts for hardware (boards and cards) that support this.
Picked up from the upstream dddvb-0.9.33 release.
Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
---
drivers/media/pci/ddbridge/ddbridge-main.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/media/pci/ddbridge/ddbridge-main.c b/drivers/media/pci/ddbridge/ddbridge-main.c
index 77089081db1f..008be9066814 100644
--- a/drivers/media/pci/ddbridge/ddbridge-main.c
+++ b/drivers/media/pci/ddbridge/ddbridge-main.c
@@ -77,8 +77,8 @@ static void ddb_irq_exit(struct ddb *dev)
{
ddb_irq_disable(dev);
if (dev->msi == 2)
- free_irq(dev->pdev->irq + 1, dev);
- free_irq(dev->pdev->irq, dev);
+ free_irq(pci_irq_vector(dev->pdev, 1), dev);
+ free_irq(pci_irq_vector(dev->pdev, 0), dev);
}
static void ddb_remove(struct pci_dev *pdev)
@@ -105,7 +105,8 @@ static void ddb_irq_msi(struct ddb *dev, int nr)
int stat;
if (msi && pci_msi_enabled()) {
- stat = pci_alloc_irq_vectors(dev->pdev, 1, nr, PCI_IRQ_MSI);
+ stat = pci_alloc_irq_vectors(dev->pdev, 1, nr,
+ PCI_IRQ_MSI | PCI_IRQ_MSIX);
if (stat >= 1) {
dev->msi = stat;
dev_info(dev->dev, "using %d MSI interrupt(s)\n",
@@ -137,21 +138,24 @@ static int ddb_irq_init(struct ddb *dev)
if (dev->msi)
irq_flag = 0;
if (dev->msi == 2) {
- stat = request_irq(dev->pdev->irq, ddb_irq_handler0,
- irq_flag, "ddbridge", (void *)dev);
+ stat = request_irq(pci_irq_vector(dev->pdev, 0),
+ ddb_irq_handler0, irq_flag, "ddbridge",
+ (void *)dev);
if (stat < 0)
return stat;
- stat = request_irq(dev->pdev->irq + 1, ddb_irq_handler1,
- irq_flag, "ddbridge", (void *)dev);
+ stat = request_irq(pci_irq_vector(dev->pdev, 1),
+ ddb_irq_handler1, irq_flag, "ddbridge",
+ (void *)dev);
if (stat < 0) {
- free_irq(dev->pdev->irq, dev);
+ free_irq(pci_irq_vector(dev->pdev, 0), dev);
return stat;
}
} else
#endif
{
- stat = request_irq(dev->pdev->irq, ddb_irq_handler,
- irq_flag, "ddbridge", (void *)dev);
+ stat = request_irq(pci_irq_vector(dev->pdev, 0),
+ ddb_irq_handler, irq_flag, "ddbridge",
+ (void *)dev);
if (stat < 0)
return stat;
}
--
2.16.1
next prev parent reply other threads:[~2018-04-02 18:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 18:24 [PATCH 00/20] dddvb/ddbridge-0.9.33 Daniel Scheller
2018-04-02 18:24 ` [PATCH 01/20] [media] dvb-frontends/stv0910: add init values for TSINSDELM/L Daniel Scheller
2018-04-02 18:24 ` [PATCH 02/20] [media] dvb-frontends/stv0910: increase parallel TS output speed Daniel Scheller
2018-04-02 18:24 ` [PATCH 03/20] [media] dvb-frontends/stv0910: fix CNR reporting in read_snr() Daniel Scheller
2018-04-02 18:24 ` [PATCH 04/20] [media] ddbridge: move modparams to ddbridge-core.c Daniel Scheller
2018-04-02 18:24 ` [PATCH 05/20] [media] ddbridge: move ddb_wq and the wq+class initialisation to -core Daniel Scheller
2018-04-02 18:24 ` [PATCH 06/20] [media] ddbridge: move MSI IRQ cleanup to a helper function Daniel Scheller
2018-04-02 18:24 ` Daniel Scheller [this message]
2018-04-02 18:24 ` [PATCH 08/20] [media] ddbridge: add helper for IRQ handler setup Daniel Scheller
2018-04-02 18:24 ` [PATCH 09/20] [media] ddbridge: add macros to handle IRQs in nibble and byte blocks Daniel Scheller
2018-04-02 18:24 ` [PATCH 10/20] [media] ddbridge: improve separated MSI IRQ handling Daniel Scheller
2018-04-02 18:24 ` [PATCH 11/20] [media] ddbridge: use spin_lock_irqsave() in output_work() Daniel Scheller
2018-04-02 18:24 ` [PATCH 12/20] [media] ddbridge: fix output buffer check Daniel Scheller
2018-04-02 18:24 ` [PATCH 13/20] [media] ddbridge: set devid entry for link 0 Daniel Scheller
2018-04-02 18:24 ` [PATCH 14/20] [media] ddbridge: make DMA buffer count and size modparam-configurable Daniel Scheller
2018-04-02 18:24 ` [PATCH 15/20] [media] ddbridge: support dummy tuners with 125MByte/s dummy data stream Daniel Scheller
2018-04-02 18:24 ` [PATCH 16/20] [media] ddbridge: initial support for MCI-based MaxSX8 cards Daniel Scheller
2018-04-02 18:24 ` [PATCH 17/20] [media] ddbridge/max: implement MCI/MaxSX8 attach function Daniel Scheller
2018-04-02 18:24 ` [PATCH 18/20] [media] ddbridge: add hardware defs and PCI IDs for MCI cards Daniel Scheller
2018-04-02 18:24 ` [PATCH 19/20] [media] ddbridge: recognize and attach the MaxSX8 cards Daniel Scheller
2018-04-02 18:24 ` [PATCH 20/20] [media] ddbridge: set driver version to 0.9.33-integrated Daniel Scheller
2018-04-05 20:45 ` [PATCH 00/20] dddvb/ddbridge-0.9.33 Daniel Scheller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402182427.20918-8-d.scheller.oss@gmail.com \
--to=d.scheller.oss@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mchehab@s-opensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.