From: linux-kernel-dev at beckhoff.com <linux-kernel-dev@beckhoff.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/3] dm: led: add testcase for "default-state" property
Date: Wed, 4 Apr 2018 10:01:03 +0200 [thread overview]
Message-ID: <20180404080103.28033-4-linux-kernel-dev@beckhoff.com> (raw)
In-Reply-To: <20180404080103.28033-1-linux-kernel-dev@beckhoff.com>
From: Patrick Bruenn <p.bruenn@beckhoff.com>
Add two more gpio-leds to sandbox test device tree with default-state
property set to "on"/"off".
Add dm_test_led_default_state() to check that these new LED's are set to
LEDST_ON and LEDST_OFF.
Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>
---
patman complains about: test/dm/led.c:45: check: Please use a blank line
after function/struct/union/enum declarations.
I compared with other DM_TEST() usage and decided to ignore this check.
Should we fix the macro, patman or keep ignoring this?
Changes in v3: None
Changes in v2: None
arch/sandbox/dts/test.dts | 12 ++++++++++++
test/dm/led.c | 16 ++++++++++++++++
2 files changed, 28 insertions(+)
diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index 06d0e8ce85..07f9bad258 100644
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -254,6 +254,18 @@
gpios = <&gpio_a 2 0>;
label = "sandbox:green";
};
+
+ default_on {
+ gpios = <&gpio_a 3 0>;
+ label = "sandbox:default_on";
+ default-state = "on";
+ };
+
+ default_off {
+ gpios = <&gpio_a 4 0>;
+ label = "sandbox:default_off";
+ default-state = "off";
+ };
};
mbox: mbox {
diff --git a/test/dm/led.c b/test/dm/led.c
index fde700be38..c560abc4fb 100644
--- a/test/dm/led.c
+++ b/test/dm/led.c
@@ -28,6 +28,22 @@ static int dm_test_led_base(struct unit_test_state *uts)
}
DM_TEST(dm_test_led_base, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+/* Test of the LED 'default-state' device tree property */
+static int dm_test_led_default_state(struct unit_test_state *uts)
+{
+ struct udevice *dev;
+
+ /* Check that we handle the default-state property correctly. */
+ ut_assertok(led_get_by_label("sandbox:default_on", &dev));
+ ut_asserteq(LEDST_ON, led_get_state(dev));
+
+ ut_assertok(led_get_by_label("sandbox:default_off", &dev));
+ ut_asserteq(LEDST_OFF, led_get_state(dev));
+
+ return 0;
+}
+DM_TEST(dm_test_led_default_state, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+
/* Test of the led uclass using the led_gpio driver */
static int dm_test_led_gpio(struct unit_test_state *uts)
{
--
2.11.0
next prev parent reply other threads:[~2018-04-04 8:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 8:01 [U-Boot] [PATCH v3 0/3] This series adds support for gpio-leds "default-state" property. The linux-kernel-dev at beckhoff.com
2018-04-04 8:01 ` [U-Boot] [PATCH v3 1/3] dm: led: Support "default-state" property linux-kernel-dev at beckhoff.com
2018-04-08 13:55 ` Simon Glass
2018-04-04 8:01 ` [U-Boot] [PATCH v3 2/3] dm: led: auto probe() LEDs with "default-state" linux-kernel-dev at beckhoff.com
2018-04-08 13:55 ` Simon Glass
2018-04-04 8:01 ` linux-kernel-dev at beckhoff.com [this message]
2018-04-08 13:55 ` [U-Boot] [PATCH v3 3/3] dm: led: add testcase for "default-state" property Simon Glass
2018-04-10 16:22 ` [U-Boot] [U-Boot, v3, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404080103.28033-4-linux-kernel-dev@beckhoff.com \
--to=linux-kernel-dev@beckhoff.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.