From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Tariq Toukan <tariqt@mellanox.com>
Cc: netdev@vger.kernel.org, BjörnTöpel <bjorn.topel@intel.com>,
magnus.karlsson@intel.com, eugenia@mellanox.com,
"Jason Wang" <jasowang@redhat.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Eran Ben Elisha" <eranbe@mellanox.com>,
"Saeed Mahameed" <saeedm@mellanox.com>,
galp@mellanox.com, "Daniel Borkmann" <borkmann@iogearbox.net>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
brouer@redhat.com
Subject: Re: [net-next V9 PATCH 14/16] mlx5: use page_pool for xdp_return_frame call
Date: Wed, 4 Apr 2018 15:36:37 +0200 [thread overview]
Message-ID: <20180404153637.7f9b655c@redhat.com> (raw)
In-Reply-To: <72eccc60-21d2-0789-81c6-1bad2adb41ed@mellanox.com>
On Wed, 4 Apr 2018 16:12:14 +0300
Tariq Toukan <tariqt@mellanox.com> wrote:
> > @@ -432,9 +434,12 @@ static int mlx5e_alloc_rq(struct mlx5e_channel *c,
> >
> > rq->buff.map_dir = rq->xdp_prog ? DMA_BIDIRECTIONAL : DMA_FROM_DEVICE;
> > rq->buff.headroom = mlx5e_get_rq_headroom(mdev, params);
> > + pool_size = 1 << params->log_rq_mtu_frames;
> >
> > switch (rq->wq_type) {
> > case MLX5_WQ_TYPE_LINKED_LIST_STRIDING_RQ:
> > +
> > + pool_size = pool_size * MLX5_MPWRQ_PAGES_PER_WQE;
>
> For rq->wq_type != MLX5_WQ_TYPE_LINKED_LIST_STRIDING_RQ, please use:
> pool_size = 1 << params->log_rq_mtu_frames;
>
> For rq->wq_type == MLX5_WQ_TYPE_LINKED_LIST_STRIDING_RQ, please use:
> pool_size = MLX5_MPWRQ_PAGES_PER_WQ * mlx5e_mpwqe_get_log_rq_size(params);
Okay, fixed. Ready for V10, when net-next opens again...
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-04-04 13:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 11:07 [net-next V9 PATCH 00/16] XDP redirect memory return API Jesper Dangaard Brouer
2018-04-03 11:07 ` [net-next V9 PATCH 01/16] mlx5: basic XDP_REDIRECT forward support Jesper Dangaard Brouer
2018-04-03 11:07 ` [net-next V9 PATCH 02/16] xdp: introduce xdp_return_frame API and use in cpumap Jesper Dangaard Brouer
2018-04-03 11:07 ` [net-next V9 PATCH 03/16] ixgbe: use xdp_return_frame API Jesper Dangaard Brouer
2018-04-03 11:07 ` [net-next V9 PATCH 04/16] xdp: move struct xdp_buff from filter.h to xdp.h Jesper Dangaard Brouer
2018-04-03 11:08 ` [net-next V9 PATCH 05/16] xdp: introduce a new xdp_frame type Jesper Dangaard Brouer
2018-04-03 11:08 ` [net-next V9 PATCH 06/16] tun: convert to use generic xdp_frame and xdp_return_frame API Jesper Dangaard Brouer
2018-04-03 11:08 ` [net-next V9 PATCH 07/16] virtio_net: " Jesper Dangaard Brouer
2018-04-03 11:08 ` [net-next V9 PATCH 08/16] bpf: cpumap convert to use generic xdp_frame Jesper Dangaard Brouer
2018-04-03 11:08 ` [net-next V9 PATCH 09/16] i40e: convert to use generic xdp_frame and xdp_return_frame API Jesper Dangaard Brouer
2018-04-03 11:08 ` [net-next V9 PATCH 10/16] mlx5: register a memory model when XDP is enabled Jesper Dangaard Brouer
2018-04-03 11:08 ` [net-next V9 PATCH 11/16] xdp: rhashtable with allocator ID to pointer mapping Jesper Dangaard Brouer
2018-04-03 11:08 ` [net-next V9 PATCH 12/16] page_pool: refurbish version of page_pool code Jesper Dangaard Brouer
2018-04-03 11:08 ` [net-next V9 PATCH 13/16] xdp: allow page_pool as an allocator type in xdp_return_frame Jesper Dangaard Brouer
2018-04-03 11:08 ` [net-next V9 PATCH 14/16] mlx5: use page_pool for xdp_return_frame call Jesper Dangaard Brouer
2018-04-04 13:12 ` Tariq Toukan
2018-04-04 13:36 ` Jesper Dangaard Brouer [this message]
2018-04-03 11:08 ` [net-next V9 PATCH 15/16] xdp: transition into using xdp_frame for return API Jesper Dangaard Brouer
2018-04-03 11:08 ` [net-next V9 PATCH 16/16] xdp: transition into using xdp_frame for ndo_xdp_xmit Jesper Dangaard Brouer
2018-04-03 14:54 ` [net-next V9 PATCH 00/16] XDP redirect memory return API David Miller
2018-04-03 16:07 ` Jesper Dangaard Brouer
2018-04-03 16:23 ` David Miller
2018-04-03 17:03 ` Saeed Mahameed
2018-04-04 8:41 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404153637.7f9b655c@redhat.com \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=borkmann@iogearbox.net \
--cc=eranbe@mellanox.com \
--cc=eugenia@mellanox.com \
--cc=galp@mellanox.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.