From: Stephen Hemminger <stephen@networkplumber.org>
To: Guillaume Nault <g.nault@alphalink.fr>
Cc: netdev@vger.kernel.org, James Chapman <jchapman@katalix.com>
Subject: Re: [PATCH iproute2] ip/l2tp: remove offset and peer-offset options
Date: Wed, 4 Apr 2018 16:43:10 -0700 [thread overview]
Message-ID: <20180404164310.43259e82@xeon-e3> (raw)
In-Reply-To: <46d360e852235de84e44c796fa934f9cfce988b1.1522769819.git.g.nault@alphalink.fr>
On Tue, 3 Apr 2018 17:39:54 +0200
Guillaume Nault <g.nault@alphalink.fr> wrote:
> Ignore options "peer-offset" and "offset" when creating sessions. Keep
> them when dumping sessions in order to avoid breaking external scripts.
>
> "peer-offset" has always been a noop in iproute2. "offset" is now
> ignored in Linux 4.16 (and was broken before that).
>
> Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Sure, this makes sense applied.
In theory, you could have just dropped them from the JSON output.
next prev parent reply other threads:[~2018-04-04 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 15:39 [PATCH iproute2] ip/l2tp: remove offset and peer-offset options Guillaume Nault
2018-04-04 23:43 ` Stephen Hemminger [this message]
2018-04-05 17:19 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404164310.43259e82@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=g.nault@alphalink.fr \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.