All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrey Vagin <avagin@openvz.org>,
	Andrew Morton <akpm@linuxfoundation.org>,
	Pavel Emelyanov <xemul@virtuozzo.com>,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	Yang Shi <yang.shi@linux.alibaba.com>,
	Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH] prctl: Deprecate non PR_SET_MM_MAP operations
Date: Thu, 5 Apr 2018 00:29:06 +0300	[thread overview]
Message-ID: <20180404212906.GJ15783@uranus.lan> (raw)
In-Reply-To: <467373a7-8b2b-971c-4e62-7fae043c96fe@infradead.org>

On Wed, Apr 04, 2018 at 01:53:08PM -0700, Randy Dunlap wrote:
> > 
> > At first this was plain warning without code removal but I've
> > been advised that dropping it completely may be a better idea
> > which I agree https://lkml.org/lkml/2018/4/4/31 Or you mean the
> > warning message itsef? We aready have similars, for example
> > in kernel/auditfilter.c
> 
> The traditional way (eons ago) to deprecate something was to add a
> printk() and then delete the feature a few years later.
> Still, I have no objection to dropping that prctl.
> 
> Sorry if I wasn't clear.  I was objecting to the "language", i.e., to the
> word "deprecated."  Deprecated means frowned on, advised against, etc.
> It does not mean "deleted."

True. I remember this rule of deprecation. But when I dropped the
code I though which message to put here (or should I put it at
all) and since "deprecated" was the first word came into mind
I decided to grep sources, the result you see by its own :)

> 
> > printk(KERN_ERR "AUDIT_POSSIBLE is deprecated\n");
> 
> Yeah, that one's wrong also.  :)

So, maybe just get rid of any warning message at all?

  reply	other threads:[~2018-04-04 21:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04 18:55 [PATCH] prctl: Deprecate non PR_SET_MM_MAP operations Cyrill Gorcunov
2018-04-04 19:24 ` Randy Dunlap
2018-04-04 20:04   ` Cyrill Gorcunov
2018-04-04 20:53     ` Randy Dunlap
2018-04-04 21:29       ` Cyrill Gorcunov [this message]
2018-04-04 21:36         ` Randy Dunlap
2018-04-04 21:39           ` Cyrill Gorcunov
2018-04-05  5:42         ` Michal Hocko
2018-04-04 21:16 ` Yang Shi
2018-04-04 21:26   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180404212906.GJ15783@uranus.lan \
    --to=gorcunov@gmail.com \
    --cc=akpm@linuxfoundation.org \
    --cc=avagin@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=xemul@virtuozzo.com \
    --cc=yang.shi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.