From: Dave Chinner <david@fromorbit.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
Dmitry Vyukov <dvyukov@google.com>,
syzbot <syzbot+dc5ab2babdf22ca091af@syzkaller.appspotmail.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
syzkaller-bugs@googlegroups.com,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: WARNING in up_write
Date: Fri, 6 Apr 2018 08:32:26 +1000 [thread overview]
Message-ID: <20180405223226.GA729@dastard> (raw)
In-Reply-To: <20180405032454.GD9301@bombadil.infradead.org>
On Wed, Apr 04, 2018 at 08:24:54PM -0700, Matthew Wilcox wrote:
> On Wed, Apr 04, 2018 at 11:22:00PM -0400, Theodore Y. Ts'o wrote:
> > On Wed, Apr 04, 2018 at 12:35:04PM -0700, Matthew Wilcox wrote:
> > > On Wed, Apr 04, 2018 at 09:24:05PM +0200, Dmitry Vyukov wrote:
> > > > On Tue, Apr 3, 2018 at 4:01 AM, syzbot
> > > > <syzbot+dc5ab2babdf22ca091af@syzkaller.appspotmail.com> wrote:
> > > > > DEBUG_LOCKS_WARN_ON(sem->owner != get_current())
> > > > > WARNING: CPU: 1 PID: 4441 at kernel/locking/rwsem.c:133 up_write+0x1cc/0x210
> > > > > kernel/locking/rwsem.c:133
> > > > > Kernel panic - not syncing: panic_on_warn set ...
> > >
> > > Message-Id: <1522852646-2196-1-git-send-email-longman@redhat.com>
> > >
> >
> > We were way ahead of syzbot in this case. :-)
>
> Not really ... syzbot caught it Monday evening ;-)
Rather than arguing over who reported it first, I think that time
would be better spent reflecting on why the syzbot report was
completely ignored until *after* Ted diagnosed the issue
independently and Waiman had already fixed it....
Clearly there is scope for improvement here.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-04-05 22:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 2:01 WARNING in up_write syzbot
2018-04-04 19:24 ` Dmitry Vyukov
2018-04-04 19:35 ` Matthew Wilcox
2018-04-05 3:22 ` Theodore Y. Ts'o
2018-04-05 3:24 ` Matthew Wilcox
2018-04-05 8:22 ` Dmitry Vyukov
2018-09-04 8:28 ` Dmitry Vyukov
2018-04-05 22:32 ` Dave Chinner [this message]
2018-04-06 0:13 ` Eric Biggers
2018-04-06 1:37 ` Theodore Y. Ts'o
2018-04-08 6:31 ` Running syzkaller repros using kvm-xfstests Theodore Y. Ts'o
2018-04-08 13:18 ` Dmitry Vyukov
2018-04-08 18:02 ` Theodore Y. Ts'o
2018-04-09 9:28 ` Dmitry Vyukov
2018-04-06 2:01 ` WARNING in up_write Dave Chinner
2018-04-13 18:25 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405223226.GA729@dastard \
--to=david@fromorbit.com \
--cc=dvyukov@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+dc5ab2babdf22ca091af@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.